Code Check

[StormInk]

Hello. I was wondering if any of this code is out of date or incorretly phrased, or simply wrong.

Because, for some reason, on my forums. The subscribed members total won't refresh. It only refreshes if I delete a member first.

function show_totals()
	{
		global $DB, $ibforums, $std;

	if ($ibforums->vars['show_totals'])
	{
		if ( ! is_array( $ibforums->cache['stats'] ) )
		{
			$ibforums->cache['stats'] = array();

			$DB->simple_exec_query( array( 'delete' => 'cache_store', 'where' => "cs_key='stats'" ) );
			$DB->do_insert( 'cache_store', array( 'cs_array' => 1, 'cs_key' => 'stats', 'cs_value' => addslashes(serialize($ibforums->cache['stats'])) ) );
		}

		$stats = $ibforums->cache['stats'];

		//----------------------------------------
		// Update the most active count if needed
		//----------------------------------------

		if ($this->users_online > $stats['most_count'])
		{
			$stats['most_count'] = $this->users_online;
			$stats['most_date']  = time();

			$DB->do_update( 'cache_store',
							array( 'cs_array' => 1, 'cs_value' => addslashes(serialize($stats)) ),
						    "cs_key='stats'"
						  );
		}

		$most_time = $std->get_date( $stats['most_date'], 'LONG' );

		$ibforums->lang['most_online'] = str_replace( "<#NUM#>" ,   $std->do_number_format($stats['most_count'])  , $ibforums->lang['most_online'] );
		$ibforums->lang['most_online'] = str_replace( "<#DATE#>",                   $most_time                    , $ibforums->lang['most_online'] );

		$total_posts = $stats['total_replies'] + $stats['total_topics'];

		$total_posts        = $std->do_number_format($total_posts);
		$stats['mem_count'] = $std->do_number_format($stats['mem_count']);

		$this->total_posts    = $total_posts;
		$this->total_members  = $stats['mem_count'];

		$link = $ibforums->base_url."showuser=".$stats['last_mem_id'];

		$ibforums->lang['total_word_string'] = str_replace( "<#posts#>" , "$total_posts"          , $ibforums->lang['total_word_string'] );
		$ibforums->lang['total_word_string'] = str_replace( "<#reg#>"   , $stats['mem_count']     , $ibforums->lang['total_word_string'] );
		$ibforums->lang['total_word_string'] = str_replace( "<#mem#>"   , $stats['last_mem_name'] , $ibforums->lang['total_word_string'] );
		$ibforums->lang['total_word_string'] = str_replace( "<#link#>"  , $link                   , $ibforums->lang['total_word_string'] );

		$stats_html .= $this->class->html->ShowStats($ibforums->lang['total_word_string']);

	}

	return $stats_html;

}



}

Thanks.

[StormInk]

Also... Here is the file that calls the thing it returns in that code.

//-----------------------------------
		// Add in show stats
		//-----------------------------------

	$stats_html .= $this->statfunc->show_totals();


	if ($stats_html != "")
	{
		$collapsed_ids = ','.$std->my_getcookie('collapseprefs').',';

		$show['div_fo'] = 'show';
		$show['div_fc'] = 'none';

		if ( strstr( $collapsed_ids, ',stat,' ) )
		{
			$show['div_fo'] = 'none';
			$show['div_fc'] = 'show';
		}

		$this->output .= $this->html->stats_header($this->statfunc->users_online, $this->statfunc->total_posts, $this->statfunc->total_members, $show);
		$this->output .= $stats_html;
		$this->output .= $this->html->stats_footer();
	}

I know its alot to read, but is anything wrong with that?

[StormInk]

One more...

This is where the index.php calls the 2nd piece of code I posted:

//===========================================================================
// REQUIRE AND RUN
//===========================================================================                

if ( $ibforums->input['act'] == 'home' )
{
	if ( $ibforums->vars['csite_on'] )
	{
		require ROOT_PATH."sources/ipbportal.php";
		$csite = new ipdl();
		$csite->auto_run();
	}
	else
	{
		require ROOT_PATH."sources/boards.php";
		$runme = new boards();
		$runme->auto_run();
	}
}
else if ( $ibforums->input['act'] == 'module' )
{
	if ( USE_MODULES == 1 )
	{
		require ROOT_PATH."modules/module_loader.php";
		$loader = new module_loader();
	}
	else
	{
		require ROOT_PATH."sources/boards.php";
	}
}
else
{
	// Require and run

require_once( ROOT_PATH."sources/".$choice[ strtolower($ibforums->input['act']) ][0].".php" );

$runme = new $choice[ strtolower($ibforums->input['act']) ][1];
$runme->auto_run();
}

Anything wrong with that? I think in the second IF statement, it never runs the 'boards.php'...