Better code

hasse

Howdy.

As you see from my code I spend 5 lines of code to get the value of a query that always returnes a single value.

// Get the last SKU
$query = "SELECT MAX(productcode) FROM $products_table";
$lastskusql = $this->database->query($query);
$lastsku = $lastskusql->fetch_row();
$sku = $lastsku[0];

// Set current sku
$sku++;

Surely there must be a more direct way of doing this with mysqli?
(i.e. Query->result->$sku instead of Query->result->array->$sku)

I know it's not a huge thing, but every little helps

Thanks!

LordShryku

It looks more like a database design change would help. From what I gather, you're just autoincrementing that product code. So why not setup that field as an autoincrementing number in the database?

devinemke

there does not appear to be a [man]mysqli[/man] version of the old [man]mysql_result[/man] function.

$result = $this->database->query("SELECT MAX(productcode) FROM $products_table");
$lastsku = mysql_result($result, 0);

hasse

Regarding autoincrement. Well.. This is a field in xcart, and I have decided to leave it unchanged, and do whatever bits in my own code, hence the php increment.

Now, can one mix mysqli and mysql?

Can't find a result resource in mysqli, as $this->database->query only returns an object.