Error message, even when form fields are completed correctly ? ?

Saz

Hi all, I've just started on the road to learning more about php, so please bear with me.

The code below is supposed to give an error when people don't enter anything into the day in or day out sections below, but, they still get the error messages, even when they do enter something into those drop down fields??

Can anyone lend a hand please?

Any help appreciated.

Saz.

<? ob_start(); ?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">

function numberOfIntegers($String)
{

$x=0;
$numOfInts=0;

while ($x < strlen($String))
{

if (is_numeric($String{$x}))
{
  $numOfInts++;
}
$x++;

}

return $numOfInts;

}

?>
<HTML>
<BODY BGCOLOR="#FFFFFF">

// Check to see if the form has been submitted
if ($_GET["submit"])
{

// Assign 0 to the error variable
$Error = 0;

// Let's extract the GET form field elements
extract($_GET);

$ValidEmail = substr_count($email, '@');
$ValidEmail1 = substr_count($email, '.');

// Now, we'll check to see if ANY of the form elements are blank
if (!($name) || !($email) || !($phone) || !($day_in) || !($day_out)
|| ($ValidEmail < 1) || ($ValidEmail1 < 1) || ((numberOfIntegers($phone)) < 6) || !($number_of_people))
{
// at least one of the form fields are blank
if (!($day_in))
{
$Error = 1;
$ErrorDay_in = 1;
}

   if (!($day_out))
{
  $Error = 1;
  $ErrorDay_out = 1;
}


if (!($name))
{
  $Error = 1;
  $ErrorName = 1;
}

if (!($phone))
{
  $Error = 1;
  $ErrorPhone = 1;
}

if (!($email))
{
  $Error = 1;
  $ErrorEmail = 1;
}

if (!($number_of_people))
{
  $Error = 1;
  $ErrorNumber_of_people = 1;
}

} else {

// all the form fields are filled in with data

// email the data to YOUR email address
$To = "emailaddress@example.com";
$Subject = "Form submission";
$Message = "Name: $name \nEmail: $email \nPhone: $phone \nDay_in: $day_in \nDay_out: $day_out \nComments: $comments";
mail($To, $Subject, $Message, "From: $email");

// email a copy of this message to the USER'S email address
$replyTo = $email;
$replySubject = "Form submission";
$replyMessage = "Your submission: \n\nName: $name \nEmail: $email \nPhone: $phone \nDay_in: $day_in \nDay_out: $day_out \nComments: $comments";
mail($replyTo, $replySubject, $replyComments, "From: $To");

// redirect to the thank you page
header("Location: http://www.example.com/301205/thanks.php");

}

}
?>

<? if ($Error > 0)
{
// Instruct the user that an error is present
echo "<strong>Oops, you did not fill out all required fields. Those fields are marked below.</strong> <br />";
} elseif ((($ValidEmail < 1) || ($ValidEmail1 < 1)) && ($GET["submit"])) {
echo "<strong>Oops, you did not provide a valid email address. Please try again.</strong> <br />";
$highlightEmail = 1;
} elseif ((numberOfIntegers($phone) < 6) && ($GET["submit"])) {

echo "<strong>Oops, you did not provide a valid telephone number.  Please ensure that your phone ";
echo "number contains AT LEAST 6 NUMBERS and submit the form again.</strong> <br />";
$highlightPhone = 1;

}
?>

<form action="index.php" method="GET">
<table width="100%">
<tr>
<td align="left" width="30%">
<? if (($Error == 1) && ($ErrorDay_in == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Date in:
</td>
<td align="left" width="68%" valign="bottom">
<SELECT style="maintext" name="Day_in" onchange="Form1.Month_and_year_in.focus()">
<OPTION selected></OPTION> <OPTION>1</OPTION> <OPTION>2</OPTION> <OPTION>3</OPTION> <OPTION>4</OPTION> <OPTION>5</OPTION>
<OPTION>6</OPTION> <OPTION>7</OPTION> <OPTION>8</OPTION> <OPTION>9</OPTION>
<OPTION>10</OPTION> <OPTION>11</OPTION> <OPTION>12</OPTION> <OPTION>13</OPTION>
<OPTION>14</OPTION> <OPTION>15</OPTION> <OPTION>16</OPTION> <OPTION>17</OPTION>
<OPTION>18</OPTION> <OPTION>19</OPTION> <OPTION>20</OPTION> <OPTION>21</OPTION>
<OPTION>22</OPTION> <OPTION>23</OPTION> <OPTION>24</OPTION> <OPTION>25</OPTION>
<OPTION>26</OPTION> <OPTION>27</OPTION> <OPTION>28</OPTION> <OPTION>29</OPTION>
<OPTION>30</OPTION> <OPTION>31</OPTION></SELECT> 
<SELECT style="maintext" name="Month_and_year_in" onchange="Form1.Day_out.focus()">
<OPTION selected></OPTION> <OPTION>December 2005</OPTION>
<OPTION>January 2006</OPTION>
<OPTION>February 2006</OPTION> <OPTION>March 2006</OPTION>
<OPTION>April 2006</OPTION> <OPTION>May 2006</OPTION>
<OPTION>June 2006</OPTION> <OPTION>July 2006</OPTION>
<OPTION>August 2006</OPTION> <OPTION>September 2006</OPTION>
<OPTION>October 2006</OPTION> <OPTION>November 2006</OPTION>
</SELECT></td></tr>
<tr>
<td align="left" width="30%">
<? if (($Error == 1) && ($ErrorDay_out == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Date out:
</td>
<td align="left" width="68%" valign="bottom">
<SELECT style="maintext" name="Day_out" onchange="Form1.Month_and_year_out.focus()">
<OPTION selected></OPTION> <OPTION>1</OPTION>
<OPTION>2</OPTION> <OPTION>3</OPTION> <OPTION>4</OPTION> <OPTION>5</OPTION> <OPTION>6</OPTION>
<OPTION>7</OPTION> <OPTION>8</OPTION> <OPTION>9</OPTION> <OPTION>10</OPTION>
<OPTION>11</OPTION> <OPTION>12</OPTION> <OPTION>13</OPTION> <OPTION>14</OPTION>
<OPTION>15</OPTION> <OPTION>16</OPTION> <OPTION>17</OPTION> <OPTION>18</OPTION>
<OPTION>19</OPTION> <OPTION>20</OPTION> <OPTION>21</OPTION> <OPTION>22</OPTION>
<OPTION>23</OPTION> <OPTION>24</OPTION> <OPTION>25</OPTION> <OPTION>26</OPTION>
<OPTION>27</OPTION> <OPTION>28</OPTION> <OPTION>29</OPTION>
<OPTION>30</OPTION> <OPTION>31</OPTION></SELECT> 
<SELECT style="maintext" name="Month_and_year_out" onchange="Form1.Name.focus()">
<OPTION selected></OPTION> <OPTION>December 2005</OPTION>
<OPTION>January 2006</OPTION>
<OPTION>February 2006</OPTION> <OPTION>March 2006</OPTION>
<OPTION>April 2006</OPTION> <OPTION>May 2006</OPTION>
<OPTION>June 2006</OPTION> <OPTION>July 2006</OPTION>
<OPTION>August 2006</OPTION> <OPTION>September 2006</OPTION>
<OPTION>October 2006</OPTION> <OPTION>November 2006</OPTION>
</SELECT>
</td></tr>
<tr>
<td align="left" width="30%">
<? if (($Error == 1) && ($ErrorName == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Name:
</td>
<td align="left" width="68%" valign="bottom"><input type="text" name="name" size="26" value="<? echo $name; ?>">
</td></tr>
<tr><td align="left" width="30%">
<? if (($Error == 1) && ($ErrorPhone == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Telephone number:
</td>
<td align="left" width="68%"><input type="text" name="phone" size="26" value="<? echo $phone; ?>">
</td></tr>
<tr><td align="left" width="30%">
<? if (($Error == 1) && ($ErrorEmail == 1) || ($highlightEmail == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Email address:
</td>
<td align="left" width="68%"><input type="text" name="email" size="26" value="<? echo $email; ?>">
</td></tr>
<tr><td align="left" width="30%">
<? if (($Error == 1) && ($ErrorNumber_of_people == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Number of people:
</td>
<td align="left" width="68%" valign="bottom"><SELECT style="maintext" name="Number_of_people" onchange="Form1.send.focus()">
<OPTION selected> </OPTION>
<OPTION>1</OPTION> <OPTION>2</OPTION><OPTION>3</OPTION>
<OPTION>4</OPTION> <OPTION>5</OPTION> <OPTION>6</OPTION>
</td></tr>
<tr><td align="left" width="30%" valign="top">
Comments:</td>
<td align="left" width="68%">
<p align="left"><textarea cols="30" rows="5" name="comments"></textarea></p>
</td>
</tr>
<tr><td align="center" width="98%" valign="top" colspan="2">
<p><input type="submit" name="submit" value="Send Mail">  
<input type="reset" value="Reset">
</td>
</tr>
</table>
</form>

</BODY>
</HTML>
<? ob_flush(); ?>

rincewind456

Ugh that code is a mess!

The reason it doesn't work is that the names you have assigned to the input elements do not refer to the varaibles you are checking.

For example the list box for day in is named "Day_in" and is passed to your form validation section as $_GET["Day_in"], yet you are checking to see if $day_in is filled, obviously not the same.
All the options I looked at are the same.

Saz

Many thanks for the idea, I've now changed the code to match with the same words, with the 1st letter in caps, but now I'm getting even more errors 🙁

The html code I can clean up a little, but any advice on how to clean up the php code, is always appreciated.

Saz.

<? ob_start(); ?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">

function numberOfIntegers($String)
{

$x=0;
$numOfInts=0;

while ($x < strlen($String))
{

if (is_numeric($String{$x}))
{
$numOfInts++;
}
$x++;

}

return $numOfInts;

}

?>
<HTML>
<BODY BGCOLOR="#FFFFFF">

// Check to see if the form has been submitted
if ($_GET["submit"])
{

// Assign 0 to the error variable
$Error = 0;

// Let's extract the GET form field elements
extract($_GET);

$ValidEmail = substr_count($Email, '@');
$ValidEmail1 = substr_count($Email, '.');

// Now, we'll check to see if ANY of the form elements are blank
if (!($Name) || !($Email) || !($Phone) || !($Day_in) || !($Day_out)
|| ($ValidEmail < 1) || ($ValidEmail1 < 1) || ((numberOfIntegers($Phone)) < 6) || !($Number_of_people))
{
// at least one of the form fields are blank
if (!($Day_in))
{
$Error = 1;
$ErrorDay_in = 1;
}

if (!($Day_out))
{
$Error = 1;
$ErrorDay_out = 1;
}

if (!($Name))
{
$Error = 1;
$ErrorName = 1;
}

if (!($Phone))
{
$Error = 1;
$ErrorPhone = 1;
}

if (!($Email))
{
$Error = 1;
$ErrorEmail = 1;
}

if (!($Number_of_people))
{
$Error = 1;
$ErrorNumber_of_people = 1;
}

} else {

// all the form fields are filled in with data

// email the data to YOUR email address
$To = "emailaddress@example.com";
$Subject = "Form submission";
$Message = "Name: $name \nEmail: $email \nPhone: $phone \nDay_in: $day_in \nDay_out: $day_out \nComments: $comments";
mail($To, $Subject, $Message, "From: $email");

// email a copy of this message to the USER'S email address
$replyTo = $email;
$replySubject = "Form submission";
$replyMessage = "Your submission: \n\nName: $name \nEmail: $email \nPhone: $phone \nDay_in: $day_in \nDay_out: $day_out \nComments: $comments";
mail($replyTo, $replySubject, $replyComments, "From: $To");

// redirect to the thank you page
header("Location: http://www.example.com/301205/thanks.php");

}

}
?>

echo "<strong>Oops, you did not provide a valid telephone number. Please ensure that your phone ";
echo "number contains AT LEAST 6 NUMBERS and submit the form again.</strong> <br />";
$highlightPhone = 1;
}
?>

<form action="index.php" method="GET">
<table width="100%">
<tr>
<td align="left" width="30%">
<? if (($Error == 1) && ($ErrorDay_in == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Date in:
</td>
<td align="left" width="68%" valign="bottom">
<SELECT style="maintext" name="Day_in" onchange="Form1.Month_and_year_in.focus()">
<OPTION selected></OPTION> <OPTION>1</OPTION> <OPTION>2</OPTION> <OPTION>3</OPTION> <OPTION>4</OPTION> <OPTION>5</OPTION>
<OPTION>6</OPTION> <OPTION>7</OPTION> <OPTION>8</OPTION> <OPTION>9</OPTION>
<OPTION>10</OPTION> <OPTION>11</OPTION> <OPTION>12</OPTION> <OPTION>13</OPTION>
<OPTION>14</OPTION> <OPTION>15</OPTION> <OPTION>16</OPTION> <OPTION>17</OPTION>
<OPTION>18</OPTION> <OPTION>19</OPTION> <OPTION>20</OPTION> <OPTION>21</OPTION>
<OPTION>22</OPTION> <OPTION>23</OPTION> <OPTION>24</OPTION> <OPTION>25</OPTION>
<OPTION>26</OPTION> <OPTION>27</OPTION> <OPTION>28</OPTION> <OPTION>29</OPTION>
<OPTION>30</OPTION> <OPTION>31</OPTION></SELECT> 
<SELECT style="maintext" name="Month_and_year_in" onchange="Form1.Day_out.focus()">
<OPTION selected></OPTION> <OPTION>December 2005</OPTION>
<OPTION>January 2006</OPTION>
<OPTION>February 2006</OPTION> <OPTION>March 2006</OPTION>
<OPTION>April 2006</OPTION> <OPTION>May 2006</OPTION>
<OPTION>June 2006</OPTION> <OPTION>July 2006</OPTION>
<OPTION>August 2006</OPTION> <OPTION>September 2006</OPTION>
<OPTION>October 2006</OPTION> <OPTION>November 2006</OPTION>
</SELECT></td></tr>
<tr>
<td align="left">
<? if (($Error == 1) && ($ErrorDay_out == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Date out:
</td>
<td align="left" valign="bottom">
<SELECT style="maintext" name="Day_out" onchange="Form1.Month_and_year_out.focus()">
<OPTION selected></OPTION> <OPTION>1</OPTION>
<OPTION>2</OPTION> <OPTION>3</OPTION> <OPTION>4</OPTION> <OPTION>5</OPTION> <OPTION>6</OPTION>
<OPTION>7</OPTION> <OPTION>8</OPTION> <OPTION>9</OPTION> <OPTION>10</OPTION>
<OPTION>11</OPTION> <OPTION>12</OPTION> <OPTION>13</OPTION> <OPTION>14</OPTION>
<OPTION>15</OPTION> <OPTION>16</OPTION> <OPTION>17</OPTION> <OPTION>18</OPTION>
<OPTION>19</OPTION> <OPTION>20</OPTION> <OPTION>21</OPTION> <OPTION>22</OPTION>
<OPTION>23</OPTION> <OPTION>24</OPTION> <OPTION>25</OPTION> <OPTION>26</OPTION>
<OPTION>27</OPTION> <OPTION>28</OPTION> <OPTION>29</OPTION>
<OPTION>30</OPTION> <OPTION>31</OPTION></SELECT> 
<SELECT style="maintext" name="Month_and_year_out" onchange="Form1.Name.focus()">
<OPTION selected></OPTION> <OPTION>December 2005</OPTION>
<OPTION>January 2006</OPTION>
<OPTION>February 2006</OPTION> <OPTION>March 2006</OPTION>
<OPTION>April 2006</OPTION> <OPTION>May 2006</OPTION>
<OPTION>June 2006</OPTION> <OPTION>July 2006</OPTION>
<OPTION>August 2006</OPTION> <OPTION>September 2006</OPTION>
<OPTION>October 2006</OPTION> <OPTION>November 2006</OPTION>
</SELECT>
</td></tr>
<tr>
<td align="left">
<? if (($Error == 1) && ($ErrorName == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Name:
</td>
<td align="left" valign="bottom"><input type="text" name="name" size="26" value="<? echo $name; ?>">
</td></tr>
<tr><td align="left">
<? if (($Error == 1) && ($ErrorPhone == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Telephone number:
</td>
<td align="left"><input type="text" name="phone" size="26" value="<? echo $phone; ?>">
</td></tr>
<tr><td align="left">
<? if (($Error == 1) && ($ErrorEmail == 1) || ($highlightEmail == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Email address:
</td>
<td align="left"><input type="text" name="email" size="26" value="<? echo $email; ?>">
</td></tr>
<tr><td align="left">
<? if (($Error == 1) && ($ErrorNumber_of_people == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Number of people:
</td>
<td align="left" valign="bottom"><SELECT style="maintext" name="Number_of_people" onchange="Form1.send.focus()">
<OPTION selected> </OPTION>
<OPTION>1</OPTION> <OPTION>2</OPTION><OPTION>3</OPTION>
<OPTION>4</OPTION> <OPTION>5</OPTION> <OPTION>6</OPTION>
</td></tr>
<tr><td align="left" valign="top">
Comments:</td>
<td align="left">
<p align="left"><textarea cols="30" rows="5" name="comments"></textarea></p>
</td>
</tr>
<tr><td align="center" width="98%" valign="top" colspan="2">
<p><input type="submit" name="submit" value="Send Mail">  
<input type="reset" value="Reset">
</td>
</tr>
</table>
</form>

</BODY>
</HTML>
<? ob_flush(); ?>

rincewind456

No you didn't follow all that I said, your form, for example sends a variable called $GET['Days_in'] this is then processed from around line 36 onwards. But from line 36 there is no mention of $GET['Days_in'] they magically change to $Days_in, How does this happen.
Replace the line

// Let's extract the GET form field elements
extract($_GET);

with this

$Day_in  = $_GET['Day_in'];
$Month_and_year_in = $_GET['Month_and_year_in'];
$Day_out = $_GET['Day_out'];
$Month_and_year_out = $_GET['Month_and_year_out'];
$Name = $_GET['name'];
$Phone = $_GET['phone'];
$Email = $_GET['email'];
$Number_of_people = $_GET['Number_of_people'];
$comments = $_GET['comments'];

and you will find that the values from your form will noe be picked up by the error checking.

Saz

Many thanks for coming in again on this - the help is definitely appreciated. (Is it just the 2 of us in here?)

Ok, did exactly as you kindly suggested, but now, after the user inputs an answer into any of the fields and press's send, the values disappear ?

<? ob_start(); ?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">

function numberOfIntegers($String)
{

$x=0;
$numOfInts=0;

while ($x < strlen($String))
{

if (is_numeric($String{$x}))
{
$numOfInts++;
}
$x++;

}

return $numOfInts;

}

?>
<HTML>
<BODY BGCOLOR="#FFFFFF">

// Check to see if the form has been submitted
if ($_GET["submit"])
{

// Assign 0 to the error variable
$Error = 0;

$Day_in = $GET['Day_in'];
$Month_and_year_in = $GET['Month_and_year_in'];
$Day_out = $GET['Day_out'];
$Month_and_year_out = $GET['Month_and_year_out'];
$Name = $GET['name'];
$Phone = $GET['phone'];
$Email = $GET['email'];
$Number_of_people = $GET['Number_of_people'];
$comments = $_GET['comments'];

$ValidEmail = substr_count($Email, '@');
$ValidEmail1 = substr_count($Email, '.');

if (!($Day_out))
{
$Error = 1;
$ErrorDay_out = 1;
}

if (!($Name))
{
$Error = 1;
$ErrorName = 1;
}

if (!($Phone))
{
$Error = 1;
$ErrorPhone = 1;
}

if (!($Email))
{
$Error = 1;
$ErrorEmail = 1;
}

if (!($Number_of_people))
{
$Error = 1;
$ErrorNumber_of_people = 1;
}

} else {

// all the form fields are filled in with data

// redirect to the thank you page
header("Location: http://www.example.com/301205/thanks.php");

}

}
?>

<form action="index.php" method="GET">
<table width="100%">
<tr>
<td align="left" width="30%">
<? if (($Error == 1) && ($ErrorDay_in == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Date in:
</td>
<td align="left" width="68%" valign="bottom">
<SELECT style="maintext" name="Day_in" onchange="Form1.Month_and_year_in.focus()">
<OPTION selected></OPTION> <OPTION>1</OPTION> <OPTION>2</OPTION> <OPTION>3</OPTION> <OPTION>4</OPTION> <OPTION>5</OPTION>
<OPTION>6</OPTION> <OPTION>7</OPTION> <OPTION>8</OPTION> <OPTION>9</OPTION>
<OPTION>10</OPTION> <OPTION>11</OPTION> <OPTION>12</OPTION> <OPTION>13</OPTION>
<OPTION>14</OPTION> <OPTION>15</OPTION> <OPTION>16</OPTION> <OPTION>17</OPTION>
<OPTION>18</OPTION> <OPTION>19</OPTION> <OPTION>20</OPTION> <OPTION>21</OPTION>
<OPTION>22</OPTION> <OPTION>23</OPTION> <OPTION>24</OPTION> <OPTION>25</OPTION>
<OPTION>26</OPTION> <OPTION>27</OPTION> <OPTION>28</OPTION> <OPTION>29</OPTION>
<OPTION>30</OPTION> <OPTION>31</OPTION></SELECT> 
<SELECT style="maintext" name="Month_and_year_in" onchange="Form1.Day_out.focus()">
<OPTION selected></OPTION> <OPTION>December 2005</OPTION>
<OPTION>January 2006</OPTION>
<OPTION>February 2006</OPTION> <OPTION>March 2006</OPTION>
<OPTION>April 2006</OPTION> <OPTION>May 2006</OPTION>
<OPTION>June 2006</OPTION> <OPTION>July 2006</OPTION>
<OPTION>August 2006</OPTION> <OPTION>September 2006</OPTION>
<OPTION>October 2006</OPTION> <OPTION>November 2006</OPTION>
</SELECT></td></tr>
<tr>
<td align="left">
<? if (($Error == 1) && ($ErrorDay_out == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Date out:
</td>
<td align="left" valign="bottom">
<SELECT style="maintext" name="Day_out" onchange="Form1.Month_and_year_out.focus()">
<OPTION selected></OPTION> <OPTION>1</OPTION>
<OPTION>2</OPTION> <OPTION>3</OPTION> <OPTION>4</OPTION> <OPTION>5</OPTION> <OPTION>6</OPTION>
<OPTION>7</OPTION> <OPTION>8</OPTION> <OPTION>9</OPTION> <OPTION>10</OPTION>
<OPTION>11</OPTION> <OPTION>12</OPTION> <OPTION>13</OPTION> <OPTION>14</OPTION>
<OPTION>15</OPTION> <OPTION>16</OPTION> <OPTION>17</OPTION> <OPTION>18</OPTION>
<OPTION>19</OPTION> <OPTION>20</OPTION> <OPTION>21</OPTION> <OPTION>22</OPTION>
<OPTION>23</OPTION> <OPTION>24</OPTION> <OPTION>25</OPTION> <OPTION>26</OPTION>
<OPTION>27</OPTION> <OPTION>28</OPTION> <OPTION>29</OPTION>
<OPTION>30</OPTION> <OPTION>31</OPTION></SELECT> 
<SELECT style="maintext" name="Month_and_year_out" onchange="Form1.Name.focus()">
<OPTION selected></OPTION> <OPTION>December 2005</OPTION>
<OPTION>January 2006</OPTION>
<OPTION>February 2006</OPTION> <OPTION>March 2006</OPTION>
<OPTION>April 2006</OPTION> <OPTION>May 2006</OPTION>
<OPTION>June 2006</OPTION> <OPTION>July 2006</OPTION>
<OPTION>August 2006</OPTION> <OPTION>September 2006</OPTION>
<OPTION>October 2006</OPTION> <OPTION>November 2006</OPTION>
</SELECT>
</td></tr>
<tr>
<td align="left">
<? if (($Error == 1) && ($ErrorName == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Name:
</td>
<td align="left" valign="bottom"><input type="text" name="Name" size="26" value="<? echo $Name; ?>">
</td></tr>
<tr><td align="left">
<? if (($Error == 1) && ($ErrorPhone == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Telephone number:
</td>
<td align="left"><input type="text" name="Phone" size="26" value="<? echo $Phone; ?>">
</td></tr>
<tr><td align="left">
<? if (($Error == 1) && ($ErrorEmail == 1) || ($highlightEmail == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Email address:
</td>
<td align="left"><input type="text" name="Email" size="26" value="<? echo $Email; ?>">
</td></tr>
<tr><td align="left">
<? if (($Error == 1) && ($ErrorNumber_of_people == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Number of people:
</td>
<td align="left" valign="bottom"><SELECT style="maintext" name="Number_of_people" onchange="Form1.send.focus()">
<OPTION selected> </OPTION>
<OPTION>1</OPTION> <OPTION>2</OPTION><OPTION>3</OPTION>
<OPTION>4</OPTION> <OPTION>5</OPTION> <OPTION>6</OPTION>
</td></tr>
<tr><td align="left" valign="top">
Comments:</td>
<td align="left">
<p align="left"><textarea cols="30" rows="5" name="comments"></textarea></p>
</td>
</tr>
<tr><td align="center" width="98%" valign="top" colspan="2">
<p><input type="submit" name="submit" value="Send Mail">  
<input type="reset" value="Reset">
</td>
</tr>
</table>
</form>

</BODY>
</HTML>
<? ob_flush(); ?>

rincewind456

This is all to do with this code being designed for register_globals being on, and it is now more usually off for security reasons.

Also your variable names throughout the script do not match, keep to lower case always, that way your not going to get confused between $day and $Day which are two entirely diferent variables.

That said this may be what your looking for I've tidied the php code but you still need to tidy the html( it makes debugging so much easier if you can dechper whats there)

<?php ob_start(); ?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">

<?php

function numberOfIntegers($String)
{

$x=0;
$numOfInts=0;

while ($x < strlen($String))
{

	if (is_numeric($String{$x}))
	{
		$numOfInts++;
	}
	$x++;

}

return $numOfInts;

}

?>
<HTML>
<BODY BGCOLOR="#FFFFFF">

<?php

// Check to see if the form has been submitted
if ($_GET["submit"])
{

// Assign 0 to the error variable
$Error = 0;

$Day_in = $_GET['Day_in'];
$Month_and_year_in = $_GET['Month_and_year_in'];
$Day_out = $_GET['Day_out'];
$Month_and_year_out = $_GET['Month_and_year_out'];
$Name = $_GET['Name'];
$Phone = $_GET['Phone'];
$Email = $_GET['Email'];
$Number_of_people = $_GET['Number_of_people'];
$comments = $_GET['comments'];

$ValidEmail = substr_count($Email, '@');
$ValidEmail1 = substr_count($Email, '.');

// Now, we'll check to see if ANY of the form elements are blank
if (!($Name) || !($Email) || !($Phone) || !($Day_in) || !($Day_out)
|| ($ValidEmail < 1) || ($ValidEmail1 < 1) || ((numberOfIntegers($Phone)) < 6) || !($Number_of_people))
{
	// at least one of the form fields are blank
	if (!($Day_in))
	{
		$Error = 1;
		$ErrorDay_in = 1;
	}


	if (!($Day_out))
	{
		$Error = 1;
		$ErrorDay_out = 1;
	}


	if (!($Name))
	{
		$Error = 1;
		$ErrorName = 1;
	}

	if (!($Phone))
	{
		$Error = 1;
		$ErrorPhone = 1;
	}

	if (!($Email))
	{
		$Error = 1;
		$ErrorEmail = 1;
	}

	if (!($Number_of_people))
	{
		$Error = 1;
		$ErrorNumber_of_people = 1;
	}


} else {

	// all the form fields are filled in with data

	// email the data to YOUR email address
	$To = "emailaddress@example.com";
	$Subject = "Form submission";
	$Message = "Name: $Name \nEmail: $Email \nPhone: $Phone \nDay_in: $Day_in \nDay_out: $Day_out \nComments: $comments";
	mail($To, $Subject, $Message, "From: $email");

	// email a copy of this message to the USER'S email address
	$replyTo = $Email;
	$replySubject = "Form submission";
	$replyMessage = "Your submission: \n\nName: $Name \nEmail: $Email \nPhone: $Phone \nDay_in: $Day_in \nDay_out: $Day_out \nComments: $comments";
	mail($replyTo, $replySubject, $replyComments, "From: $To");

	// redirect to the thank you page
	header("Location: http://www.example.com/301205/thanks.php");

}

}
?>

<?php if ($Error > 0)
{
	// Instruct the user that an error is present
	echo "<strong>Oops, you did not fill out all required fields. Those fields are marked below.</strong> <br />";
} elseif ((($ValidEmail < 1) || ($ValidEmail1 < 1)) && ($_GET["submit"])) {
	echo "<strong>Oops, you did not provide a valid email address. Please try again.</strong> <br />";
	$highlightEmail = 1;
} elseif ((numberOfIntegers($Phone) < 6) && ($_GET["submit"])) {

echo "<strong>Oops, you did not provide a valid telephone number. Please ensure that your phone ";
echo "number contains AT LEAST 6 NUMBERS and submit the form again.</strong> <br />";
$highlightPhone = 1;
}
?>

<form action="index.php" method="GET">
<table width="100%">
<tr>
<td align="left" width="30%">
<?php if (($Error == 1) && ($ErrorDay_in == 1)) { echo "<font color=\"Red\">* </font>"; } ?>Date in:
</td>
<td align="left" width="68%" valign="bottom">
<SELECT style="maintext" name="Day_in" onchange="Form1.Month_and_year_in.focus()">
<OPTION selected></OPTION> <OPTION>1</OPTION> <OPTION>2</OPTION> <OPTION>3</OPTION> <OPTION>4</OPTION> <OPTION>5</OPTION>
<OPTION>6</OPTION> <OPTION>7</OPTION> <OPTION>8</OPTION> <OPTION>9</OPTION>
<OPTION>10</OPTION> <OPTION>11</OPTION> <OPTION>12</OPTION> <OPTION>13</OPTION>
<OPTION>14</OPTION> <OPTION>15</OPTION> <OPTION>16</OPTION> <OPTION>17</OPTION>
<OPTION>18</OPTION> <OPTION>19</OPTION> <OPTION>20</OPTION> <OPTION>21</OPTION>
<OPTION>22</OPTION> <OPTION>23</OPTION> <OPTION>24</OPTION> <OPTION>25</OPTION>
<OPTION>26</OPTION> <OPTION>27</OPTION> <OPTION>28</OPTION> <OPTION>29</OPTION>
<OPTION>30</OPTION> <OPTION>31</OPTION></SELECT>&nbsp;
<SELECT style="maintext" name="Month_and_year_in" onchange="Form1.Day_out.focus()">
<OPTION selected></OPTION> <OPTION>December 2005</OPTION>
<OPTION>January 2006</OPTION>
<OPTION>February 2006</OPTION> <OPTION>March 2006</OPTION>
<OPTION>April 2006</OPTION> <OPTION>May 2006</OPTION>
<OPTION>June 2006</OPTION> <OPTION>July 2006</OPTION>
<OPTION>August 2006</OPTION> <OPTION>September 2006</OPTION>
<OPTION>October 2006</OPTION> <OPTION>November 2006</OPTION>
</SELECT></td></tr>
<tr>
<td align="left">
<?php if (($Error == 1) && ($ErrorDay_out == 1)) { echo "<font color=\"Red\">* </font>"; } ?>Date out:
</td>
<td align="left" valign="bottom">
<SELECT style="maintext" name="Day_out" onchange="Form1.Month_and_year_out.focus()">
<OPTION selected></OPTION> <OPTION>1</OPTION>
<OPTION>2</OPTION> <OPTION>3</OPTION> <OPTION>4</OPTION> <OPTION>5</OPTION> <OPTION>6</OPTION>
<OPTION>7</OPTION> <OPTION>8</OPTION> <OPTION>9</OPTION> <OPTION>10</OPTION>
<OPTION>11</OPTION> <OPTION>12</OPTION> <OPTION>13</OPTION> <OPTION>14</OPTION>
<OPTION>15</OPTION> <OPTION>16</OPTION> <OPTION>17</OPTION> <OPTION>18</OPTION>
<OPTION>19</OPTION> <OPTION>20</OPTION> <OPTION>21</OPTION> <OPTION>22</OPTION>
<OPTION>23</OPTION> <OPTION>24</OPTION> <OPTION>25</OPTION> <OPTION>26</OPTION>
<OPTION>27</OPTION> <OPTION>28</OPTION> <OPTION>29</OPTION>
<OPTION>30</OPTION> <OPTION>31</OPTION></SELECT>&nbsp;
<SELECT style="maintext" name="Month_and_year_out" onchange="Form1.Name.focus()">
<OPTION selected></OPTION> <OPTION>December 2005</OPTION>
<OPTION>January 2006</OPTION>
<OPTION>February 2006</OPTION> <OPTION>March 2006</OPTION>
<OPTION>April 2006</OPTION> <OPTION>May 2006</OPTION>
<OPTION>June 2006</OPTION> <OPTION>July 2006</OPTION>
<OPTION>August 2006</OPTION> <OPTION>September 2006</OPTION>
<OPTION>October 2006</OPTION> <OPTION>November 2006</OPTION>
</SELECT>
</td></tr>
<tr>
<td align="left">
<?php if (($Error == 1) && ($ErrorName == 1)) { echo "<font color=\"Red\">* </font>"; } ?>Name:
</td>
<td align="left" valign="bottom"><input type="text" name="Name" size="26" value="<?php echo @$_GET['Name']; ?>">
</td></tr>
<tr><td align="left">
<?php if (($Error == 1) && ($ErrorPhone == 1)) { echo "<font color=\"Red\">* </font>"; } ?>Telephone number:
</td>
<td align="left"><input type="text" name="Phone" size="26" value="<?php echo @$_GET['Phone']; ?>">
</td></tr>
<tr><td align="left">
<?php if (($Error == 1) && ($ErrorEmail == 1) || ($highlightEmail == 1)) { echo "<font color=\"Red\">* </font>"; } ?>Email address:
</td>
<td align="left"><input type="text" name="Email" size="26" value="<?php echo @$_GET['Email']; ?>">
</td></tr>
<tr><td align="left">
<?php if (($Error == 1) && ($ErrorNumber_of_people == 1)) { echo "<font color=\"Red\">* </font>"; } ?>Number of people:
</td>
<td align="left" valign="bottom"><SELECT style="maintext" name="Number_of_people" onchange="Form1.send.focus()">
<OPTION selected> </OPTION>
<OPTION>1</OPTION> <OPTION>2</OPTION><OPTION>3</OPTION>
<OPTION>4</OPTION> <OPTION>5</OPTION> <OPTION>6</OPTION>
</td></tr>
<tr><td align="left" valign="top">
Comments:</td>
<td align="left">
<p align="left"><textarea cols="30" rows="5" name="comments"></textarea></p>
</td>
</tr>
<tr><td align="center" width="98%" valign="top" colspan="2">
<p><input type="submit" name="submit" value="Send Mail">&nbsp;&nbsp;
<input type="reset" value="Reset">
</td>
</tr>
</table>
</form>

</BODY>
</HTML>
<?php ob_flush(); ?>

Saz

Thanks again for the help.

I did read thru the link you posted on register globals - I'm on Apache - should I adjust something somewhere?

I fully take your point about the code, so I've just got rid of the crud bits and if you see any other bits that can go in the bin, please let me know.

To make things easier, I've also got rid of a few of the other fields, that are not needed for me to learn from this.

OK, I've done exactly as you mentioned, and without the superflous bits, the code is below, but if you enter 4 digits for example, into the phone field, then input the number of people in to the other field, press submit, it then says there's not enough digits in the phone field, but it also doesn't save the value from the number field?? ;-(

<?php ob_start(); ?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">

<?php

function numberOfIntegers($String)
{

$x=0; 
$numOfInts=0; 

while ($x < strlen($String)) 
{ 

    if (is_numeric($String{$x})) 
    { 
        $numOfInts++; 
    } 
    $x++; 

} 

return $numOfInts;

}

?>
<HTML>
<BODY BGCOLOR="#FFFFFF">

<?php

// Check to see if the form has been submitted
if ($_GET["submit"])
{

// Assign 0 to the error variable 
$Error = 0; 

$Name = $_GET['Name']; 
$Phone = $_GET['Phone']; 
$Email = $_GET['Email']; 
$Number_of_people = $_GET['Number_of_people']; 

$ValidEmail = substr_count($Email, '@'); 
$ValidEmail1 = substr_count($Email, '.'); 

// Now, we'll check to see if ANY of the form elements are blank 
if (!($Name) || !($Email) || !($Phone)  
|| ($ValidEmail < 1) || ($ValidEmail1 < 1) || ((numberOfIntegers($Phone)) < 6) || !($Number_of_people)) 
{ 
    // at least one of the form fields are blank 

    if (!($Name)) 
    { 
        $Error = 1; 
        $ErrorName = 1; 
    } 

    if (!($Phone)) 
    { 
        $Error = 1; 
        $ErrorPhone = 1; 
    } 

    if (!($Email)) 
    { 
        $Error = 1; 
        $ErrorEmail = 1; 
    } 

    if (!($Number_of_people)) 
    { 
        $Error = 1; 
        $ErrorNumber_of_people = 1; 
    } 


} else { 

    // all the form fields are filled in with data 

    // email the data to YOUR email address 
    $To = "emailaddress@example.com"; 
    $Subject = "Form submission"; 
    $Message = "Name: $Name \nEmail: $Email \nPhone: $Phone"; 
    mail($To, $Subject, $Message, "From: $email"); 

    // email a copy of this message to the USER'S email address 
    $replyTo = $Email; 
    $replySubject = "Form submission"; 
    $replyMessage = "Your submission: \n\nName: $Name \nEmail: $Email \nPhone: $Phone \nNumber_of_people: $Number_of_people"; 
    mail($replyTo, $replySubject, $replyComments, "From: $To"); 

    // redirect to the thank you page 
    header("Location: http://www.example.com/301205/thanks.php"); 

}

}
?>

<?php if ($Error > 0)
{
// Instruct the user that an error is present
echo "<strong>Oops, you did not fill out all required fields. Those fields are marked below.</strong> <br />";
} elseif ((($ValidEmail < 1) || ($ValidEmail1 < 1)) && ($GET["submit"])) {
echo "<strong>Oops, you did not provide a valid email address. Please try again.</strong> <br />";
$highlightEmail = 1;
} elseif ((numberOfIntegers($Phone) < 6) && ($GET["submit"])) {

echo "<strong>Oops, you did not provide a valid telephone number. Please ensure that your phone "; 
echo "number contains AT LEAST 6 NUMBERS and submit the form again.</strong> <br />"; 
$highlightPhone = 1;

}
?>

<form action="index.php" method="GET">
<table>
<tr>
<td>
<?php if (($Error == 1) && ($ErrorName == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Name:
</td>
<td>
<input type="text" name="Name" size="26" value="<?php echo @$GET['Name']; ?>">
</td>
</tr>
<tr>
<td>
<?php if (($Error == 1) && ($ErrorPhone == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Telephone number:
</td>
<td>
<input type="text" name="Phone" size="26" value="<?php echo @$GET['Phone']; ?>">
</td>
</tr>
<tr>
<td>
<?php if (($Error == 1) && ($ErrorEmail == 1) || ($highlightEmail == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Email address:
</td>
<td>
<input type="text" name="Email" size="26" value="<?php echo @$_GET['Email']; ?>">
</td>
</tr>
<tr>
<td>
<?php if (($Error == 1) && ($ErrorNumber_of_people == 1)) { echo "<font color=\"Red\"> </font>"; } ?>Number of people:
</td>
<td>
<SELECT name="Number_of_people">
<OPTION selected> </OPTION>
<OPTION>1</OPTION> <OPTION>2</OPTION><OPTION>3</OPTION>
</td>
</tr>
<tr>
<td align="center" colspan="2">
<input type="submit" name="submit" value="Send Mail">  
<input type="reset" value="Reset">
</td>
</tr>
</table>
</form>

</BODY>
</HTML>
<?php ob_flush(); ?>

rincewind456

Take a look at this I've put comments where I've changed somethig

<?php ob_start();
error_reporting(E_ALL);	#### comment this line out only after all errors have been sorted out.
?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">

<?php

function numberOfIntegers($String)
{

$x=0;
$numOfInts=0;

while ($x < strlen($String))
{

if (is_numeric($String{$x}))
{
$numOfInts++;
}
$x++;

}

return $numOfInts;

}

?>
<HTML>
<BODY BGCOLOR="#FFFFFF">

<?php

// Check to see if the form has been submitted
if (isset($_GET["submit"]))	############# need to test to see if $_GET["submit" is set
{

// Assign 0 to the error variable
$Error = 0;

$Name = $_GET['Name'];
$Phone = $_GET['Phone'];
$Email = $_GET['Email'];
$Number_of_people = $_GET['Number_of_people'];

$ValidEmail = substr_count($Email, '@');
$ValidEmail1 = substr_count($Email, '.');

// Now, we'll check to see if ANY of the form elements are blank
if (!($Name) || !($Email) || !($Phone)
|| ($ValidEmail < 1) || ($ValidEmail1 < 1) || ((numberOfIntegers($Phone)) < 6) || !($Number_of_people))
{
// at least one of the form fields are blank

if (!($Name))
{
$Error = 1;
$ErrorName = 1;
}

if (!($Phone))
{
$Error = 1;
$ErrorPhone = 1;
}

if (!($Email))
{
$Error = 1;
$ErrorEmail = 1;
}

if (!($Number_of_people))
{
$Error = 1;
$ErrorNumber_of_people = 1;
}


} else {

// all the form fields are filled in with data

// email the data to YOUR email address
$To = "emailaddress@example.com";
$Subject = "Form submission";
$Message = "Name: $Name \nEmail: $Email \nPhone: $Phone";
mail($To, $Subject, $Message, "From: $Email"); #####$email changed to $Email

// email a copy of this message to the USER'S email address
$replyTo = $Email;
$replySubject = "Form submission";
$replyMessage = "Your submission: \n\nName: $Name \nEmail: $Email \nPhone: $Phone \nNumber_of_people: $Number_of_people";
mail($replyTo, $replySubject, $replyComments, "From: $To"); ### where is $replyComments coming from

// redirect to the thank you page
header("Location: http://www.example.com/301205/thanks.php");

}

}
 if (@$Error > 0)
{
// Instruct the user that an error is present
echo "<strong>Oops, you did not fill out all required fields. Those fields are marked below.</strong> <br />";
} elseif (((@$ValidEmail < 1) || (@$ValidEmail1 < 1)) && (@$_GET["submit"])) {
echo "<strong>Oops, you did not provide a valid email address. Please try again.</strong> <br />";
$highlightEmail = 1;
} elseif ((numberOfIntegers(@$Phone) < 6) && (@$_GET["submit"])) {

echo "<strong>Oops, you did not provide a valid telephone number. Please ensure that your phone ";
echo "number contains AT LEAST 6 NUMBERS and submit the form again.</strong> <br />";
$highlightPhone = 1;
}
?>

<form action="index.php" method="GET">
<table>
<tr>
<td>
<?php if ((@$Error == 1) && (@$ErrorName == 1)) { echo "<font color=\"Red\">* </font>"; } ?>Name:
</td>
<td>
<input type="text" name="Name" size="26" value="<?php echo @$_GET['Name']; ?>">
</td>
</tr>
<tr>
<td>
<?php if ((@$Error == 1) && (@$ErrorPhone == 1)) { echo "<font color=\"Red\">* </font>"; } ?>Telephone number:
</td>
<td>
<input type="text" name="Phone" size="26" value="<?php echo @$_GET['Phone']; ?>">
</td>
</tr>
<tr>
<td>
<?php if ((@$Error == 1) && ($ErrorEmail == 1) || (@$highlightEmail == 1)) { echo "<font color=\"Red\">* </font>"; } ?>Email address:
</td>
<td>
<input type="text" name="Email" size="26" value="<?php echo @$_GET['Email']; ?>">
</td>
</tr>
<tr>
<td>
<?php if ((@$Error == 1) && (@$ErrorNumber_of_people == 1)) { echo "<font color=\"Red\">* </font>"; } ?>Number of people:
</td>
<td>
<SELECT name="Number_of_people">
<OPTION selected><?php echo @$_GET['Number_of_people']; ?></OPTION> <!--Shows sellected value -->
<OPTION>1</OPTION>
<OPTION>2</OPTION>
<OPTION>3</OPTION>
</td>
</tr>
<tr>
<td align="center" colspan="2">
<input type="submit" name="submit" value="Send Mail">&nbsp;&nbsp;
<input type="reset" value="Reset">
</td>
</tr>
</table>
</form>

</BODY>
</HTML>
<?php ob_flush(); ?>

Saz

I inputted that code and still got errors, sorry, and thanks for your help, but my knowledge of php isn't keeping up with this, I'm gonna have to bow out ;-(

Sayian

Saz wrote:
I inputted that code and still got errors, sorry, and thanks for your help, but my knowledge of php isn't keeping up with this, I'm gonna have to bow out ;-(

Or you can bow back in, and pick up the Manual 🙂

Saz

I did pick up the manual a little while ago and am still learning 🙂 But, this was proving to be a form too far 🙂

(Good to know there's others here as well 🙂 )