PHP Nested Loop Help

goldmoon

Trying to implement a nested loop in my code.

The code I have so far displays:

PracticeName...................................PracticeName2
Address...........................................Address
City, State Zip.................................City, State Zip
Phone#...........................................Phone #
Office Link........................................Office Link

The way I want it to look is, it displays all the names that pertain to that particular id;

PracticeName...................................PracticeName2
Address...........................................Address
City, State Zip.................................City, State Zip
Phone#...........................................Phone #
Name1............................................Name1
Name2
Name3
Office Link........................................Office Link

Here is the code that I have - a multicolumn display:

<?php

//set number of columns
$columns=2;
mysql_connect("localhost","root","");
mysql_select_db("db");
$query="SELECT distinct l.id, n.id, l.practicename, l.address1, l.city, l.abbrev, l.zip, l.phone, n.names FROM location l, names n WHERE l.id = n.id AND abbrev = 'MI' AND LineOfBusiness = 'General Practice' ORDER BY practicename";
$result=mysql_query($query);
$lineofbusiness='General Practice - Michigan';
$num_rows=mysql_num_rows($result);
echo "<table border=\"0\" align=\"center\" class=\"content10pt\" width=\"500\"><tr class=content10pt><td class=header2 align=center><br>$lineofbusiness</td></tr></table><table border=\"0\" align=\"center\" class=\"content10pt\" width=\"500\"><tbody><br>\n";

for($i=0;$i<$num_rows;$i++) {
$row=mysql_fetch_array($result);
if($i%$columns==0) {
echo "<tr class=\"content10pt\">\n";
}

echo "<td>" . $row['practicecname'] ."<br>" . $row['address1'] . "<br>" . $row['city'] . ", " . $row['abbrev'] . " " . $row['zip'] . "<br>" . "Phone: ". $row['phone'] . "<br><a href=http://./office_details2.php?id=".$row['id'].">Office Details</A><br><br><br>\n";

if(($i%$columns)==($columns-1) || ($i+1)==$num_rows)	{
	echo "</tr>\n";
}

}
echo "</tbody></table>\n";

Not sure where to put the nested loop to display those Names. Please help. Thanks.

bbreslauer

You'd need to break up the echo where you display the practice name, address, etc into two echo's, and then put another loop between those two echos.

Also, I would highly encourage using a non-root user to access the database. Using root could cause bad things to happen to your database, as it has complete access to the entire database system. If someone were able to attack your site with cross-site scripting, then they would be able to create a user for themselves on your server, and then play around with your stuff.

goldmoon

Thanks. I'll try that out.

goldmoon

I'm sorry, but I'm still new to PHP. The loop should display results from the query: select name from names where id=$row['id'] - where each practicename could display multiple names.

Could you provide me with code that would work here.

Thanks.

bbreslauer

echo "<td>" . $row['practicecname'] ."<br>" . $row['address1'] . "<br>" . $row['city'] . ", " . $row['abbrev'] . " " . $row['zip'] . "<br>" . "Phone: ". $row['phone'] . "<br>";

// do sql query here
while ($names_query = mysql_fetch_assoc($sql)) {
//echo name
}

echo "<a href=http://./office_details2.php?id=".$row['id'].">Office Details</A><br><br><br>\n";

goldmoon

I appreciate the help. I'll input that into my current code.

goldmoon

i implemented your code below and i get an error:

Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL

Please advise. Thanks.

bbreslauer wrote:
echo "<td>" . $row['practicecname'] ."<br>" . $row['address1'] . "<br>" . $row['city'] . ", " . $row['abbrev'] . " " . $row['zip'] . "<br>" . "Phone: ". $row['phone'] . "<br>";

// do sql query here
while ($names_query = mysql_fetch_assoc($sql)) {
//echo name
}

echo "<a href=http://./office_details2.php?id=".$row['id'].">Office Details</A><br><br><br>\n";

goldmoon

this the code, including the code you suggested. Please help. Thanks.

<?php

$names_query="select names from contacts where id=".$row['id'];

$result=mysql_query($query);
$lineofbusiness='General Practice - Michigan';
$num_rows=mysql_num_rows($result);
echo "<table border=\"0\" align=\"center\" class=\"content10pt\" width=\"500\"><tr class=content10pt><td class=header2 align=center><br>$lineofbusiness</td></tr></table><table border=\"0\" align=\"center\" class=\"content10pt\" width=\"500\"><tbody><br>\n";

for($i=0;$i<$num_rows;$i++) {
$row=mysql_fetch_array($result);
if($i%$columns==0) {
echo "<tr class=\"content10pt\">\n";
}

echo "<td>" . $row['practicecname'] ."<br>" . $row['address1'] . "<br>" . $row['city'] . ", " . $row['abbrev'] . " " . $row['zip'] . "<br>" . "Phone: ". $row['phone'] . "<br>\n";

while($names_query=mysql_fetch_assoc($query)) {
echo $names;
}

echo "<a href=http://./office_details2.php?id=".$row['id'].">Office Details</A><br><br><br>\n";

if(($i%$columns)==($columns-1) || ($i+1)==$num_rows) {
echo "</tr>\n";
}
}
echo "</tbody></table>\n";

goldmoon

Can someone help me with my code, not too sure why it's not working and i'm getting an mysql_fetch_assoc error. Code is listed in previous reply(above). Thanks.

bbreslauer

Oh, sorry, you need to do a mysql_query() on the sql statement before passing that into the mysql_fetch_assoc(). So, $sql=.........., then $query = mysql_query($sql) and then $names_query=mysql_fetch_assoc($query). In the while loop, however, $names_query is an associative array, so you'll need to output the names using an array - $names_query['firstname'] and the such.