[RESOLVED] Empty Value Question

[obrienkev]

Hi all,

The variable $new_course is not set a value but my below error checking doesn't seem to when the value is empty. It continues on with the rest of the code. Why is this?

if(!isset($new_course) || ($new_course != ""))
{
   echo '<p>Please enter a new course</p>';     

   echo '<p><a href="javascript:history.back(1)">Return</a></p>';
   exit;
}

[leatherback]

HOW would the $new_course variable get set? Is it through a form?
THen it SHOULD chack against $POST['new_course'] or $GET['new_course']. Otherwise you
- Have already extracted the submitted data
- Have your security settings at a risky level. Make sure "register_globals" in php.ini is set to off.

As for your little problem, if you want to keeop your format, check the brackets. I think it takes the first ! as part of the whole series of statements. Safer perhaps:

if(isset($new_course))
  {
  if($new_course != "")
   {
   echo '<p>Please enter a new course</p>';      

   echo '<p><a href="javascript:history.back(1)">Return</a></p>'; 
   exit; 
  }
}

[bpat1434]

Umm... read your logic outloud:

IF the $new_course variable is set:
[indent]IF the $new_course variable IS NOT EQUIVILANT TO an empty string:
[indent]echo an error, and exit[/indent]
[/indent]

Anyone else notice a problem?

Shouldn't it be:

<?php
if(isset($new_course))
{
  if($new_course == '')
  {
    echo '<p>Please enter a new course</p>
             <p><a href="javascript:history.back(1)">Return</a></p>';
    exit;
  }
}

Or, as in the original code:

if(!isset($new_code) || $new_code=='')
{
  echo '<p>Please enter a new course</p>
           <p><a href="javascript:history.back(1)">Return</a></p>';
  exit;
}

~Brett

[obrienkev]

Cheers Brett,

Works fine. Thanks for the help guys.

[leatherback]

bpat1434 wrote:

Umm... read your logic outloud:

IF the $new_course variable is set:
[indent]IF the $new_course variable IS NOT EQUIVILANT TO an empty string:
[indent]echo an error, and exit[/indent]
[/indent]

hehe.. Guess I was a bit tired last night!

Sorry!