[RESOLVED] Funtion & header error help

StevenJ

Hi,

I have wrote a fucntion, very simple - and all it does is return the unique 'id'.

function getGalleryID($gallery) {
	require_once('connections/gall_db_con.php');
	mysql_select_db($database_gall_db_con, $gall_db_con);
	$query_show_gallery_th = sprintf("SELECT id from es_gallery WHERE gallery='%s' ", $gallery);
	$show_gallery_th = mysql_query($query_show_gallery_th, $gall_db_con) or die(mysql_error());
	$row_show_gallery_th = mysql_fetch_assoc($show_gallery_th);
	$totalRows_show_gallery_th = mysql_num_rows($show_gallery_th);
	$id = $row_show_gallery_th['id'] ;
	return $id ;
}

now I can call this funtion, and it functions correctly, but when I move the function to an external file (so all my functions are in a manageble space and I can call them from any php page) I get errors.

example of which are

Warning: Cannot modify header information - headers already sent by (output started at E:\es_gallery\includes\functions.php:47) in E:\es_gallery\uploadimage.php on line 97

Warning: Cannot modify header information - headers already sent by (output started at E:\es_gallery\includes\functions.php:47) in E:\es_gallery\uploadimage.php on line 192

now, the function above starts on line 47 of functions.php

the uploadimage.php is attatched - but renamed as a txt file

it appears that there is output from the function which then makes the header () function fail - but I don't know where I have gone wrong at all.........

help! please.

tia

StevenJ

devinemke

there can be no output sent to the client prior to calling the [man]header[/man] function. you call control using the Output Control Functions.

StevenJ

yeah, thanks - I know that, and as far as I can tell I dont........... 😕

m_tt

could be something in gall_db_con.php

I think this is a problem we cannot help you with without seeing more.

thorpe

Are you sure there is no white space? There is output somewhere.

mikesch

Hey Steven,

I'm new to PHP, but I think I know what your problem is. The header has to be sent out before any HTML. Otherwise you'll get those error messages.

Here's an example:

<?php
//check for required info urltitle
if (!$_GET[urltitle]) {
header("Location: output.php");
exit;
}
?>

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>Untitled Document</title>
</head>

In other words, the order is extremely important when you use the header function.

Hope this helps.

Mike

StevenJ

Hi,

many thanks for all the replies.

The page used to work when I had the function as part of the main page, but when I placed it in an external file - that's when the error occured.

What I have tried to do to investigate further is start a session, as we know - this must be done first before any output. So putting

session_start()

before the include which causes the problem.

this produces the following error

Warning: session_start(): Cannot send session cache limiter - headers already sent (output started at E:\es_gallery\includes\functions.php:47) in E:\es_gallery\uploadimage.php on line 4

so, the error mus be in that file \functions.php but I can't see any output from the following code?

the first line is line 47, where the error is......
<?php
function getGalleryID($gallery){
global $database_gall_db_con ;
global $gall_db_con ;
mysql_select_db($database_gall_db_con, $gall_db_con);
$query_show_gallery_th = sprintf("SELECT id from es_gallery WHERE gallery='%s' ", $gallery);
$show_gallery_th = mysql_query($query_show_gallery_th, $gall_db_con) or die(mysql_error());
$row_show_gallery_th = mysql_fetch_assoc($show_gallery_th);
$totalRows_show_gallery_th = mysql_num_rows($show_gallery_th);
$id = $row_show_gallery_th['id'] ;
return $id ;
}
?>

I have attatched the functions.php as a txt file...........

StevenJ

found it!

god, that was a waste of 2 hrs.

I have the following line in the functions file

<?php

so the blank line between the function definitions was messing it up!

thanks for all the help people!