[RESOLVED] Ugh, I Confused Myself

sys4dm1n

Well can anyone help me with my problem, I am verifing a username and password from my database but i didnt have any error checking for wrong username/password. I added a simple else statement and changed the action to <?=$self?> and now it just displays an invalid username and password upon accessing the page.

here is my code:

<div class="error"><?
include("inc/config.php");
$connection = mysql_connect($hostname, $user, $pass) or die ("Unable to connect!");
$query = "SELECT * FROM clients WHERE name = '$name' AND password = PASSWORD('$password')";
$result = mysql_db_query($database, $query, $connection);
if (mysql_num_rows($result) == 1)
	{
	session_start();

session_register("client_id");
session_register("client_name");
session_register("client_email");
session_register("client_ref");
session_register("client_title");
list($clientid, $name, $pass, $email, $ref, $title) = mysql_fetch_row($result);
$client_id = $clientid;
$client_name = $name;
$client_email = $email;
$client_ref = $ref;
$client_title = $title;

header("Location: menu.php");
mysql_free_result ($result);	

mysql_close($connection);
}
else
	{
	mysql_free_result ($result);	
	mysql_close($connection);

echo "Invalid username or password\n";
}
?></div>
<form action="<?=$self?>" method="post" name="login">
<b>Username:</b>&nbsp;&nbsp;<input type="text" class="input_txt" name="name" />
<br /><br />
<b>Password:</b>&nbsp;&nbsp;<input type="password" class="input_txt" name="password" />
<br />
<br />
<div class="sub_pos">
<input type="submit" name="submit" value="Login" class="input_sub" />
</div>
</form>

Any suggestions?

bpat1434

where do you define $self? I don't see it.

More than likely it should be:

<?=$_SERVER['PHP_SELF']; ?>

~Brett

samudasu

sys4dm1n

I fixed the invalid password problem I was having, but now...

when i hit the submit button:

Warning: session_start(): Cannot send session cookie - headers already sent by (output started at /home/public_html/login/index.php:3) in /home/public_html/login/index.php on line 22

Warning: session_start(): Cannot send session cache limiter - headers already sent (output started at /home/public_html/login/index.php:3) in /home/public_html/login/index.php on line 22

Warning: Cannot modify header information - headers already sent by (output started at /home/public_html/login/index.php:3) in /home/public_html/login/index.php on line 36

Here is my current code:

<html>
<head>
<? include("inc/config.php"); ?>
<title><? echo $title_h ?></title>
<link rel="stylesheet" href="inc/login.css" type="text/css">
<script language="">
<!--
function cursor(){document.login.name.focus();}
// -->
</script>
</head>
<body>
<center>
<div id="login_box">
<div class="error">
<?
if (isset($_POST['submit'])) { 
include("inc/config.php");
$connection = mysql_connect($hostname, $user, $pass) or die ("Unable to connect!");
$query = "SELECT * FROM clients WHERE name = '$name' AND password = PASSWORD('$password')";
$result = mysql_db_query($database, $query, $connection);
if (mysql_num_rows($result) == 1)
	{
	session_start();

session_register("client_id");
session_register("client_name");
session_register("client_email");
session_register("client_ref");
session_register("client_title");
list($clientid, $name, $pass, $email, $ref, $title) = mysql_fetch_row($result);
$client_id = $clientid;
$client_name = $name;
$client_email = $email;
$client_ref = $ref;
$client_title = $title;

header("Location: menu.php");
mysql_free_result ($result);	

mysql_close($connection);
}
else

{
mysql_free_result ($result);	
mysql_close($connection);

echo "Invalid username or password\n";
}
}
?></div>
<form action="<?=$_SERVER['PHP_SELF']; ?> " method="post" name="login">
<b>Username:</b>&nbsp;&nbsp;<input type="text" class="input_txt" name="name" />
<br /><br />
<b>Password:</b>&nbsp;&nbsp;<input type="password" class="input_txt" name="password" />
<br />
<br />
<div class="sub_pos">
<input type="submit" name="submit" value="Login" class="input_sub" />
</div>
</form>
</center>
</body>
</html>

I really confused myself here.

rincewind456

You can't send any output before sending headers even a spaceso

 <html> 
<head>

is definately out.

sys4dm1n

wow, its amazing what another set of eyes can do for you. i really appreciate it, i just must not have been thinking straight at all.

I ended up using ob_start(); and ob_end_flush(); to resolve the problem.

Thanks again.