Error, but actually No Error

[Dada78]

This is part of my other thread but I already made it resolved as I found what I was looking for and it worked, but now it's doing something weird. In my form I have it set up like.

<input type="text" value="<? echo $_POST[last_name];?>" name="last_name"  size="40">

That way if someone forgets or thier is a error in the form it won't make the user fill the whole form out. Well the problem is if everything is filled in correctly now and you hit submit it shows my error statement of

You did not submit the following required information!

then it should echo what wasnt filled in, problem is it doesn't show that any feilds are missing. I remove the echo from the form and everything is good. So is the input feild for the from layed out correctly?

-Thanks

[bpat1434]

Not entirely. When referencing string keys in an array, you need to encapsulate them in quotes:

<?php
// Notice the slight difference?
?>
<input type="text" value="<?php echo $_POST['last_name']; ?>" name="last_name" size="40">

Also, what does the rest of your code look like? The validation part I mean.

~Brett

[Dada78]

I think I can rule out the form being the problem. Here is the link to the form.

http://www.texascaching.com/index.php?page=register

try to fill it out and register, for some reason it won't let you. It was working ealier.

<?

include 'dbinfo.inc.php';

// Define post fields into simple variables
$first_name = $_POST['first_name'];
$last_name = $_POST['last_name'];
$email = $_POST['email'];
$username = $_POST['username'];
$city = $_POST['city'];
$zipcode = $_POST['zipcode'];
$cords = $_POST['cordv'];
$cords = $_POST['lat1'];
$cords = $_POST['lat2'];
$cords = $_POST['cordh'];
$cords = $_POST['long1'];
$cords = $_POST['long2'];

/* Let's strip some slashes in case the user entered
any escaped characters. */

$first_name = stripslashes($first_name);
$last_name = stripslashes($last_name);
$email = stripslashes($email);
$username = stripslashes($username);
$city = stripslashes($city);
$zipcode = stripslashes($zipcode);


?>
<!--ERROR TABLE-->
<table class='fullbox' width='500' height='105' align='center'>
    <tr>
      <td>

<?
/* Do some error checking on the form posted fields */

if((!$first_name) || (!$last_name) || (!$email_address) ||  (!$username) || (!$city) || (!$zipcode)){
    echo '<h1>You did not submit the following required information!</h1><br />';
    if(!$first_name){
        echo "<font class='errortext'>*First Name* is a required field. Please enter it below.<br />";
    }
    if(!$last_name){
        echo "<font class='errortext'>*Last Name* is a required field. Please enter it below.<br />";
    }
    if(!$email){
        echo "<font class='errortext'>*Email Address* is a required field. Please enter it below.<br />";
    }
    if(!$username){
        echo "<font class='errortext'>*Desired Username* is a required field. Please enter it below.<br />";
    }
    if(!$city){
        echo "<font class='errortext'>*City* is a required field. Please enter it below.<br />";
    }
    if(!$zipcode){
        echo "<font class='errortext'>*Zipcode* is a required field. Please enter it below.<br />";
    }
     if (!isset($_POST['terms']))
    {
    echo "<font class='errortext'>*You must accept the Terms & Conditions*.<br />";

} 
?>
</td>      

         </tr>
       </table>
<table border='0' cellpadding='0' cellspacing='0' width='500' align='center'><tr><td><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td><td class=shadow-mid width='100%'><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td><td><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td></tr></table></center>
<br />

<?
    include 'register_form.php'; // Show the form again!
    /* End the error checking and if everything is ok, we'll move on to
     creating the user account */
    exit(); // if the error checking has failed, we'll exit the script!
}

/* Let's do some checking and ensure that the user's email address or username
does not exist in the database */

$sql_email_check = mysql_query("SELECT email FROM users
            WHERE email='$email'");
$sql_username_check = mysql_query("SELECT username FROM users
            WHERE username='$username'");

$email_check = mysql_num_rows($sql_email_check);
$username_check = mysql_num_rows($sql_username_check);

if(($email_check > 0) || ($username_check > 0)){
    echo "<h1>Please fix the following errors:</h1> <br />";
    if($email_check > 0){
        echo "<font class='errortext'>This email address has already registered. Please submit a different Email address!<br />";
        unset($email_address);
    }
    if($username_check > 0){
        echo "<font class='errortext'>The username you have selected has already been taken by another memeber. Please choose a different Username!<br />";
        unset($username);
    }
    include 'register_form.php'; // Show the form again!
    exit();  // exit the script so that we do not create this account!
}

/* Everything has passed both error checks that we have done.
It's time to create the account! */

/* Random Password generator.
http://www.phpfreaks.com/quickcode/Random_Password_Generator/56.php

We'll generate a random password for the
user and encrypt it, email it and then enter it into the db.
*/

function makeRandomPassword() {
  $salt = "abchefghjkmnpqrstuvwxyz0123456789";
  srand((double)microtime()*1000000);
      $i = 0;
      while ($i <= 7) {
            $num = rand() % 33;
            $tmp = substr($salt, $num, 1);
            $pass = $pass . $tmp;
            $i++;
      }
      return $pass;
}

$random_password = makeRandomPassword();

$db_password = md5($random_password);

// Enter info into the Database.

$sql = mysql_query("INSERT INTO users (first_name, last_name,
        email, username, password, city, zipcode, cordv, lat1, lat2, cordh, long1, long2, signup_date)
        VALUES('$first_name', '$last_name', '$email',
        '$username', '$db_password','$city','$zipcode','$cordv',
'lat1','$lat2','$cordh','$long1','$long2', now())")
        or die (mysql_error());

if(!$sql){
    echo "<font class='errortext'>There has been an error creating your account. Please contact the webmaster.";
} else {
    $userid = mysql_insert_id();
    // Let's mail the user!
    $subject = "Texas Geocaching Organization Account Activation";
    $message = "Dear $first_name $last_name,
    Thank you for registering at our Texascaching.com!

You are two steps away from logging in and accessing our exclusive members area.

To activate your membership,
please click here: http://www.texascaching.com/activate.php?id=$userid&code=$db_password

Once you activate your memebership, you will be able to login
with the following information:
Username: $username
Password: $random_password

Once you have succesfully activated your account and logged in. You can go to your account to update your profile settings.

Thanks!
Texas Geocaching Organization Staff

This is an automated response, please do not reply!";

mail($email_address, $subject, $message,
    "From: Texas Geocaching Organization<[e-mail]>\n
    X-Mailer: PHP/" . phpversion());
echo "<font class='contenttext'>Thank You for registering with us! Your membership information has been mailed to your email address!
Please check it and follow the directions to activate your account!";
}

 include ('footer.php')  ?>

-Thanks

[Dada78]

Ok I have solved that problem but can;t someone tell me why it doesn't show my footer and credits at the bottom.

Shows it on this page
http://www.texascaching.com/index.php?page=register_form

Not on this
http://www.texascaching.com/index.php?page=register

It's not a HTML issue as I have already gone through that. Has something to do with the parser not processing the whole page. Any ideas or suggestions on this?

-Thanks

[bpat1434]

You have an exit call that kills your script:

<?
    include 'register_form.php'; // Show the form again!
    /* End the error checking and if everything is ok, we'll move on to
     creating the user account */
    exit(); // if the error checking has failed, we'll exit the script!
} 

That's why the footer doesn't show up....

~Brett

[Dada78]

Yes that is true, but without it it will excute and output and display the whole script if it thier are no errors pretaining to that part.

example without it
http://www.texascaching.com/index.php?page=register

Any ideas of how I can replace that exit statement effectively?

-Thanks

[bpat1434]

include the footer just before the exit. It's contained within an if() statement, so you should be okay.

Or, properly format your code so that you have

include('header.html');
if(isset($_POST['submit']))
{
  /**
   *    All code pertaining to the form & validation here
   */
}
else
{
  /**
   *    The form has not been submitted, show default
   */
}
include('footer.html');

~Brett

[Dada78]

That makes sense but I dont have a defined header file because I call the pages through a default template. I.E. the index.php So the index includes the header and the links to the privacy policy, etc. I have a footer file though that contains the copyright etc that is in white outside of the table. So would the above still work?

-Thanks

[bpat1434]

Not 100% sure. Try and find out.

~Brett

[Dada78]

Ok I have this just about working correctly with one snag the email check isn't working. It tells me I have to enter a email if one isn't entered whic is correct, but If it already exists in the database it doesn't trip the error and tell them the email is already in use to enter another. I have it to where one 1 email can be used per username.

Here is the code that is suppose to check that

/* Let's do some checking and ensure that the user's email address or username
does not exist in the database */

$sql_email_check = mysql_query("SELECT email  FROM users
            WHERE email='$email'");
$sql_username_check = mysql_query("SELECT username FROM users
            WHERE username='$username'");

$email_check = mysql_num_rows($sql_email_check);
$username_check = mysql_num_rows($sql_username_check);

if(($email_check > 0) || ($username_check > 0)){
    echo "<h1>Please fix the following errors:</h1> <br />";
    if($email_check > 0){
        echo "<font class='errortext'>*Your email address has already been used by another member
        in our database. Please submit a different Email address!<br />";
        unset($email);
    }
    if($username_check > 0){
        echo "<font class='errortext'>*The username you have selected has already been used by another member
         in our database. Please choose a different Username!<br />";
        unset($username);
    }
?>

Here is the entire code

<?

include 'dbinfo.inc.php';

// Define post fields into simple variables
$first_name = $_POST['first_name'];
$last_name = $_POST['last_name'];
$email = $_POST['email'];
$username = $_POST['username'];


/* Let's strip some slashes in case the user entered
any escaped characters. */

$first_name = stripslashes($first_name);
$last_name = stripslashes($last_name);
$email = stripslashes($email);
$username = stripslashes($username);


?>
<!--ERROR TABLE-->
<table class='fullbox' width='500' height='105' align='center'>
    <tr>
      <td>
<?
/* Do some error checking on the form posted fields */

if((!$first_name) || (!$last_name) || (!$email) || (!$username)){
    echo '<h1>You did not submit the following required information!</h1> <br />';
    if(!$first_name){
        echo "<font class='errortext'>*First Name is a required field. Please enter it below.<br />";
    }
    if(!$last_name){
        echo "<font class='errortext'>*Last Name is a required field. Please enter it below.<br />";
    }
    if(!$email){
        echo "<font class='errortext'>*Email Address is a required field. Please enter it below.<br />";
    }
    if(!$username){
        echo "<font class='errortext'>*Desired Username is a required field. Please enter it below.<br />";
    }
?>
</td>      

         </tr>
       </table>
<table border='0' cellpadding='0' cellspacing='0' width='500' align='center'><tr><td><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td><td class=shadow-mid width='100%'><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td><td><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td></tr></table></center>
<br />
<?
    include 'register_form.php'; // Show the form again!
    /* End the error checking and if everything is ok, we'll move on to
     creating the user account */
    exit(); // if the error checking has failed, we'll exit the script!
}
?>
<!--ERROR TABLE-->
<table class='fullbox' width='500' height='105' align='center'>
    <tr>
      <td>
<?
/* Let's do some checking and ensure that the user's email address or username
does not exist in the database */

$sql_email_check = mysql_query("SELECT email  FROM users
            WHERE email='$email'");
$sql_username_check = mysql_query("SELECT username FROM users
            WHERE username='$username'");

$email_check = mysql_num_rows($sql_email_check);
$username_check = mysql_num_rows($sql_username_check);

if(($email_check > 0) || ($username_check > 0)){
    echo "<h1>Please fix the following errors:</h1> <br />";
    if($email_check > 0){
        echo "<font class='errortext'>*Your email address has already been used by another member
        in our database. Please submit a different Email address!<br />";
        unset($email);
    }
    if($username_check > 0){
        echo "<font class='errortext'>*The username you have selected has already been used by another member
         in our database. Please choose a different Username!<br />";
        unset($username);
    }
?>
</td>      

         </tr>
       </table>
<table border='0' cellpadding='0' cellspacing='0' width='500' align='center'><tr><td><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td><td class=shadow-mid width='100%'><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td><td><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td></tr></table></center>
<br />
<?
    include 'register_form.php'; // Show the form again!
    exit();  // exit the script so that we do not create this account!
}

/* Everything has passed both error checks that we have done.
It's time to create the account! */

/* Random Password generator.
http://www.phpfreaks.com/quickcode/Random_Password_Generator/56.php

We'll generate a random password for the
user and encrypt it, email it and then enter it into the db.
*/

function makeRandomPassword() {
  $salt = "abchefghjkmnpqrstuvwxyz0123456789";
  srand((double)microtime()*1000000);
      $i = 0;
      while ($i <= 7) {
            $num = rand() % 33;
            $tmp = substr($salt, $num, 1);
            $pass = $pass . $tmp;
            $i++;
      }
      return $pass;
}

$random_password = makeRandomPassword();

$db_password = md5($random_password);

// Enter info into the Database.

$sql = mysql_query("INSERT INTO users (first_name, last_name,
        email, username, password, signup_date)
        VALUES('$first_name', '$last_name', '$email',
        '$username', '$db_password', now())")
        or die (mysql_error());

if(!$sql){ ?>
<!--ERROR TABLE-->
<table class='fullbox' width='500' height='105' align='center'>
    <tr>
      <td class='content'>
<?    echo 'There has been an error creating your account. Please contact the webmaster.'; ?></td>      

         </tr>
       </table>
<table border='0' cellpadding='0' cellspacing='0' width='500' align='center'><tr><td><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td><td class=shadow-mid width='100%'><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td><td><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td></tr></table></center>
<br />
<?
} else {
    $userid = mysql_insert_id();
    // Let's mail the user!
    $subject = "Account Activation";
    $message = "Dear $first_name $last_name,
    Thank you for registering at Texascaching.com!

You are two steps away from logging in and accessing our exclusive members area.

To activate your membership,
please click here: http://www.texascaching.com/activate.php?id=$userid&code=$db_password

Once you activate your memebership, you will be able to login
with the following information:
Username: $username
Password: $random_password

Thanks!
The Webmaster

This is an automated response, please do not reply!";

mail($email_address, $subject, $message,
    "From: Registration<[e-mail]>\n
    X-Mailer: PHP/" . phpversion());?>
<!--ERROR TABLE-->
<table class='fullbox' width='500' height='105' align='center'>
    <tr>
      <td class='content'>

<?   echo "<h1>Registration Complete!</h1><font class='contenttext'>Thank You $first_name $last_name for registering with us! Your membership information has been mailed to your email address $email!
    Please check it and follow the directions to activate your account!";
}

?>
</td>      

         </tr>
       </table>
<table border='0' cellpadding='0' cellspacing='0' width='500' align='center'><tr><td><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td><td class=shadow-mid width='100%'><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td><td><img alt='' border='0' height='7' src='http://images.weathertrackcast.com/themes/smooth_gray/misc/1pixel.gif' width='7'></td></tr></table></center>
<br />

-Thanks

[bpat1434]

What does $email_check have a value of after you do your query?

~Brett

[Dada78]

I am not sure, how can I find out?

-Thanks

[rincewind456]

Put this

print $sql_email_check;

after it's run the query here

$sql_email_check = mysql_query("SELECT email  FROM users
            WHERE email='$email'"); 

[Dada78]

It came back with "Resource id #5" Is that the column it should be it or something?

-Thanks

[bpat1434]

No, it's a mySQL result resource ID. It's required for functions like mysql_num_rows() or mysql_fetch_array() and such. So your query is running fine. Now we know that for a fact.

Echo out "$email_check" and check its value. What do you get? (if contained in the database, it should be 1, FALSE.

~Brett

[Dada78]

I tried that but nothing came out. To make sure I was doing it right wouldn't I just include $email_check with a echo statment?

-Thanks

[Dada78]

Ok I have run this code through to check what's going in.

$Q = "SELECT email_address FROM users WHERE email_address='$email_address'";
echo $Q;
$sql_email_check = mysql_query($Q) or die(mysql_error()); 

And it returns the right email that is being submitted. I use a email that is already in there and it doesnt reject it. It rejects username if it is already in, but not email and I have gone through this code over and over and nothing works.

Here is the code that I am using as of now.

<?

include 'dbinfo.inc.php';

// Define post fields into simple variables
$first_name = $_POST['first_name'];
$last_name = $_POST['last_name'];
$email_address = $_POST['email_address'];
$username = $_POST['username'];
$info = $_POST['info'];

/* Let's strip some slashes in case the user entered
any escaped characters. */

$first_name = stripslashes($first_name);
$last_name = stripslashes($last_name);
$email_address = stripslashes($email_address);
$username = stripslashes($username);
$info = stripslashes($info);


/* Do some error checking on the form posted fields */

if((!$first_name) || (!$last_name) || (!$email_address) || (!$username)){
    echo 'You did not submit the following required information! <br />';
    if(!$first_name){
        echo "First Name is a required field. Please enter it below.<br />";
    }
    if(!$last_name){
        echo "Last Name is a required field. Please enter it below.<br />";
    }
    if(!$email_address){
        echo "Email Address is a required field. Please enter it below.<br />";
    }
    if(!$username){
        echo "Desired Username is a required field. Please enter it below.<br />";
    }
    include 'register_form.php'; // Show the form again!
    /* End the error checking and if everything is ok, we'll move on to
     creating the user account */
    exit(); // if the error checking has failed, we'll exit the script!
}

/* Let's do some checking and ensure that the user's email address or username
does not exist in the database */

$sql_email_check = mysql_query("SELECT email_address FROM users
            WHERE email_address='$email_address'"); 
$sql_username_check = mysql_query("SELECT username FROM users
            WHERE username='$username'");

$email_check = mysql_num_rows($sql_email_check);
$username_check = mysql_num_rows($sql_username_check);

if(($email_check > 0) || ($username_check > 0)){
    echo "Please fix the following errors: <br />";
    if($email_check > 0){
        echo "<strong>Your email address has already been used by another member
        in our database. Please submit a different Email address!<br />";
        unset($email_address);
    }
    if($username_check > 0){
        echo "The username you have selected has already been used by another member
         in our database. Please choose a different Username!<br />";
        unset($username);
    }
    include 'register_form.php'; // Show the form again!
    exit();  // exit the script so that we do not create this account!
}

/* Everything has passed both error checks that we have done.
It's time to create the account! */

/* Random Password generator.
http://www.phpfreaks.com/quickcode/Random_Password_Generator/56.php

We'll generate a random password for the
user and encrypt it, email it and then enter it into the db.
*/

function makeRandomPassword() {
  $salt = "abchefghjkmnpqrstuvwxyz0123456789";
  srand((double)microtime()*1000000);
      $i = 0;
      while ($i <= 7) {
            $num = rand() % 33;
            $tmp = substr($salt, $num, 1);
            $pass = $pass . $tmp;
            $i++;
      }
      return $pass;
}

$random_password = makeRandomPassword();

$db_password = md5($random_password);

// Enter info into the Database.
$info2 = htmlspecialchars($info);
$sql = mysql_query("INSERT INTO users (first_name, last_name,
        email_address, username, password, info, signup_date)
        VALUES('$first_name', '$last_name', '$email_address',
        '$username', '$db_password', '$info2', now())")
        or die (mysql_error());

if(!$sql){
    echo 'There has been an error creating your account. Please contact the webmaster.';
} else {
    $userid = mysql_insert_id();
    // Let's mail the user!
    $subject = "Texascaching Account Activation";
    $message = "Dear $first_name $last_name,
    Thank you for registering at Texascaching.com!

You are two steps away from logging in and accessing our exclusive members area.

To activate your membership,
please click here: http://www.texascaching.com/activate.php?id=$userid&code=$db_password

Once you activate your memebership, you will be able to login
with the following information:
Username: $username
Password: $random_password

Thanks!
The Webmaster

This is an automated response, please do not reply!";

mail($email_address, $subject, $message,
    "From: Texascaching Admin<[e-mail]>\n
    X-Mailer: PHP/" . phpversion());
echo 'Your membership information has been mailed to your email address!
Please check it and follow the directions!';
}

?> 

Any ideas or suggestions of what to do?

-Thanks

[bpat1434]

So it returns the email address? Yes? Then change your if() statement to be:
if($email_check || $username_check)....

[Dada78]

Just so I am clear it would be this line

if(($email_check > 0) || ($username_check > 0)){ 

with this line

if(($email_check || $username_check)){

Would that effect the username check cause it is working?

-Thanks

[bpat1434]

Shouldn't, but if it does, then you can change it back, and use 1/2 and 1/2....