regex not working properly

[Ajita]

I am extracting all links by this expression:
function get_tags($string)
{
$urlpattern = "/(<a [^{>]+href=\"']([^\"]+))|";
$urlpattern .= "(<area [^>]+href=[\"')|";}
$urlpattern .= "(<frame [^{>]+src=\"'`)/i";}
preg_match_all($urlpattern,$string,$matches);
return ($matches[0]);
}

it returns limited result not all the '<a' tags like this:
<a href="branchrep/actreport.htm
<a class=menu href="academy/archives.cfm
<a class="leftsubmenuitem" href="http://www.pedicon2006.com
<a class="sleftsubmenuitem" href="chap_communityped.cfm

PROBLEM:
But it gives only following as output:
<a class="sleftsubmenuitem" href="chap_adolped.cfm
<a class="sleftsubmenuitem" href="chap_cardiology.cfm
.......................

[bpat1434]

What is your question.... ask again....

[Ajita]

My problem is that when i crawl a site, here the site is "www.iapindia.org", for extracting links. i use the expression:
function get_tags($string)
{
$urlpattern = "/(<a [^{>]+href=\"']([^\"]+))|";
$urlpattern .= "(<area [^>]+href=[\"')|";}
$urlpattern .= "(<frame [^{>]+src=\"'`)/i";}
preg_match_all($urlpattern,$string,$matches);
return ($matches[0]);
}

but it give only output as:
<a class="sleftsubmenuitem" href="chap_adolped.cfm
<a class="sleftsubmenuitem" href="chap_cardiology.cfm
.......................
Whereas it should give all links present in the source code. but i dont know why it is not giving all links with html tag '<a' ?

[bpat1434]

Using this:

function get_tags($string)
{
	$urlpattern = "/(<a [^>]+href=[\"'`]([^\"]+))|";
	$urlpattern .= "(<area [^>]+href=[\"'`]([^\"]+))|";
	$urlpattern .= "(<frame [^>]+src=[\"'`]([^\"]+))/i";
	preg_match_all($urlpattern,$string,$matches);
	return ($matches[0]);
}

echo implode('<br>', str_replace("<", "&lt;", get_tags(file_get_contents('http://www.iapindia.org'))));

I get this as the output:

<A class=menu href="index.cfm
<A class=menu href="newabout.cfm
<A class=menu href="office.cfm
<A class=menu href="awardlinks.cfm
<A class=menu href="events.cfm
<A class=menu href="publications.cfm
<A class=menu href="recommendations.cfm
<A class=menu href="academy/archives.cfm
<A class=menu href="affiliations.cfm
<A class=menu href="parented.cfm
<A class=menu href="memsearch.cfm
<A class=menu href="discussion.cfm
<A class=menu href="contact.cfm
<A class=menu href="links.cfm
<a class="leftsubmenuitem" href="iap.cfm
<a class="leftsubmenuitem" href="history.cfm
<a class="leftsubmenuitem" href="constitution.cfm
<a class="leftsubmenuitem" href="president.cfm
<a class="leftsubmenuitem" href="annualreport.cfm
<a class="leftsubmenuitem" href="bearers.cfm
<a class="leftsubmenuitem" href="slbranches.cfm
<a class="leftsubmenuitem" href="specialitychapters.cfm
<a class="leftsubmenuitem" href="natconf.cfm
<a class="leftsubmenuitem" href="pastpresidents.cfm
<a class="leftsubmenuitem" href="pastsecy.cfm
<a class="leftsubmenuitem" href="pasttreas.cfm
<a class="leftsubmenuitem" href="NatCom.cfm
<a class="leftsubmenuitem" href="memsearch.cfm?RequestTimeout=1000
<a class="leftsubmenuitem" href="forms.cfm
<a class="leftsubmenuitem" href="afp.cfm
<a class="leftsubmenuitem" href="policyinfant.cfm
<a class="leftsubmenuitem" href="iecsmb.cfm
<a class="leftsubmenuitem" href="vitapolicy.cfm
<a class="leftsubmenuitem" href="tblOfContents.cfm
<a class="leftsubmenuitem" href="iapguidelines.cfm
<a class="leftsubmenuitem" href="awardlinks.cfm
<a class="leftsubmenuitem" href="awardlinks.cfm
<a class="leftsubmenuitem" href="archives.cfm
<a class="leftsubmenuitem" href="meets.cfm
<a class="leftsubmenuitem" href="http://www.pedicon2006.com
<a class="leftsubmenuitem" href="ipa.cfm
<a class="leftsubmenuitem" href="apssear.cfm
<a class="leftsubmenuitem" href="http://istp.upm.edu.ph
<a class="leftsubmenuitem" href="publicationlist.cfm
<a class="leftsubmenuitem" href="academy/archives.cfm
<a class="leftsubmenuitem" href="iaptext.cfm
<a class="leftsubmenuitem" href="http://www.indianpediatrics.net
<a class="leftsubmenuitem" href="posters.cfm
<a class="leftsubmenuitem" href="practiceguidelines.cfm
<a class="leftsubmenuitem" href="parenteducation.cfm
<a class="leftsubmenuitem" href="http://www.webcottage.net/cfforum/index.cfm
<a class="leftsubmenuitem" href="links.cfm
<a class="leftsubmenuitem" href="Contact.cfm
<a class="sleftsubmenuitem" href="chap_adolped.cfm
<a class="sleftsubmenuitem" href="chap_cardiology.cfm
<a class="sleftsubmenuitem" href="chap_communityped.cfm
<a class="sleftsubmenuitem" href="cancl.cfm
<a class="sleftsubmenuitem" href="chap_pediatrics.cfm
<a class="sleftsubmenuitem" href="chap_gastro.cfm
<a class="sleftsubmenuitem" href="chap_genetics.cfm
<a class="sleftsubmenuitem" href="chap_growth.cfm
<a class="sleftsubmenuitem" href="chap_hematology.cfm
<a class="sleftsubmenuitem" href="chap_infectiousdisease.cfm
<a class="sleftsubmenuitem" href="chap_intensivecare.cfm
<a class="sleftsubmenuitem" href="chap_neonatology.cfm
<a class="sleftsubmenuitem" href="chap_nephrology.cfm
<a class="sleftsubmenuitem" href="chap_neurology.cfm
<a class="sleftsubmenuitem" href="chap_nutrition.cfm
<a class="sleftsubmenuitem" href="chap_respiratory.cfm
<a class="sleftsubmenuitem" href="chap_tuberculosis.cfm
<a class="sleftsubmenuitem" href="group_childhealth.cfm
<a class="sleftsubmenuitem" href="group_computer.cfm
<a class="sleftsubmenuitem" href="group_disability.cfm
<a class="sleftsubmenuitem" href="group_rheumatology.cfm

[xblue]

This part of the pattern
<a [^>]+
requires a space and at least one character that is not >, so it matches tags that have additional attributes before the href attribute, but not those where the href attribute is the first one with only one space before it.
<a [^>]* should work in both cases.

[bpat1434]

I don't disagree; however, why would his not work, and mine create all those entries? It seems he gets only 2 links, whereas he wants all 80 or so links.

<?php

function get_tags($string)
{
	$urlpattern = "/(<a[^>]*href=[\"'`]([^\"]+)[\"'`][^>]*>)|";
	$urlpattern .= "(<area[^>]*href=[\"'`]([^\"]+)[\"'`][^>]*>)|";
	$urlpattern .= "(<frame[^>]*src=[\"'`]([^\"]+)[\"'`][^>]*>)/i";
	preg_match_all($urlpattern,$string,$matches);
	return ($matches[0]);
}

echo implode('<br>', str_replace("<", "&lt;", get_tags(file_get_contents('http://www.iapindia.org'))));
?>

Output:

<A class=menu href="index.cfm">
<A class=menu href="newabout.cfm">
<A class=menu href="office.cfm">
<A class=menu href="awardlinks.cfm" title="Awards and Fellowships">
<A class=menu href="events.cfm">
<A class=menu href="publications.cfm">
<A class=menu href="recommendations.cfm" title="Recommendations and Guidelines">
<A class=menu href="academy/archives.cfm">
<A class=menu href="affiliations.cfm">
<A class=menu href="parented.cfm">
<A class=menu href="memsearch.cfm">
<A class=menu href="discussion.cfm">
<A class=menu href="contact.cfm">
<A class=menu href="links.cfm">
<a href="abstract/index.cfm">
<a href="http://www.indianpediatrics.net" target="new">
<a href="academy/archives.cfm">
<a href="http://www.ijpp.in">
<a href="annualreport.cfm">
<a href="president.cfm">
<a href="http://iapdrugformulary.com">
<a href="http://www.pedicon2006.com">
<a href="worldsocietities.htm">
<a href="POLIO.htm">
<a href="BRANCHES/iapbranches.cfm">
<a href="BRANCHREP/ACTREPORT.htm">
<a href="iapact.htm">
<a href="Academy/ATOD 05.pdf">
<a href="awardfor 2005.htm">
<a href="NOTICE.htm">
<a href="MINUTES.htm">
<a href="cfforum/viewmessages.cfm?forum=7&topic=771" class="latestpost" target="new">
<a href="cfforum/viewmessages.cfm?forum=9&topic=906" class="latestpost" target="new">
<a href="cfforum/viewmessages.cfm?forum=7&topic=771" class="latestpost" target="new">
<a href="cfforum/viewmessages.cfm?forum=12&topic=1110" class="latestpost" target="new">
<a href="cfforum/viewmessages.cfm?forum=12&topic=1110" class="latestpost" target="new">
<a href="cfforum/viewmessages.cfm?forum=11&topic=1109" class="latestpost" target="new">
<a href="cfforum/viewmessages.cfm?forum=7&topic=1108" class="latestpost" target="new">
<a href="cfforum/viewmessages.cfm?forum=9&topic=1080" class="latestpost" target="new">
<a href="cfforum/viewmessages.cfm?forum=7&topic=1103" class="latestpost" target="new">
<a href="cfforum/viewmessages.cfm?forum=7&topic=1107" class="latestpost" target="new">
<A href="discussion.cfm" target="new" border="0" onMouseOver ="changeImages('forum', 'forumOn')" onMouseOut="changeImages('forum', 'forumDefault')" >
<a class="leftsubmenuitem" href="iap.cfm">
<a class="leftsubmenuitem" href="history.cfm">
<a class="leftsubmenuitem" href="constitution.cfm">
<a class="leftsubmenuitem" href="president.cfm">
<a class="leftsubmenuitem" href="annualreport.cfm">
<a class="leftsubmenuitem" href="bearers.cfm">
<a class="leftsubmenuitem" href="slbranches.cfm">
<a class="leftsubmenuitem" href="specialitychapters.cfm">
<a class="leftsubmenuitem" href="natconf.cfm" title="National Conferences">
<a class="leftsubmenuitem" href="pastpresidents.cfm">
<a class="leftsubmenuitem" href="pastsecy.cfm">
<a class="leftsubmenuitem" href="pasttreas.cfm">
<a class="leftsubmenuitem" href="NatCom.cfm" title="National Committees">
<a class="leftsubmenuitem" href="memsearch.cfm?RequestTimeout=1000">
<a class="leftsubmenuitem" href="forms.cfm" title="Membership Application Form">
<a class="leftsubmenuitem" href="afp.cfm" >
<a class="leftsubmenuitem" href="policyinfant.cfm">
<a class="leftsubmenuitem" href="iecsmb.cfm">
<a class="leftsubmenuitem" href="vitapolicy.cfm">
<a class="leftsubmenuitem" href="tblOfContents.cfm" title="IAP Guidebook of Immunization">
<a class="leftsubmenuitem" href="iapguidelines.cfm">
<a class="leftsubmenuitem" href="awardlinks.cfm">
<a class="leftsubmenuitem" href="awardlinks.cfm">
<a class="leftsubmenuitem" href="archives.cfm">
<a class="leftsubmenuitem" href="meets.cfm">
<a class="leftsubmenuitem" href="http://www.pedicon2006.com">
<a class="leftsubmenuitem" href="ipa.cfm" title="International Pediatrics Association">
<a class="leftsubmenuitem" href="apssear.cfm" title="Association of Pediatric Societies of the South East Asian Region" target="new">
<a class="leftsubmenuitem" href="http://istp.upm.edu.ph" title="International Society of Tropical Pediatrics" target="new">
<a class="leftsubmenuitem" href="publicationlist.cfm">
<a class="leftsubmenuitem" href="academy/archives.cfm">
<a class="leftsubmenuitem" href="iaptext.cfm" title="Textbook of Pediatrics">
<a class="leftsubmenuitem" href="http://www.indianpediatrics.net" target="_blank">
<a class="leftsubmenuitem" href="posters.cfm">
<a class="leftsubmenuitem" href="practiceguidelines.cfm">
<a class="leftsubmenuitem" href="parenteducation.cfm">
<a class="leftsubmenuitem" href="http://www.webcottage.net/cfforum/index.cfm" target="new">
<a class="leftsubmenuitem" href="links.cfm">
<a class="leftsubmenuitem" href="Contact.cfm">
<a href="meets.cfm" class="leftsubmenuitem">
<a class="sleftsubmenuitem" href="chap_adolped.cfm">
<a class="sleftsubmenuitem" href="chap_cardiology.cfm">
<a class="sleftsubmenuitem" href="chap_communityped.cfm">
<a class="sleftsubmenuitem" href="cancl.cfm">
<a class="sleftsubmenuitem" href="chap_pediatrics.cfm">
<a class="sleftsubmenuitem" href="chap_gastro.cfm">
<a class="sleftsubmenuitem" href="chap_genetics.cfm">
<a class="sleftsubmenuitem" href="chap_growth.cfm">
<a class="sleftsubmenuitem" href="chap_hematology.cfm">
<a class="sleftsubmenuitem" href="chap_infectiousdisease.cfm">
<a class="sleftsubmenuitem" href="chap_intensivecare.cfm">
<a class="sleftsubmenuitem" href="chap_neonatology.cfm">
<a class="sleftsubmenuitem" href="chap_nephrology.cfm">
<a class="sleftsubmenuitem" href="chap_neurology.cfm">
<a class="sleftsubmenuitem" href="chap_nutrition.cfm">
<a class="sleftsubmenuitem" href="chap_respiratory.cfm">
<a class="sleftsubmenuitem" href="chap_tuberculosis.cfm">
<a class="sleftsubmenuitem" href="group_childhealth.cfm">
<a class="sleftsubmenuitem" href="group_computer.cfm">
<a class="sleftsubmenuitem" href="group_disability.cfm">
<a class="sleftsubmenuitem" href="group_rheumatology.cfm">

I stand corrected.....

[Ajita]

Thanx, It did work.

[Ajita]

Hi,
I tried the code. But sometimes it execute and sometimes it shows 'Fatal Error'
Fatal error: Maximum execution time of 30 seconds exceeded

[Ajita]

Thanx for your help I solved my problem