js call from php link

paulkenn

I have had no problems calling javascript popup window functions within my php code...until now.

Here's the code

<?php if($line["desinit"] == "AML" and $line["type"] == "changes"){
print "<a href=../forms/contract_edit_changes_popup.php?idx=";
print $line["contract_num"];
print "'>";
print $line["contract_num"];
print "</a>";
}

I don't know where in my code (specifically within <a href /a>) to put the onclick=openpopup4 ??

and call this function in the <HEAD> tag

*function openpopup4(popUrl,winName,features){
window.open(popUrl,"",features)

Here is the other coding I use that does work but in this instance the php is within the link
<a href="#" onClick="openpopup2('<?php echo $filePre . '?idx='. $line['client_id']; ?>','','width=435,height=630,scrollbars=yes');">
link</a>

I know this should probably go in a js forum but I haven't found a satisfactory answer in any of them.

thanks

devinemke

if ($line['desinit'] == 'AML' && $line['type'] == 'changes')
{
	echo '<font size="2"><a href="javascript:openpopup4(\'../forms/contract_edit_changes_popup.php?idx=\'' . $line['contract_num'] . '\', \'winName\', \'features\'">' . $line['contract_num'] . '</a></font>';
}

replace winName with what you want the window to be named and features with what size/position you want.

paulkenn

Okay I see the logic in that, however I am getting an error on page in the browser...

here is the js and the code as it stands now.

function openpopup4{
window.open(popUrl,"","")

<?php if ($line['desinit'] == 'AML' && $line['type'] == 'changes')
{
echo '<a href="javascript: openpopup4(\'../forms/contract_edit_changes_popup.php?idx=\'' . $line['contract_num'] . '\', \'Edit Contract\', \'width=435,height=450,scrollbars,top=40,left=40\'">' . $line['contract_num'] . '</a>';
}

						elseif ($line['type'] == 'changes')

{
echo '<a href="javascript: openpopup4(\'../forms/contract_edit_popup.php?idx=\'' . $line['contract_num'] . '\', \'Edit Contract\', \'width=435,height=450,scrollbars,top=40,left=40\'">' . $line['contract_num'] . '</a>';
}

(Note: there's no space in my code between javascript: and openpopup4)

vattila

from your echoed string there is missing closing bracket and semicolon to generate right sintax for the js on the html page

..... top=40,left=40\');">' . .........