Prev | Next HELP PLEASE

[gobbles]

Hey All,

Im currently using the script found at http://www.phpbuilder.com/snippet/download.php?type=snippet&id=368 to view a list of users in a database.

Im using sessions in the url, so the url looks like so useradmin.php?PHPSESSID=f70bea770934491d39a348d55684aff2

When i refresh the page with the prev next code inserted, i get the following errors:

Notice: Use of undefined constant search - assumed 'search' in /admin/useradmin.php on line 54

Lines 53 and 54 are populated by the following:

if(!isset($thisOffset) || $thisOffset < 0) $thisOffset=0;
if ($action==search) $thisOffset = $thisOffset - 1;

I also get another error:

Notice: Undefined variable: action in /admin/useradmin.php on line 54

and once again another error

Notice: Undefined variable: lineIndex in /admin/useradmin.php on line 144

Lines 140 - 144 are populated by the following:

$query = mysql_query($sql, $con);
while ($result=mysql_fetch_array($query)) {
// Increment the line index by 1
$lineIndex++;

I have no idea where im going wrong, am i ment to pass anything in the URL along with the session id?

Someone please shed some light on this for me 🙂

Cheers

[jamie85]

if ($action==search)

strings should be compared using either

=== 

or

strcmp()

and search should be in quotes: "search"

action, lineIndex and offset are taken from the URI

eg. site.com?action=search&lineIndex=10&offset=5

You will probably have to call that page using

site.com/page.php?action=search

You wont need to include the lineIndex and offset as the following lines test for these values

if (!isset($thisOffset) || $thisOffset < 0) $thisOffset=0; 

If they are not in the URI, they are just set to 0.

Another point is at the top of the page you should get the variables from the URI like so

$action = $_GET['action'];

[gobbles]

Thanks for your reply jamie,

It seemed to clear up the errors, but theres one more left over.

When i call the script /admin/useradmin.php?action=search&PHPSESSID=7814b663343c2e9813ede0b453dac0a6

i get the following error

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /admin/useradmin.php on line 142

Lines 141 and 142 are as follows:

$query = mysql_query($sql, $con);
while ($result=mysql_fetch_array($query)) {

[blackhorse]

$query = mysql_query($sql, $con);
echo mysql_error();
while ($result=mysql_fetch_array($query)) {

To see what the sql error is.

[gobbles]

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-1,5' at line 1

[jamie85]

gobbles wrote:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-1,5' at line 1

What does $sql contain? could we see?

[gobbles]

$con = mysql_connect("$server","$userid","$pass") or die ("Connection error to server");
$db = mysql_select_db("$database",$con) or die ("Connection error to database");

// If thisOffset not set, set to zero

if(!isset($thisOffset) || $thisOffset < 0) $thisOffset=0;
if ($action=="search") $thisOffset = $thisOffset - 1;

// Set base SQL statement for the query

$sql = "SELECT * FROM $dbtable";

// Query for the total number of rows

$getTotalRows = mysql_query($sql, $con);
$totalRowsNum = mysql_num_rows($getTotalRows);

// Append the limit and offset to the SQL

$sql .= " LIMIT $thisOffset,$recordLimit";

[madwormer2]

You can't start a recordset from -1.

It just doesn't make sense.

[gobbles]

I only copied the code from the original source code,

Should i take out the - 1 bit?

[madwormer2]

Either that, or add below

if($thisOffset<0) $thisOffset =0;