foreach and query

[tito]

Why would the below return

name1
name2

name1
name2
name3
name4

name1
name2
name3
name4
name5
name6

repeating the previous values over and over? I only want to do the same query for every valid key and return the values for that key only.

 foreach($playerid1 as $playerkey1=>$playervalue1){
if (!empty($playervalue1)){
$getplayers1 = $DB_site->query("SELECT * FROM cclpinternational_players WHERE id = $playerkey1");
while ($getplayer1 = $DB_site->fetch_array($getplayers1)){
$lname1=$getplayer1['lname'];
$fname1=$getplayer1['fname'];
eval('$players1 .= "' . fetch_template('soccer_viewstatsplayer1') . '";');
}
}
} 

[planetsim]

What does the $playerid1 contain? Is it possible to make it one Query instead of looping the query? Also perhaps test the Query in PHPMyAdmin to see what results are pulled from the table.

[tito]

Playerid1 is from the unserialize of an array

$playerid1=unserialize($getname['preddata1']);

the array looks like that in the db

a:5:{s:10:"0000000037";s:0:"";s:10:"0000000038";s:2:"50";s:10:"0000000039";s:2:"76";s:10:"0000000040";s:0:"";s:10:"0000000041";s:0:"";}

I get it from

if ($_REQUEST['do']=='stats') {
$u=$_REQUEST['u'];

define('STATS', 'true');

$getnames = $DB_site->query("SELECT cclpinternational_predictions.*, team1.name as theteam1, team2.name as theteam2, scores.team1_score as ascore1, scores.team2_score as ascore2, user.username as username
FROM cclpinternational_predictions 
LEFT JOIN cclpinternational_teams as team1 ON(cclpinternational_predictions.teamid1=team1.id)
LEFT JOIN cclpinternational_teams as team2 ON(cclpinternational_predictions.teamid2=team2.id)
LEFT JOIN cclpinternational_schedule_scores as scores ON(cclpinternational_predictions.gameid=scores.id)

LEFT JOIN user as user ON(cclpinternational_predictions.userid=user.userid)
WHERE winner='1' AND cclpinternational_predictions.userid='$u'
while ($getname = $DB_site->fetch_array($getnames)){
$teamid1=$getname['teamid1'];
$username=$getname['username'];
$totwins=$getname['totwins'];
$playerid1=unserialize($getname['preddata1']);
foreach($playerid1 as $playerkey1=>$playervalue1){ 
if (!empty($playervalue1)){ 
$getplayers1 = $DB_site->query("SELECT * FROM cclpinternational_players WHERE id = $playerkey1"); 
while ($getplayer1 = $DB_site->fetch_array($getplayers1)){ 
$lname1=$getplayer1['lname']; 
$fname1=$getplayer1['fname']; 
eval('$players1 .= "' . fetch_template('soccer_viewstatsplayer1') . '";'); 
} 
} 
}
$stats=1;
eval('$viewone .= "' . fetch_template('soccer_viewstats') . '";');
}
}


");

[tito]

When I don't do the eval for $players1, I get only one player per row, which is understandable

$players1="$lname1, $fname1";
//eval('$players1 .= "' . fetch_template('soccer_viewstatsplayer1') . '";');