Help with Addition

treeleaf20

I'm trying to grab a value from the database and then add one to it, but for some reason it add's two. I have the following code:

$sqlviews = "SELECT views FROM forum_messages where messageid='$messageid'";
$resultviews = mysql_query($sqlviews) or die(mysql_error());
$row = mysql_fetch_array($resultviews);  

$views = $row['views'];
echo "The value from the db is: $views<br>";
$views = $views + 1;
echo "The update value from the db is: $views<br>";

$sqlupdate = "Update forum_messages set views='$views' where messageid='$messageid'";
echo $sqlupdate;
$resultupdate = mysql_query($sqlupdate);

When I echo The value from the db is: $views it already adds the 1 already from the database and I'm not sure why. Then when I add 1 to it that makes it two, but if I do this:

$sqlviews = "SELECT views FROM forum_messages where messageid='$messageid'";
$resultviews = mysql_query($sqlviews) or die(mysql_error());
$row = mysql_fetch_array($resultviews);  

$views = $row['views'];
echo "The value from the db is: $views<br>";
//$views = $views + 1;
//echo "The update value from the db is: $views<br>";

$sqlupdate = "Update forum_messages set views='$views' where messageid='$messageid'";
echo $sqlupdate;
$resultupdate = mysql_query($sqlupdate);

When I do that it doesn't add anything. The code is only getting executed once so I can't figure out what the problem is. Any help is greatly appreciated.

jjfletch

What happens if you change you query to:

$sqlviews = "SELECT SUM(views+1) AS views2 FROM forum_messages where messageid='$messageid'";

treeleaf20

That seems to make things really weird. Doesn't work. Any other ideas?

jjfletch

Did you change $row['views'] to $row['views2'] in your syntax?
i.e.

$views = $row['views2']; 
echo "The value from the db is: $views<br>";

treeleaf20

That wasn't working so I tried this:

$sqlviews = "SELECT MAX(views) as views2 FROM forum_messages where messageid='$messageid' and original='Y'";
//$sqlviews = "SELECT SUM(views+1) AS views2 FROM forum_messages where messageid='$messageid' and original='Y'";
$resultviews = mysql_query($sqlviews) or die(mysql_error());
$row = mysql_fetch_array($resultviews);  

$views = $row['views2'];
//echo "The value from the db is: $views<br>";
$views = $views + 1;

And that didn't work either

jjfletch

This worked when I tried it:

$q = "SELECT SUM(views+1) as views2 from forum_messages WHERE messageid='$messageid' and original='Y'";
$result = mysql_query($q);

$row=mysql_fetch_array($result);
$views = $row['views2'];

echo "$views";

But views has a field type int(8) in my db.

treeleaf20

It still does it by 2, I have no idea why it keeps doing it.

rincewind456

So why not do it in the db like

UPDATE forum_messages SET views=views+1 WHERE messageid='$messageid'

treeleaf20

It seems like if I run the query in the db it works fine, but when I try and run it from the actual script it doesn't work. I tried to add this bit of code to limit from doing it again:

$updateviews = "0";
if ($updateviews == "0"){
$q = "UPDATE forum_messages SET views=views+1 WHERE messageid='$messageid' and original='Y'";
$resultupdateviews = mysql_query($q);
$updateviews = $updateviews + 1;
echo "It updates! <br> $updateviews";
}else{
echo "It does try and do it twice";
}

It only shows that it executes it once but it still adds 2!

Plasma

The query will only increment the value by one.

Your running the script twice, there is nothing wrong with that query.