[RESOLVED] Undefined Index error

[fingerbob]

Hi everyone, am very new to PHP and am struggling with an getting rid of the following error message:

Notice: Undefined index: subpage in c:\Inetpub\wwwroot\main.php on line 30

Below is the section of code:

<?php // file main.php
		echo '<div id="mid">'; 
		switch ($_GET['subpage'])
		{
		  case 'GrpServ':
		    include "GrpServ.php";
		    break; 
		  case 'ShortSea':
		    include "ShortSea.php";
			break;
		  case 'DeepSea':
		    include "DeepSea.php";
			break;
		  case 'HMRC':
		    include "HMRC.php";
			break;
		  default:
		    include "home.php";
		}
		echo '</div>';
   ?> 

I've had a look through the forums and have seen that some people suggest using isset and empty but i'm a little unsure on how to incorporate either into my code.

Please could someone help? I dont like to have things done for me but this one is proving to be a bit of a git at the moment!

Many thanks

[Installer]

Enclose the switch structure inside an if block:

if (isset($_GET['subpage'])) {
    // switch stuff
} else {
    // handle unset $_GET
}

[fingerbob]

Hi Installer, thanks for the advice. I tried what you suggested and got the following error:

Parse error: syntax error, unexpected '}', expecting ':' or '{' in c:\Inetpub\wwwroot\main.php on line 33

Here's the code:

echo '<div id="mid">';				
		if(isset($_GET['subpage']))
		{
			switch ($_GET['subpage'])
		}
		else
		{
		  case 'GrpServ':
		    include "GrpServ.php";
		    break; 
		  case 'ShortSea':
		    include "ShortSea.php";
			break;
		  case 'DeepSea':
		    include "DeepSea.php";
			break;
		  case 'HMRC':
		    include "HMRC.php";
			break;
		  case '20std':
		  	include "20standard.php";
			break;
		  case '40std':
		  	include "40standard.php";
			break;	  

		  case '40high':
		  	include "40high.php";
			break;
		  default:
		    include "home.php";
		}
		echo '</div>';

Apart from placing the curly brackets on separate lines i cant see (i am short sighted!) too much of a difference. Pls help!

[Installer]

You didn't put a semicolon at the end of line 32.

I have to ask this: how do you expect the "switch" block to function when you put part of it in an "if" block and the rest in the corresponding "else" block?

Like this:

if (isset($_GET['subpage'])) { 
    switch ($_GET['subpage']) { 
        case 'GrpServ': 
            include "GrpServ.php"; 
            break; 
        case 'ShortSea': 
            include "ShortSea.php"; 
            break; 
        case 'DeepSea': 
            include "DeepSea.php"; 
            break; 
        case 'HMRC': 
            include "HMRC.php"; 
            break; 
        case '20std': 
            include "20standard.php"; 
            break; 
        case '40std': 
            include "40standard.php"; 
            break;       

        case '40high': 
            include "40high.php"; 
            break; 
        default: 
            include "home.php";
    } 
} else {
    echo '$_GET[subpage] is not set.'; 
}

[fingerbob]

Hi Installer, many thanks for your help! Regarding your second point about the switch block being in the 'if' section and also in the 'else' section, looking at it now it does look a bit stupid trying to do it that way.

I am learning and any help like this is gratefully received so hopefully you wont see another post on this subject from me!

Cheers again

[fandhie]

this is a very old thread but it's very useful for me...🙂
thanks