Ahem, could this be shorter?

[eyespark]

Hi there!

New to the forum and with a problem. Articles on my site are divided in max 3 pages. If I have more than one page, I would like next and previous links (next on the bottom and previous on the top of the article). Here is what I came up with. It works but I would like to know if there is a better way. 🙂

Thanks in advance from Slovenia

<?
if ($pageCount == 2) {
	if (!isset($_GET['page'])) {
	$next = '<a href="index.php?action=article&aid='.$_GET['aid'].'&page=1">Next</a>';
	$prev = "";
	} elseif ($_GET['page'] == "1") {
	$prev = '<a href="index.php?action=article&aid='.$_GET['aid'].'">Previous</a>';
	$next = "";
	}
} elseif ($pageCount == 3) {
	if (!isset($_GET['page'])) {
	$next = '<a href="index.php?action=article&aid='.$_GET['aid'].'&page=1">Next</a>';
	$prev = "";
	} elseif ($_GET['page'] == 1) {
	$prev = '<a href="index.php?action=article&aid='.$_GET['aid'].'">Previous</a>';
	$next = '<a href="index.php?action=article&aid='.$_GET['aid'].'&page=2">Next</a>';
	} elseif ($_GET['page'] == "2") {
	$prev = '<a href="index.php?action=article&aid='.$_GET['aid'].'&page=1">Previous</a>';
	$next = "";
	}
}
?>

[devinemke]

$prev = '';
$next = '';

if ($pageCount > 1)
{
	if (!isset($_GET['page']))
	{
		$prev_page = '';
		$next_page = 2;
	}
	else
	{
		if ($_GET['page'] == 1) {$prev_page = '';} else {$prev_page = $_GET['page'] - 1;}
		if ($_GET['page'] == 3) {$next_page = '';} else {$next_page = $_GET['page'] + 1;}
	}

$link = '<a href="index.php?action=article&aid=' . $_GET['aid'];
if ($prev_page) {$prev = $link . '&page=' . $prev_page . '">previous</a>';}
if ($next_page) {$next = $link . '&page=' . $next_page . '">next</a>';}
}

[eyespark]

Thank you

I have one more question. How would the code look with for loop (if I have for example 10 or 20 page articles)?

Thanks again

[devinemke]

eyespark wrote:

How would the code look with for loop (if I have for example 10 or 20 page articles)?

$prev = '';
$next = '';

if ($pageCount > 1)
{
    if (!isset($_GET['page']))
    {
        $prev_page = '';
        $next_page = 2;
    }
    else
    {
        if ($_GET['page'] == 1) {$prev_page = '';} else {$prev_page = $_GET['page'] - 1;}
        if ($_GET['page'] == $pageCount) {$next_page = '';} else {$next_page = $_GET['page'] + 1;}
    }

$link = '<a href="index.php?action=article&aid=' . $_GET['aid'];
if ($prev_page) {$prev = $link . '&page=' . $prev_page . '">previous</a>';}
if ($next_page) {$next = $link . '&page=' . $next_page . '">next</a>';}
}