[RESOLVED] problem with if() statments

rbblue8

here is the code

<?PHP
//main function script


//define if functions here to call functions
if($_POST['Submit']==Submit)login();
elseif(Events==true)Events();
elseif(Crafting==true)Crafting();
elseif(Quest==03)Quest();
elseif(profile==04)profile();
elseif(Communications==05)Communications();
elseif(Logout==06)logout();

else die('<center><span style="color:FFFFFF">what are you doing, you need to login first!');


function login(){
	$user=$_POST['user'];
	include 'mysql.php';
	//do the login query
	$query=("SELECT username, password FROM website where username = '$user'");
	#echo $query; //used for degub of script
	$result=mysql_query($query, $db);
	if(!$result)die('<center><span style="color:FFFFFF">>unable to get information, contact site administration' .mysql_error());
	if (mysql_num_rows($result)==0)die('<center><span style="color:FFFFFF">incorect user name');
	//check that the user name and password are correct
	$row = mysql_fetch_row($result);
	if($row[1] > $_POST['pass'])die('<center><span style="color:FFFFFF">Wrong password, Try again<br><center>Click back to continue');
	#echo ('<center><span style="color:FFFFFF">sucess!');
	if($row[1]==$_POST['pass'])$_SESSION['login']=true;
	$_SESSION['username']=$row[0];
	session_cache_expire(60);
	mysql_close($db);
	members();
	};






function members(){
	echo 'cool';
	include 'mysql.php';
	$user=$_SESSION['username'];
	//do the get account query
	$query=("SELECT username, name, rank FROM website where username='$user'");
	#echo $query;
	$result=mysql_query($query, $db);
	if(!$result)die('<center><span style="color:FFFFFF">unable to get information: ' .mysql_error());
	$row = mysql_fetch_row($result);
	if($row==0)die('<center><span style="color:FFFFFF">unable to get any record information, Contact site Administration');
	$user=$row[0];
	$name=$row[1];
	$rank=$row[2];
	include 'pages/member.php';
	mysql_close($db);	
	};



function events(){
	echo '<center><span style="color:FFFFFF">Comming Soon!';


}	


function logout(){
	$_SESSION = array(); // Assign a new array to session, overwriting all previous contents
	session_destroy(); // Destroy the Session
	header("Location: ../home.php"); // Return user to homepage 	
	}

?>

The problem is, when you call on that script directly (as in httpd://script-location/file-name.php), it goes to the events() function

why is that? nothing is setting anything true.

devinemke

Events, Crafting, Quest etc.. are those all constants? if so where are you defining them? you should run this script with full error reporting if you aren't already.

rbblue8

devinemke wrote:
Events, Crafting, Quest etc.. are those all constants? if so where are you defining them? you should run this script with full error reporting if you aren't already.

the script is not done yet. I shall quickly wirte that stuff into the script and see what happans from there. I do not think it will affect anything for none of the crafting, quest etc.. are called yet. If they were I would be getting the error "call to undefined function". And I'm not.... it's just process the Events quest for dang reason.

So what would error reporting do??

devinemke

rbblue8 wrote:
So what would error reporting do??

it will spit out a bunch of "undefined constants" errors. you are refering to constants that do not exist (at least not in the code as posted)

rbblue8

ok new code is as follows

<?PHP
//main function script


//define if functions here to call functions
if($_POST['Submit']==Submit)login();
elseif(Events==true)events();
elseif(Crafting==true)Crafting();
elseif(Quest==true)Quest();
elseif(profile==true)profile();
elseif(Communications==true)Communications();
elseif(Logout==true)Logout();

else die('<center><span style="color:FFFFFF">what are you doing, you need to login first!');


function login(){
	$user=$_POST['user'];
	include 'mysql.php';
	//do the login query
	$query=("SELECT username, password FROM website where username = '$user'");
	#echo $query; //used for degub of script
	$result=mysql_query($query, $db);
	if(!$result)die('<center><span style="color:FFFFFF">>unable to get information, contact site administration' .mysql_error());
	if (mysql_num_rows($result)==0)die('<center><span style="color:FFFFFF">incorect user name');
	//check that the user name and password are correct
	$row = mysql_fetch_row($result);
	if($row[1] > $_POST['pass'])die('<center><span style="color:FFFFFF">Wrong password, Try again<br><center>Click back to continue');
	#echo ('<center><span style="color:FFFFFF">sucess!');
	if($row[1]==$_POST['pass'])$_SESSION['login']=true;
	$_SESSION['username']=$row[0];
	session_cache_expire(60);
	mysql_close($db);
	members();
	};






function members(){
	include 'mysql.php';
	$user=$_SESSION['username'];
	//do the get account query
	$query=("SELECT username, name, rank FROM website where username='$user'");
	#echo $query;
	$result=mysql_query($query, $db);
	if(!$result)die('<center><span style="color:FFFFFF">unable to get information: ' .mysql_error());
	$row = mysql_fetch_row($result);
	if($row==0)die('<center><span style="color:FFFFFF">unable to get any record information, Contact site Administration');
	$user=$row[0];
	$name=$row[1];
	$rank=$row[2];
	include 'pages/member.php';
	mysql_close($db);	
	};






function events(){
	echo '<center><span style="color:FFFFFF">Comming Soon!';


}	






function Quest(){
	echo 'you have reached the quest section';

}






function profile(){
	echo 'you have reached the profile section';
	}






function Communications(){
	echo 'you have reached the communication section';
	}






function Logout(){
	$_SESSION = array(); // Assign a new array to session, overwriting all previous contents
	session_destroy(); // Destroy the Session
	header("Location: ../home.php"); // Return user to homepage 	
	}

?>

Same thing. Something is still allowing the events() function to be called. When this line

else die('<center><span style="color:FFFFFF">what are you doing, you need to login first!');

should stop it

thorpe

You still haven't defined any of those constants. Events, Crafting, Quest etc..... What are they?

devinemke

you are still never defining any of the constants in your coditional block at the top of the script. in this line:

elseif(Events==true) ...

Events refers to a constant. you are never defining it.

rbblue8

elseif(Events==true)events();

if that statment is found be to be true then it calls the function events()

that statment is defind by a post to this script.
I have a link like this

<a href=?Events=true>

which inturn submits to that php script

so they are defined?

thorpe

Well, it should look like...

elseif($_GET['Events'] == "true") events();

then.

devinemke

i suggest an alternate approach to all this. rather then passing the function name as the GET name with a GET value of true, why not pass the GET name as "action" and the GET value as the function name. like this:

<a href="index.php?action=events>events</a>
<a href="index.php?action=crafting">crafting</a>
<a href="index.php?action=quest">quest</a>
etc...

then your coditional block might look like:

if (!isset($_SESSION['login'])) {exit('what are you doing, you need to login first!');}

$actions = get_defined_functions();
$actions = $actions['user'];

if (isset($_POST['Submit']) && $_POST['Submit'] == 'Submit') {login();}
if (isset($_GET['action']) && in_array($_GET['action'], $actions)) {call_user_func($_GET['action']);}

// rest of code...

rbblue8

ended up going with this

if($_POST['Submit']==Submit)Login();
elseif($_GET['Events'] == "true") Events();
elseif($_GET['crafting'] == "true") crafting();  

elseif($_GET['Quest'] == "true") Quest(); 
elseif($_GET['Profile'] == "true") Profile(); 
elseif($_GET['Communications'] == "true") Communications(); 
elseif($_GET['Logout'] == "true") Logout();

Thanks guys! Everything works 🙂