Initiating a function

[wickdani]

I am having trouble getting a function to execute.

Here is the function as it is written.

function get_tag_cloud_html($freetag, $num_tags = 100, $min_font_size = 10, $max_font_size = 20, $font_units = 'px', $span_class = 'cloud_tag', $tag_page_url = '/tag/')

{

    $tag_list = $freetag->silly_list();

    // Get the maximum qty of tagged objects in the set
    $max_qty = max(array_values($tag_list));


    // Get the min qty of tagged objects in the set
    $min_qty = min(array_values($tag_list));

    // For every additional tagged object from min to max, we add
    // $step to the font size.
    $step = ($max_font_size - $min_font_size)/($max_qty - $min_qty);

    // Since the original tag_list is alphabetically ordered,
    // we can now create the tag cloud by just putting a span
    // on each element, multiplying the diff between min and qty
    // by $step.

    $cloud_html = '';
    $cloud_spans = array();
    foreach ($tag_list as $tag => $qty) {
        $size = $min_font_size + ($qty - $min_qty) * $step;
        $cloud_span[] = '<span class="' . $span_class . '" style="font-size: '. $size . $font_units . '"><a href="'.$tag_page_url . $tag . '">' . htmlspecialchars(stripslashes($tag)) . '</a></span>';
    }


    $cloud_html = join("\n ", $cloud_span);

    return $cloud_html;

}

I am having trouble initializing or calling the function so it runs. Here is how I'm currently trying to invoke it in the same file:

get_tag_cloud_html($freetag);

I've tried leaving the (); and removing $freetag, but I get an error message saying there is a missing argument. When I leave ($freetag);, I don't get an error, but it doesn't return anything.

The $freetag variable is supposed to hold an initiated object called earlier in the file:

$freetag = new freetag($freetag_options);

I believe the freetag object is successfully being initiated because when I echo it it says Object ID #1.

I can't pinpoint where I'm going wrong, if it's in passing the object to the function or in initiating the function or both.

Thanks in advance.

[bpat1434]

i think it's in passing the object. You may need to try it htis way:

function get_tag_cloud_html(&$freetag, $num_tags = 100, $min_font_size = 10, $max_font_size = 20, $font_units = 'px', $span_class = 'cloud_tag', $tag_page_url = '/tag/')
{

[wickdani]

I tried adding the & before the $freetag variable and I got the same "Missing argument 1 for get_tag_cloud_html()" error.

That was the only change right?

[bpat1434]

Did you do it in the funcition declaration, or in the function call? It should be in the declaration and/or the call I think....

I can't say for certain, but check up in your php.ini "allow_call_time_pass_reference" is Off.

You should be able to read more here: OO PHP @ SitePoint

[thorpe]

How do you know its not returning anything? What happens when you...

echo get_tag_cloud_html($freetag);

[wickdani]

Thanks Thorpe, that was the problem, I wasn't echo'ing the function call. It works now.

bpat1434, thanks for the OO link at SitePoint. I'm a total OO novice and that looks like a good place to brush up.