File Uploading

djwinder

This code is based upon code from a book i am using to teach myself. The code works fine if i specify a location to store the images on the harddisk i.e C:\web but i need the code to store the picture on a server (which will eventualy be the host) but for now i am using apache thus the local host referance. The 'could not copy' error occurs so i know the problem is in this path. PLEASE HELP

<?php
if ( $FILES['image'] ['name'] != "")
{
copy ( $FILES['image'] ['tmp_name'], "http://localhost/shop/" .$_FILES['image'] ['name'] ) or die ("could not copy"); //might need to remove first '/' left of shop
}
else {die(" You need to select an image");}
?>

<html><head><title>Upload Sucsessful</title></head>
<body>
upload successful
<ul>
<li>Sent: <?php echo $FILES['image'] ['name']; ?>
<li>Sent: <?php echo $FILES['image'] ['size']; ?> bytes
<li>Sent: <?php echo $_FILES['image'] ['type']; ?>
</ul>

<a href="<?php echo $_FILES['image'] ['name']; ?>">
Click here to view the file</a>
</body>
</html>

gammaster

Hi!
Try this:

// If your 'shop' directory isn`t in the web root you have to change the $newFile path.
$uploadedFile = $_FILES['image']['tmp_name'];
$newFile      = $_SERVER['DOCUMENT_ROOT'].'/'.shop/".$_FILES['image']['name'];

move_uploaded_file($uploadedFile, $newFile);

djwinder

The code now executes without error but the file location (in bold) does not work, the file is always copied to C:/ but the files name contions the location specified. for example the code below copies the file 'testFILENAME' to the C drive on the computer. Again any ideas would be greatly aprishiated.

<?php
if ( $FILES['image'] ['name'] != "")
{
copy ( $FILES['image'] ['tmp_name'], "/test" .$_FILES['image'] ['name'] ) or die ("could not copy");

}
else {die(" You need to select an image");}
?>

<a href="<?php echo $_FILES['image'] ['name']; ?>">
Click here to view the file</a>
</body>
</html>

djwinder

GAMMASTER i have tried your code but am having difficulty getting it to work with mine can you see where its falling over?

here is the php code:

<?php
if ( $_FILES['image'] ['name'] != "")
{

//( $_FILES['image'] ['tmp_name'], "/test" .$_FILES['image'] ['name'] ) or die ("could not copy");  

$uploadedFile = $_FILES['image']['tmp_name']; 
$newFile      = $_SERVER['DOCUMENT_ROOT'].'/'.shop/".$_FILES['image']['name']; 

move_uploaded_file($uploadedFile, $newFile);

}
else {die(" You need to select an image");}
?>

gammaster

Are you sure that you have set any upload_tmp_dir in your php.ini file?
You can test it like this:

   echo ini_get('upload_tmp_dir');

gammaster

And:

// Here is a typo
$newFile = $_SERVER['DOCUMENT_ROOT'].'/'.shop/".$_FILES['image']['name'];

// Have to bee
$newFile = $_SERVER['DOCUMENT_ROOT'].'/shop/'.$_FILES['image']['name'];

djwinder

typo sorted it, thank you very very much for your help saved me a few hours there at least 🙂