image upload and thumbnail generation

[djwinder]

The following code fails where i have highlighted it in red, please help.

<?php

include ("constants.inc");

$thumbw=100; //The Width Of The Thumbnails $nw
$thumbh=75; //The Height Of The Thumbnails $nh

$imagepath = "/shop/admin/images/";
$thumbpath = "/shop/admin/images/thumbs";

if ( $_FILES['image'] ['name'] != "")

{
$uploadedFile = $FILES['image']['tmp_name'];
$newFile = $SERVER['DOCUMENT_ROOT'].$GLOBALS['imagepath'].$FILES['image']['name'];
$newtempfile = $SERVER['DOCUMENT_ROOT'].$GLOBALS['thumbpath'].$_FILES['image']['name'];

}

echo('got here 1');

$image = $_FILES['image']['name'];

echo('got here 1.2');
$dimensions = GetImageSize($image); //$img

echo('got here 1.3');

$thname = "$thumbpath/$img_name";

echo('got here 1.5');

$width=$dimensions[0]; //$w
$height=$dimensions[1]; //$h

echo('got here 1.7');

$tempimage = ImageCreateFromJpeg($image);

echo('got here 1.8');
$thumb=ImageCreateTrueColor($thumbw,$thumbh);

echo('got here 1.9');
$wm = $width/$thumbw;
$hm = $height/$thumbh;

echo('got here 2');

$h_height = $thumbh/2;
$w_height = $thumbw/2;

move_uploaded_file($uploadedFile, $newFile);

echo('got here 3');

if($width > $height){

$adjusted_width = $width / $hm;
$half_width = $adjusted_width / 2;
$int_width = $half_width - $w_height;

ImageCopyResampled($thumb,$tempimage,-$int_width,0,0,0,$adjusted_width,$thumbh,$width,$height); 
ImageJPEG($thumb,$thname,95); 


echo('got here 4');

}elseif(($width < $height) || ($width == $height)){

$adjusted_height = $height / $wm;
$half_height = $adjusted_height / 2;
$int_height = $half_height - $h_height;

ImageCopyResampled($thumb,$tempimage,0,-$int_height,0,0,$thumbw,$adjusted_height,$width,$height); 
ImageJPEG($thumb,$thname,95); 


echo('got here 5');	

}else{
ImageCopyResampled($thumb,$tempimage,0,0,0,0,$thumbw,$thumbh,$width,$height);
ImageJPEG($thumb,$thname,95);

echo('got here 6');
}

move_uploaded_file($thumb, $newthumbfile);

echo('got here 7');

imagedestroy($tempimage);

echo('got here 8');
?>

[dhodge]

When files are uploaded to the server they are stored in a temporary filename.

so while

$_FILES['image']['name'] would be whatever the name of it before its uploaded

$_FILES['image']['tmp_name'] is the actual file.

[djwinder]

thanks for the quick reply. am i right in thinking that i would need to replace the line below (got here 1) to read

$image = $_FILES['image']['tmp_name'];

will the createimagefromjpeg function then take image as a valid input?

[dhodge]

I believe it will.

Are you trying to just create an image upload to a directory on the server?

If so, then all you really need to do is copy the uploaded file to a directory.

Here is a function that I use throughout my code.

 
function UploadFile($file, $path, $name)
{
$type = strtolower(substr($file["name"], strpos($file["name"], ".")));
if ($type == ".jpeg")
[INDENT]$type = ".jpg"[/INDENT] 
$filename = $path.$name.$type;
if (is_uploaded_file($file["tmp_name"]))
	{
	copy($file["tmp_name"], $filename);
	touch($filename);
	return $name.$type;
	}
else
	return false;
}

Also then I might suspect you want to have thumbnail and a larger image.

If you do then here is a script to resize a larger image. This is way better then resizing it with HTML (i.e. <img width=xx height=xx ) cuz it actually shrinks the file down so it loads faster and keeps the proportions correct.

<?php
/**
* Automatic Image Resize Script
* 
* Will take a jpeg, gif or png image and automatically resize it based on the desired width.  If
* no width is specified then it sets the width to 75.  Prints nothing on invalid image sources and 
* types.
* @package Website
*/
if (!$_GET["src"])
	$_GET["src"] = "nopic.jpg";
// Replace this with your images directory
if (!file_exists("path/to/images/".$_GET["src"]))
	$_GET["src"] = "nopic.jpg";

if (!$_GET["x"])
	{
	$x = 75;
	$size = getimagesize($src);
	}
else
	{
	$size = getimagesize($src);
	$x = $size[0];
	}
if ($size[0] > $x) 
	{
	$nx = intval ($x);
	$ny = intval ($size[1] * ($x / $size[0]));
	} 
else 
	{
	$nx = $size[0];
	$ny = $size[1];
	}
$small = imagecreatetruecolor($nx, $ny);
switch (strtolower(substr($_GET["src"], -3)))
	{
	case "gif" : 	header('Content-Type: image/gif');
					$img = imagecreatefromgif($src); 
					imagecopyresampled($small, $img, 0, 0, 0, 0, $nx, $ny, $size[0], $size[1]);
					imagedestroy($img);
					imagegif($small);
					break;
	case "jpg" : 	header('Content-Type: image/jpeg'); 
					$img = imagecreatefromjpeg($src); 
					imagecopyresampled($small, $img, 0, 0, 0, 0, $nx, $ny, $size[0], $size[1]);
					imagedestroy($img);
					imagejpeg($small,'',$q);
					break;
	default : exit();
	}	
?>

[djwinder]

at least the code was not so bad that you couldnt understand what i was attempting to do 🙂 i will have a go with the code u have provided and see how i go. Thanks very much for the help

[dhodge]

No problem.

Quick tips on how to use it.

I would find out the root path to your images folder

getcwd(); is a function that will print your current working directory
something like /home/mysite/public_html/images/

the 3 argument is the actual namve it will give the file on the server.

please not it will overwrite files without notice.

UploadFile($_FILES["image"], $image_root, $server_imagename);

If it worked it will return the filename, false if it didn't.

Lastly make sure there are write permissions to the directory you are copying the file into.

[djwinder]

i dont understand the following

if (!$GET["src"])
$GET["src"] = "nopic.jpg";
// Replace this with your images directory
if (!file_exists("path/to/images/".$GET["src"]))
$GET["src"] = "nopic.jpg";

what is the "src" and i was using $_POST is that a problem.

[dhodge]

Oh ya, so if you then want to load that image it goes like this...

<img src="image.php?src=MyPicture.gif&x=60" width="60" />

This will then load MyPicture.gif with a width of 60. Also you should set the width inside the image tag becuase it will look better on the page when it loads as apposed to not including it and having the browser wait and figure out the width.

So basically I set the script up to get the $_GET['src'] paramater then do a check to see if it is actually a file. If not there was a default picture called nopic.gif that was loaded instead.

Does that help? Is the image path part clear?

[djwinder]

to be honest this is all going over my head, my aim is to use a script to add an item (such as a tshirt) into a stock table in a mysql database, this means the full image path will be clicked on by the user in the add page and then from that path i need to generate the thumb and stick it in a thumb folder, upload the main image and stick it the image folder and stick the path of both the thumb and the main image in fields withtin the stock table of the database. I have been trying to get something like that working for nearly a week and keep hitting problems, while the code your giving is great i am having difficulty incorporating it with the aim of the above scenario