[RESOLVED] foreach () Help

goclimb

Here's some code I'm trying to get working :

$db = mysql_connect("xxx", "xxx", "xxx");
mysql_select_db("xxx",$db);
if ($Location) {
$result = mysql_query("SELECT ID, Longitude, URL, SiteName, Description FROM rv WHERE SubCategory = '$SubCat' AND Location = '$Location' AND Status <> 'HIDDEN' ORDER BY SiteName",$db);
} else {
$result = mysql_query("SELECT ID, Longitude, URL, SiteName, Description FROM rv WHERE SubCategory = '$SubCat' AND Status <> 'HIDDEN' ORDER BY SiteName",$db);
}
.
.
.
<?php
if ($myrow = mysql_fetch_array($result)) {
do {
if ($myrow["Longitude"] == "") {
printf("<LI><A HREF=\" %s \">%s</A> - \"%s\"\n", $myrow["URL"], $myrow["SiteName"], $myrow["Description"]);

} else {
printf("<LI><A HREF=\"../map_test.php?ID=%s&Cat=rv\">[Map]</A> <A HREF=\" %s \">%s</A> - \"%s\"\n", $myrow["ID"], $myrow["URL"], $myrow["SiteName"], $myrow["Description"]);
}
} while ($myrow = mysql_fetch_array($result));
} else {
echo "Sorry, no records were found!";
}
?>

Basically, when info gets pulled from the database, if there is no value for $Longitude, then the first printf gets executed, otherwise the second one does. I cannot get this to work with an if..then statement, and a while statement doesn't seem appropriate.

That leaves the foreach() statement. I'm not sure how to implement that given my code above. Can anybody provide some assistance?

Thanks!

Mark

sneakyimp

if your query is supposed to return more than one database record, then you will definitely need a while loop. otherwise you are just outputting the first record.

maybe try this:

<?php
while ($myrow = mysql_fetch_array($result)) {
  if ($myrow["Longitude"] == "") {
    printf("<LI><A HREF=\" %s \">%s</A> - \"%s\"\n", $myrow["URL"], $myrow["SiteName"], $myrow["Description"]);
  } else {
    printf("<LI><A HREF=\"../map_test.php?ID=%s&Cat=rv\">[Map]</A> <A HREF=\" %s \">%s</A> - \"%s\"\n", $myrow["ID"], $myrow["URL"], $myrow["SiteName"], $myrow["Description"]);
  }
}
?>

goclimb

The query does indeed return more than one record. I tried substituting what you had for what I had, and I get the same results.

sneakyimp

what, exactly, is wrong with the results? your original post is really vague.

goclimb

The problem is that I either get all links with a [Map] tag on them, even if there is no Longitude associated with that database entry, or I get all links without the [Map] tag, even if there should be one. It doesn't seem to be able to recognize when there is a value for $Longitude and when there isn't. That determination decides what format to present the link in.

sneakyimp

ahh....i just recognized the problem i think...

mysql_fetch_array() returns an array with numeric indices. If you replace that with mysql_fetch_assoc() it should maybe work?

goclimb

Same results unfortunately.

sneakyimp

well i would recommend that you learn how to debug your code--find out what value is in $myrow['Longitude'] and then reconsider this line:

  if ($myrow["Longitude"] == "") {

I have no idea what value might be in $myrow['Longitude']. It could be zeros which would always result in a FALSE value for that line. it was definitely empty when you were using mysql_fetch_array because that returns only numeric indices. or it could be anything depending on what your query returns.

sneakyimp

you might also consider testing like this:

if (empty($myrow['Longitude'])) {

empty() returns true if the argument is zero, the empty string ("") or NULL.

goclimb

OK...I'll work on it some more. Out of the 54 entries that I have in that table, there are only 2 with Longitude values...the rest have NULL in them.

Thanks for your help!

goclimb

You gave me some food for thought, so I went and checked what was in my db for the Longitude values. Turns out it was 0.000000 for entries with NO Longitude value, so of course my condition statement failed. When I made the adjustment based on that, my original code worked.

Stupid User Mistake.

Thanks,

Mark

sneakyimp

glad it worked out.