insert into mysql not working

djwinder

here is the code for what i thought was a simple insert however while the page refreshes it does not insert the data or show the sucess message. Can anyone tell me why?

 Change the Welcome message : 
 <br>
 <br>
 <textarea name="welcome" cols="60" rows="10"></textarea>
 <br>
 <br> 
 <input type= "submit" name="welcomebtn" value= "Add your welcome message" >

</form>

<?php

 include ("constants.inc");


   	   $welcome = $_POST['welcome'];

   $connection = mysql_connect($GLOBALS['host'],$GLOBALS['user'],$GLOBALS['pass']) or die ("couldn't connect to server");

   $db = mysql_select_db ($GLOBALS['db_name'], $connection) or die ("Unable to select the database");

   $query = "INSERT INTO settings (welcome) VALUES ('$welcome')";

   $result = mysql_query($query);

   if ($result) {echo ("Your welcome message has been updated" );} 

   mysql_close();

echo ('got here');

</body>
</html>

constants inc

<?php

$GLOBALS['db_name'] = 'dhstshop';
$GLOBALS['host'] = 'localhost';
$GLOBALS['user'] = 'root';
$GLOBALS['pass'] = 'password';
$GLOBALS['thumbw'] = 100; //The Width Of The Thumbnails
$GLOBALS['thumbh'] = 75; //The Height Of The Thumbnails
$GLOBALS['imagepath'] = "/shop/admin/images/"; //Path To Place Where Images Are Uploaded. No Trailing Slash
$GLOBALS['thumbpath'] = "/shop/admin/images/thumbs/"; //Path To Place Where Thumbnails Are Uploaded. No Trailing Slash

Quadodo

There is probably an error with the mysql, but we can't tell, because there is no else {} statement on the if { } statement, and nothing to show an error at the end of the query, try this, and find the error:

Change the Welcome message :
<br>
<br>
<textarea name="welcome" cols="60" rows="10"></textarea>
<br>
<br>
<input type= "submit" name="welcomebtn" value= "Add your welcome message" >
</form>

<?php

include ("constants.inc");

$welcome = $_POST['welcome'];

$connection = mysql_connect($GLOBALS['host'],$GLOBALS['user'],$GLOBALS['pass']) or die ("couldn't connect to server");

$db = mysql_select_db ($GLOBALS['db_name'], $connection) or die ("Unable to select the database");

$query = "INSERT INTO settings (welcome) VALUES ('$welcome')";

$result = mysql_query($query) or print(mysql_error()."<br />");

if ($result) {echo ("Your welcome message has been updated" );}
else { echo ("Sorry, read the error above to find out what is wrong.");}

mysql_close();

echo ('got here');

</body>
</html>

djwinder

the error reports that field in the db dont have default values, i will change this and see what happens. Will that error reporting code work if inserted into other scripts as i am having a hell of a time debugging my code at the mo and it would be a life saver

djwinder

one of the issues is that this message is going into a table called settings, the data within this table will be used toughout the site. Importantly i only want a single row of data to be stored in the settings table. This is because i only want the admin of the site to be able to keep one of each item at any one time (i.e paypal login name, welcome message, postage information). If alterations are to be made the existing record will need to be altered. Is their any way to specify that only one row can be stored? such as limiting the primary key to being '1'. any ideas anyone?

sab

try putting
<form>
</form>

after the <?php ?> script maybe that might work

frost110

What does your table structure look like?

What seems to be happening is that you have another field in the table that does not assign itself a default value. IE an ID that should be auto_increment or username something.

To fix this either post the table structure and let me hash it out for you OR set a defualt value for all columns in your table.

--FrosT