Help With Function Please All !!!!!!!!!!!!!

golfinggod

Hi all I have this RSS reader in XML


function RSS($page)
{
$insideitem = false;
$tag = "";
$title = "";
$description = "";
$link = "";
$date = "";
$image = "";

function startElement($parser, $name, $attrs) {
	global $insideitem, $tag, $title, $description, $link, $date, $image;
	if ($insideitem) {
		$tag = $name;
	} elseif ($name == "ITEM") {
		$insideitem = true;
	}
}

function endElement($parser, $name) {
	global $insideitem, $tag, $title, $description, $link, $date, $image;
	static $counter = 0; 
	if ($name == "ITEM" && !(++$counter > 5)) { 
	if ($name == "ITEM") {
		echo"<a class=Text-Main-Headlines href=$link><span class=Text-Main-Headlines>$title</span></a><br>";
		$title = "";
		$description = "";
		$link = "";
		$date = "";
		$insideitem = false;
	}}
}

function characterData($parser, $data) {
	global $insideitem, $tag, $title, $description, $link, $date, $image;
	if ($insideitem) {
	switch ($tag) {
		case "TITLE":
		$title .= $data;
		break;
		case "DESCRIPTION":
		$description .= $data;
		break;
		case "LINK":
		$link .= $data;
		break;
		case "DATE":
		$date .= $data;
		break;
		case "IMAGE":
		$date .= $data;
		break;
	}
	}
}

$xml_parser = xml_parser_create();
xml_set_element_handler($xml_parser, "startElement", "endElement");
xml_set_character_data_handler($xml_parser, "characterData");
$fp = fopen("$page","r")
	or die("Error reading RSS data.");
while ($data = fread($fp, 4096))
	xml_parse($xml_parser, $data, feof($fp))
		or die(sprintf("XML error: %s at line %d", 
			xml_error_string(xml_get_error_code($xml_parser)), 
			xml_get_current_line_number($xml_parser)));
fclose($fp);
xml_parser_free($xml_parser);
}

The problemis I call it twice on my page so that it can can the headlines from two seperate sites. See below

<body>
<div id="Layer1">
  <div id="Layer2"></div>
  <div id="Layer3"></div>
  <div id="Layer4"></div>
  <div id="Layer5">
    <div class="Main-Image"></div>
    <div class="Main-Headlines">

     <?php $page = "Example one"
	 RSS($page)
	  ?>

</div>  
<div class="Main-Title">Washington News - Latest WhiteHouse Headlines </div>
  </div>
  <div id="Layer6">
    <div class="Main-Image-Europe"></div>
    <div class="Main-Headlines-Europe">
	<?php $page = "Example two"
		 RSS($page)
		  ?>
 </div>  

    <div class="Main-Title-Europe">European News - Latest European Union Headlines </div>
  </div>
</div>
</body>

I recieve this error

Fatal error: Cannot redeclare startelement() (previously declared in c:\phpdev\private\currentaffairs\RssCollect.php:15) in c:\phpdev\private\currentaffairs\RssCollect.php on line 15

How can i get it so that it sends two or more seperate sites and then prints the results on seperate areas of my page?

Thanks All

crazychris

You are declaring functions inside a function. Move the other functions outside of the parent function and it should be fine.

Looks like it should be a class not a function...

niroshan

Hi,
Here try this... Like 'crazychris' says you need a class instead of a function inside a function.

Class file

class RSS
{
	var $insideitem = false;
	var $tag = "";
	var $title = "";
	var $description = "";
	var $link = "";
	var $date = "";
	var $image = "";

function startElement($parser, $name, $attrs) 
{
	global $insideitem, $tag, $title, $description, $link, $date, $image;

	if ($insideitem) 
	{
		$tag = $name;
	} 
	elseif ($name == "ITEM") 
	{
		$insideitem = true;
	}
}

function endElement($parser, $name) 
{
	global $insideitem, $tag, $title, $description, $link, $date, $image;
	static $counter = 0;
	if ($name == "ITEM" && !(++$counter > 5)) 
	{
		if ($name == "ITEM") 
		{
			echo"<a class=Text-Main-Headlines href=$link><span class=Text-Main-Headlines>$title</span></a><br>";
			$title = "";
			$description = "";
			$link = "";
			$date = "";
			$insideitem = false;
		}
	}
}

function characterData($parser, $data) 
{
	global $insideitem, $tag, $title, $description, $link, $date, $image;
	if ($insideitem) 
	{
		switch ($tag) 
		{
			case "TITLE":
			$title .= $data;
			break;
			case "DESCRIPTION":
			$description .= $data;
			break;
			case "LINK":
			$link .= $data;
			break;
			case "DATE":
			$date .= $data;
			break;
			case "IMAGE":
			$date .= $data;
			break;
		}
	}
}		  
}

php file that read the xml contents

include 'classtest.php';


$page="rssfile.xml";

$xml_parser = xml_parser_create();
$obj = new RSS();
xml_set_object($xml_parser,&$obj);
xml_set_element_handler($xml_parser, "startElement", "endElement");
xml_set_character_data_handler($xml_parser, "characterData");

$fp = fopen($page,"r") or die("Error reading RSS data.");

while ($data = fread($fp, 4096))
{
   if (!xml_parse($xml_parser, $data, feof($fp))) 
   {
	  $reason = xml_error_string(xml_REQUEST_error_code($xmlparser));
	  $reason .= xml_REQUEST_current_line_number($xmlparser);
	  die($reason);
   }
}

fclose($fp);
xml_parser_free($xml_parser);

Good luck.

Regards,
Niroshan