[RESOLVED] While loops

[Vbabiy]

Hey guys i got a question:

here is my code:

if (!$_GET['event_id']) {
			exit('I need event ID');
		}


	$db = new mysql_db();

	$sql = "SELECT * FROM rooming_list WHERE event_id ='{$_GET['event_id']}';";
	$results = $db->query($sql);
	$row = $db->fetchArray($results);

	echo '
	<link href="Css/css.css" rel="stylesheet" type="text/css">
	<form name="form1" method="post" action="input.php?input=roomlist&do=update">
	  <table width="650"  border="0" align="center" cellpadding="2" cellspacing="0" bordercolor="#000000" class="border">
	    <tr class="borderbottom">
	      <td colspan="7" nowrap class="title">Hotel Rooming List </td>
	    </tr>
	    <tr class="borderbottom">
	      <td colspan="7"><table width="100%"  border="0" cellspacing="0" cellpadding="2">
	        <tr>
	          <td class="LabelRight">Event ID: </td>
	          <td class="LabelLeft"><input name="event_id" type="text" size="30" readonly value="'.$_GET['event_id'].'"></td>
	        </tr>
	        <tr>
	          <td class="LabelRight">Hotel Name: </td>
	          <td class="LabelLeft"><input name="hotel_name" type="text" id="hotel_name" size="30" value="'.$row['hotel_name'].'"></td>
	        </tr>
	        <tr>
	          <td class="LabelRight">To:</td>
	          <td class="LabelLeft"><input name="to" type="text" id="to" size="30" value="'.$row['rm_to'].'"></td>
	        </tr>
	        <tr>
	          <td class="LabelRight">From:</td>
	          <td class="LabelLeft"><input name="from" type="text" id="from" size="30"value="'.$row['rm_from'].'"></td>
	        </tr>
	        <tr>
	          <td class="LabelRight">Date:</td>
	          <td class="LabelLeft"><input name="date" type="text" id="date" size="30"value="'.$row['rm_date'].'"></td>
	        </tr>
	        <tr>
	          <td colspan="2"><table width="71%"  border="0" cellspacing="0" cellpadding="0">
	            <tr>
	              <td width="10%" nowrap class="LabelRight">Regard -&nbsp; </td>
	              <td width="90%"><input name="regard" type="text" class="LabelLeft" id="regard" size="70"value="'.$row['rm_regard'].'"></td>
	            </tr>
	          </table></td>
	          </tr>
	        <tr>
	          <td colspan="2" class="LabelRight">Last Updated: '.date('F j, Y, g:i a',$row['TIMESTAMP']).'</td>
	        </tr>
	      </table></td>
	    </tr>
	    <tr class="Date">
	      <td nowrap>Room</td>
	      <td nowrap>Type</td>
	      <td nowrap>Name</td>
	      <td nowrap>Smoking</td>
	      <td nowrap>Friday</td>
	      <td nowrap>Saturday</td>
	      <td nowrap>Sunday</td>
	    </tr>';

		$sql = "SELECT * FROM rooming_list_rooms WHERE event_id ='{$_GET['event_id']}';";

		$results = $db->query($sql);

		while ($row = $db->fetchArray($results)) 
		{

			echo'
	   		<tr class="LabelCenterBorderedTOPANDBOTTOM">
	      	<td nowrap class="LabelCenterBorderedTOPANDBOTTOM">'.$row['room'].'</td>
	     	';
				  if ($row['type'] == 'single')
				  {
				  	echo '<td nowrap class="LabelCenterBorderedTOPANDBOTTOM"><label>
				    <input name="roomtype'.$row['room'].'" type="radio"  value="single" onClick="document.getElementById(\'name'.$row['room'].'\').style.display=\'none\';" checked>
				    Single</label>
					<label>
				    <input name="roomtype'.$row['room'].'" type="radio" value="double" onClick="document.getElementById(\'name'.$row['room'].'\').style.display = \'\';">
				    Double</label></td>';

				  	echo '
			      	<td nowrap class="LabelCenterBorderedTOPANDBOTTOM"><table width="100%"  border="0" cellpadding="2" cellspacing="0">
			        <tr>
			          <td class="LabelCenter"><input name="name'.$row['room'].'_1"  type="text" id="name'.$row['room'].'_1" value="'.$row['name1'].'"></td>
			        </tr>
			        <tr id="name'.$row['room'].'" style="display:none">
			          <td class="LabelCenter"><input name="name'.$row['room'].'_2" type="text" id="name'.$row['room'].'_2" value="'.$row['name2'].'"></td>
			        </tr>
			      </table></td>';

				  } 
				  elseif ($row['type'] == 'double')
				  {
				  	echo '<td nowrap class="LabelCenterBorderedTOPANDBOTTOM"><label>
				    <input name="roomtype'.$row['room'].'" type="radio"  value="single" onClick="document.getElementById(\'name'.$row['room'].'\').style.display=\'none\';" >
				    Single</label>
					<label>
				    <input name="roomtype'.$row['room'].'" type="radio" value="double" onClick="document.getElementById(\'name'.$row['room'].'\').style.display = \'\';" checked>
				    Double</label></td>';
				  	echo '
			      	<td nowrap class="LabelCenterBorderedTOPANDBOTTOM"><table width="100%"  border="0" cellpadding="2" cellspacing="0">
			        <tr>
			          <td class="LabelCenter"><input name="name'.$row['room'].'_1" type="text" id="name'.$row['room'].'_1" value="'.$row['name1'].'"></td>
			        </tr>
			        <tr id="name'.$row['room'].'" style="">
			          <td class="LabelCenter"><input name="name'.$row['room'].'_2" type="text" id="name'.$row['room'].'_2" value="'.$row['name2'].'"></td>
			        </tr>
			      </table></td>';

				  }


	      if ($row['smoking'] == 'yes') 
	      {
	           echo '	
		      <td nowrap class="LabelCenterBorderedTOPANDBOTTOM">
		      	<input name="smoking'.$row['room'].'" type="radio" value="yes" checked>
		        Yes
		        <input name="smoking'.$row['room'].'" type="radio" value="no">
		        No
		      </td>';

	      } 
	      elseif ($row['smoking'] == 'no') 
	      {  
	     	 echo '	
		      <td nowrap class="LabelCenterBorderedTOPANDBOTTOM">
		      	<input name="smoking'.$row['room'].'" type="radio" value="yes" >
		        Yes
		        <input name="smoking'.$row['room'].'" type="radio" value="no" checked>
		        No
		      </td>';	
	      }

	      if ($row['friday'] == 'yes') {
	      	echo '<td nowrap class="LabelCenterBorderedTOPANDBOTTOM"><input name="friday'.$row['room'].'" type="checkbox" id="friday1" value="yes" checked></td>';
	      }
	      elseif ($row['friday'] == '')
	      {
	      		echo '<td nowrap class="LabelCenterBorderedTOPANDBOTTOM"><input name="friday'.$row['room'].'" type="checkbox" id="friday1" value="no"></td>';
	      }

	      if ($row['saturday'] == 'yes') {
	      	echo '<td nowrap class="LabelCenterBorderedTOPANDBOTTOM"><input name="saturday'.$row['room'].'" type="checkbox" id="saturday" value="yes" checked></td>';
	      }
	      elseif ($row['saturday'] == '')
	      {
	      		echo '<td nowrap class="LabelCenterBorderedTOPANDBOTTOM"><input name="saturday'.$row['room'].'" type="checkbox" id="saturday" value="no"></td>';
	      } 

	      if ($row['sunday'] == 'yes') {
	      	echo ' <td nowrap class="LabelCenterBorderedTOPANDBOTTOM"><input name="sunday'.$row['room'].'" type="checkbox" id="sunday" value="yes" checked></td>';
	      }
	      elseif ($row['sunday'] == '')
	      {
	      		echo ' <td nowrap class="LabelCenterBorderedTOPANDBOTTOM"><input name="sunday'.$row['room'].'" type="checkbox" id="sunday" value="yes"></td>';
	      }      
	      echo '</tr>';      
		}
		echo '
	    <tr>
	      <td colspan="7" nowrap><input name="Submit" type="submit" class="LabelCenter" value="Submit"></td>
	    </tr>

	  </table>
	</form>
	</body>
	</html>';
?>

How come it does not excute

echo '
		    <tr>
		      <td colspan="7" nowrap><input name="Submit" type="submit" class="LabelCenter" value="Submit"></td>
		    </tr>

	  </table>
	</form>
	</body>
	</html>';

at the end of the script??

[edwardsbc]

Damn, that's hard to read. Are you sure there are no errors? Is error_reporting(E_ALL); set? I couldn't find any bracket mismatches. Is this file included by another file that perhaps could have a bracket mismatch? (I notice there are no opening HTML or BODY tags.)

[frost110]

Very Messy.

All I can say is that make sure your table rows and columns are closed properly. View the source to make sure that it is truly "NOT" displaying that data. It could be and just your HTML is poorly formatted. Perhaps an attached document would help to view it.

--FrosT

[Vbabiy]

Hey guys i know its very messy but i was wondering if you guys could give me some heads up to how i could imporve this code like maybe some articals or show me how this could be writen in a much better way...
thanks

[Wynder]

Vbabiy wrote:

Hey guys i know its very messy but i was wondering if you guys could give me some heads up to how i could imporve this code like maybe some articals or show me how this could be writen in a much better way...
thanks

There are a few options... when you're inside of a while, you can kick out of PHP and just do HTML and kick back in when needed -- it can help reduce any potential problems with quote mismatches... like:

<?php
while($row = $db->fetch_array($result)) {
?>
   This HTML occurs within the while loop.
   You can quickly insert array elements from row like this...
   <?= $row['name']; ?>
   Then break back into PHP...
<?php
}
?>

[Vbabiy]

Yeah i knew that i just never though of doing that there... And also would using a template engine like smarty help me and if so any one have any good tutorial use smarty

[Wynder]

Vbabiy wrote:

Yeah i knew that i just never though of doing that there... And also would using a template engine like smarty help me and if so any one have any good tutorial use smarty

Get it from the source: http://smarty.php.net/crashcourse.php

[Vbabiy]

Thanks