Posting to DB Problem

[monki_SF]

I've written a script to add, edit records in the db. I've got all the functions working correctly - except the add new record. I've been thru the code so many times i can't see straight - and still can't see where i messed up.

Any one with a fresh pair of eyes out there?

switch ($mode){
   	case "ADD":
		$parent_id=$HTTP_POST_VARS["cboparent"];
        $strInsert="Insert into category_master (city_id,category_name,category_name_cn,parent_id,category_fees,category_chargeable,category_address,category_buysell,category_active,category_type,category_onhomepage,category_desc,category_desc_cn)values (".
    	$strInsert=$strInsert . $strcityid .",".
    	$strInsert=$strInsert . "'" . $category_name ."',".
    	$strInsert=$strInsert . "'" . $category_name_cn ."',".
    	$strInsert=$strInsert . $parent_id .",".
    	$strInsert=$strInsert . $category_fees .",".
    	$strInsert=$strInsert . "'" . $category_chargeable ."',".
    	$strInsert=$strInsert . "'" . $category_address ."',".
    	$strInsert=$strInsert . "'" . $category_buysell ."',".
    	$strInsert=$strInsert . "'" . $category_active ."',".
    	$strInsert=$strInsert . "'" . $category_type ."',".
    	$strInsert=$strInsert . "'" . $category_onhomepage ."',".
    	$strInsert=$strInsert . "'" . $category_desc ."'".
    	$strInsert=$strInsert . "'" . $category_desc_cn ."'".
        $strInsert=$strInsert . ")";
//echo $strInsert;
//return;
		if(!($dbResult = mysql_query($strInsert, $dbLink))){
            $success = "false";
            $msgid=2;
		}else{
        	$msgid=1;
        }

  	header("Location:category_list.php?cityid=".$strcityid."&msgid=".$msgid."&id=".$category_id);
    return;
   break;
case "EDIT":
	$parent_id=$HTTP_POST_VARS["cboparent"];
    $strEdit = "update category_master set ";
    $strEdit=$strEdit . "category_name  = '" . $category_name . "',";
    $strEdit=$strEdit . "category_name_cn  = '" . $category_name_cn . "',";
    $strEdit=$strEdit . "parent_id  = " . $parent_id . ",";
    $strEdit=$strEdit . "category_fees  = " . $category_fees . ",";
    $strEdit=$strEdit . "category_chargeable  = '" . $category_chargeable . "',";
    $strEdit=$strEdit . "category_address  = '" . $category_address . "',";
    $strEdit=$strEdit . "category_buysell  = '" . $category_buysell . "',";
    $strEdit=$strEdit . "category_active  = '" . $category_active . "',";
    $strEdit=$strEdit . "category_type  = '" . $category_type . "',";
    $strEdit=$strEdit . "category_desc  = '" . $category_desc . "',";
    $strEdit=$strEdit . "category_desc_cn  = '" . $category_desc_cn . "',";
    $strEdit=$strEdit . "category_onhomepage  = '" . $category_onhomepage . "'";
    $strEdit = $strEdit . " where category_id=" . $strcatid . "";
//echo $strEdit;
//return;
        if(!($dbResult = mysql_query($strEdit, $dbLink)))
        {
            $success = "false";
            $msgid = 2;
        }else{
            $msgid = 1;
        }
        break;
		header("Location: category_list.php?cityid=".$strcityid."&msgid=".$msgid."&id=".$id);
    case "DELETE":
    		$txtCtrls = $HTTP_POST_VARS['txtCtrls'];
            $strcityid=$HTTP_POST_VARS['txtcity'];
            $id=$HTTP_POST_VARS['cbocategory'];
	        for($Ccount=1;$Ccount<= $txtCtrls;$Ccount++)
	        {
	            $chk = "chk".$Ccount;
	            if($HTTP_POST_VARS["$chk"] <> ""){
	                $Query1="delete from category_master where category_id=". $HTTP_POST_VARS["$chk"];
	                if(!($dbResult = mysql_query($Query1, $dbLink))){
	                    $msgid=2;
	                }else{
	                    $msgid=1;
	                }
	            }
	        }
    	break;
        header("Location: category_list.php?cityid=".$strcityid."&msgid=".$msgid."&id=".$id);
}

header("Location: category_list.php?cityid=".$strcityid."&msgid=".$msgid."&id=".$id);
?>

[krotkruton]

Under case "ADD", you end each line with a period instead of a semicolon.

Also, just a note, this:

$strEdit = $strEdit . " where category_id=" . $strcatid . "";

is the same as this:

$strEdit .= " where category_id=" . $strcatid . ""; 

They are the same, so you don't need to change it, but you might want to use it in the future because it compacts the code a bit. On the other hand, I usually still do things the way you do as it seems easier to understand what is actually being added for me.

[frost110]

Is register_globals turned on. If not than you need to reference the variable via $POST. You can do it 2 ways, one is to reference by index of array. $POST['varname']

The second way is to extract($_POST, EXTR_OVERWRITE); which will take all the values out of the array and assign them to variables. Along with what krot said, you can exactly that to save coding.

Another thing to try is properly format the insert string. Meaning for the column definition, do this:

column1, column2...etc

Hope this helps.

If none of those work, on the error message do this:
print mysql_error();

This will tell you where the error is coming from.

--FrosT