[RESOLVED] Help to streamline this code

daxxy

I'm working on a small template project and I was wondering how I could make this code more compact and/or better
The htm

<html><body>
<table cellpadding="0" spacepadding="0" border="0">
<tr>
<td valign=top align=left><main></td>
<td valign=top align=left><size></td>
</tr>
</table>
</body>
</html>

The vars.php

<?php

$main = 'Something here.';
$description = 'This will be textarea1.';
$cname = 'The clients name.';
$address = 'The address.';
$size = 'Size of item.';
$color = 'What color.';
$other ='Other info, this is textarea2.';


?>

The processor.php

<?php 

function template($content) {

 global $main;

   $filename = "theme.htm";

   if(!$fd = fopen($filename, "r")) {

            $error = 1;

    }

   else {

  $template = fread ($fd, filesize ($filename));

  fclose ($fd);

  $template = stripslashes($template);

  $template = str_replace("<main>", "$main", $template);

  $template = str_replace("<description>", "$description", $template);

  $template = str_replace("<cname>", "$cname", $template);

  $template = str_replace("<address>", "$address", $template);

  $template = str_replace("<color>", "$color", $template);

  $template = str_replace("<content>", "$content", $template);

  echo "$template";

} }

function home() {

global $main;

include ("themevars.php");

template("$data");

} 

switch($action) {

    default:  // default switch

    home();

    break;

}

?>

thanks

Installer

Maybe somthing along these lines:

$action = 1;
switch($action) {
    default:
        $theme_file    = 'themevars.php';
        $template_file = 'theme.htm';
        break;
}
$output = template($template_file, $theme_file);
echo $output;

function template($template_file, $theme_file) 
{
    include($theme_file);
    $template = file_get_contents($template_file);
    $template = stripslashes($template);
    foreach ($theme_arr as $key => $value) {
        $template = str_replace($key, $value, $template);
    }
    return $template;
}

$theme_arr = array('<main>'        => 'Something here.',
                   '<description>' => 'This will be textarea1.',
                   '<cname>'       => 'The clients name.',
                   '<address>'     => 'The address.',
                   '<size>'        => 'Size of item.',
                   '<color>'       => 'What color.',
                   '<other>'       => 'Other info, this is textarea2.');

daxxy

Thanks for the tips. I get an error on your code though.

   

Fatal error: Cannot redeclare template() (previously declared in /home/xxxx/public_html/demo/test/tplesystm/themeproc.php:3) in /home/xxx/public_html/demo/test/tplesystm/themevars.php on line 13

:bemused:

Installer

That's an error in your code. You have the template function inside two files, the main one and the include one. Remove it from the include file. The code I posted is all that's needed for those two files.

madwormer2

Instead of

foreach ($theme_arr as $key => $value) {
    $template = str_replace($key, $value, $template);
}

It's easier to use
$template = str_replace(array_keys($theme_arr), array_values($theme_arr), $template);

No more loops 😉

daxxy

okay so now I'm confused. I should have 3 pages.
Page 1 is theme.htm
Page 2 is themevars.php
Page 3 is this

<?php 

function template($content) {

 global $main;

   $filename = "theme.htm";

   if(!$fd = fopen($filename, "r")) {

            $error = 1;

    }

   else {

  $template = fread ($fd, filesize ($filename));

  fclose ($fd);

  $template = stripslashes($template);

  $template = str_replace("<main>", "$main", $template);

  $template = str_replace("<content>", "$content", $template);

  echo "$template";

} }

function home() {

global $main;

template("$data");

} 

$action = 1; 
switch($action) { 
    default: 
        $theme_file    = 'themevars.php'; 
        $template_file = 'theme.htm'; 
        break; 
} 
$output = template($template_file, $theme_file); 
echo $output; 

function template($template_file, $theme_file) 
{  

    $template = file_get_contents($template_file); 
    $template = stripslashes($template); 
    $template = str_replace(array_keys($theme_arr), array_values($theme_arr), $template);

return $template;

}

?>

or am I all screwed up? :bemused:

Installer

Use the first code block I posted instead of "this". Use the second as "themevars.php". Use the html you have in your first post as "theme.htm". It'll work, as far as it goes. You'll need to add more to make a complete page, of course. And use mw's suggestion.

daxxy

It's amazing how things work the first time, after you take a break from reading and fiddling with the code LOL. Thanks again! Now on to the next piece of the project. A form to edit the vars page where I can add/delete vars, and a form to edit the template files. I don't want to load the form fields in a text area but back into the original fields. 😃

daxxy

Forgot to mark this resolved.