The right variable is not being passed

blaster_master

Take a look at the following:

while ($myrow = pg_fetch_array($result))
{
  ... some php ...
  echo "Username: ".$myrow["username"]."<br>";
  $internal_username = $myrow["username"];
  ... some php ...
  if ($myrow["status"]==0) {
    echo "<a href='users.php?do=activate'>Activate</a><br><br>";
  }
  else{
    echo "<br>";}
}

if ( $do == "activate" )
{
echo $internal_username;
}

So lets say my db got 10 users. The above code as you may tell searches through the database (the SQL code is not included) and displays them all 10. At the bottom of each entry there is a link "Activate" whom when pressed should echo out the proper user. The above code however always spits out the last entry (which I know why). What I don't know is how to fix it! Any help would be appreciated.

vaaaska

In the past when I had problems with while I switched the loop to a do/while and it helped. do/while checks at the end instead of at the beginning so you'll most certainly get your last result (but sometimes they will produce a blank result too).

However, I always package things up into arrays so I haven't used a while or do/while for a few years now...

Weedpacket

Um, define "proper user". What you need is some way of identifying who you mean (ID number, say), and putting that into the link along with the "activate" message.

crazychris

You do not identiy which user you are goinf to activate

echo "<a href='users.php?do=activate'>Activate</a><br><br>";

and even if you did, you updated the variable on each row read

$internal_username = $myrow["username"];

so it's value is always going to be the last one you read.

blaster_master

Thanks everyone, and sorry for the delay...
So I changed this:

echo "<a href='users.php?do=activate&id=".$internal_username."'>Activate</a><br><br>";

The links appear correctly, but how do I implement the 'if' part?

Plasma

if (isset($_GET['do']) && $_GET['do'] == 'activate')
	$query = "select * from users where id = " . intval($_GET['id']);
	$result = mysql_query($query);
	$myrow = pg_fetch_array($result);
	echo "Activate user: " . $myrow['username'];
} else {
	while ($myrow = pg_fetch_array($result))
	{
  	... some php ...
  	echo "Username: ".$myrow["username"]."<br>";
  	$internal_username = $myrow["username"];
  	... some php ...
  	if ($myrow["status"]==0) {
    		echo "<a href='users.php?do=activate&id=" . $myrow['id'] . "'>Activate</a><br><br>";
  	} else {
    		echo "<br>";}
	}
}

As an example - Just select the appropriate row you need.

blaster_master

Very, very nice! Thanks.