Db class

[lwq]

I have written a class used for extraction of data, but somehow, the part about "sql_select_db" doesn't return a proper error msg if there is an error

<?php
//mysql db
class database{
	//db connection
	function sql_connect($dbhost,$dbuser=null,$dbpass=null){
		$link = mysql_connect($dbhost,$dbuser,$dbpass);
		//check if able to connect to db
		if($link != false){
			return true;
			return $link;
		}
		elseif($link == false){
			$this->sql_error();
		}
	}
	//db error handling
	function sql_error($critical=null){
		if($critical == true){
			print"Copy the following and alert the Administrator at weiqiang[at]gmail[dot]com . <br/>";
			die(print('Critical Error:(MySQL says)' . mysql_error() . '<br/>Sql Error:' . mysql_errno()));
		}
		else{
			print"Copy the following and alert the Administrator at weiqiang[at]gmail[dot]com . <br/>";
			die(print('Error:(MySQL says)' . mysql_error() . '<br/>Sql Error:' . mysql_errno()));
		}
	}
	//db select
	function sql_select_db($dbname=null){
		$connect = mysql_select_db($dbname);
                if($connect != false){
                        return true;	
               }
               else{
                       $this->sql_error();
               }
	}
	//end db connection
	function sql_close($link_ind=null){
		mysql_close($link_ind);
	}
}
?>

[nemonoman]

[man]mysql_connect[/man]

Should be:
$link = mysql_connect($dbHOST,$dbuser,$dbpass); <<//HOST not dbname

if($line==false), it means you are not logged in.
If you are trying to log into the MySQL server with the dbname, chances are you are consistently failing.

You select your database ONCE LOGGED IN,

$dbselection=mysql_select_db($dbname);

if($dbselection==false), it means you haven't successfully selected the database.

[lwq]

oh, I didn't quite notice that.... thanks for reminding.
but, the problem actual problem is not only that, i have problem getting the mysql_connect to display the error when there is one.

[nemonoman]

Sorry I didn't realize that your broken code was not the problem. Please identify all other specific mistakes in your code that you want me to ignore.

For example, do want me to note the difference between:
'false'

and

false

HINT: mysql_select_db doesn't return a string 'false' as an error.

Perhaps this is another problem that isn't the problem?

[frost110]

Also use [ php ] [ /php ] without the spaces when posting code. People will be more apt to help you out.

--FrosT

[lwq]

Ok sure,I didn't notice that too,I have edited my post and placed the edited version there.However, the problem is that the function sql_select_db ,does not return a proper error message using sql_error.

[nemonoman]

There are many db management scripts available. Why are you doing this? If you haven't bothered to check the manual to see that an error is NOT returned, nor proofread and checked your code, why are your asking us?

Having logged in, this code works:

        $db = mysql_select_db($thedb);
        if (!$db) {
            echo "Could not select the database <B>'$thedb'</b>.";
            exit;
        }

I leave to leave to you the adapating of this code to your object.

[lwq]

I am absolutely sorry.The reason why I want to build my own because I do not need so many function types, and those that I need, then i put it down.This saves my space and bandwith coz i don't have lots of them with my host.
I don't understand the part of "logged in" in your first reply.

You select your database ONCE LOGGED IN,

$dbselection=mysql_select_db($dbname);

if($dbselection==false), it means you haven't successfully selected the database.

Now I understand that.... sorry for you to repeat what you have posted. :o