<URGENT!> Unknown problem! already spent 2hour trying to solve it! <help me :( >

phpDumbo

I am getting this error

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/testweb/milad/Seagrant/include/login.inc.php:7) in /var/www/html/testweb/milad/Seagrant/include/login.inc.php on line 36

I dont understand the problem, and i looked it up in google but that did not help

and here my code, I have no idea what to do

<?php include("connect.inc.php"); session_start(); ?>
<HTML>
	<head><title>Login</title></head>

<body>

	<?php


		if($_POST["submit"])
		{
			$user = $_POST["user"];
			$password = $_POST["password"];

			echo $user,$password;

			if(!$user OR !$password)
			{
				$error = "<b>Please enter a User AND Password</b>";
			}
			else
			{
				$query = "SELECT * FROM AuthorizedUsers WHERE username = '" . trim($user) . "' AND password = '" . trim($password) . "'";

				$queryresutl = mysql_query($query) or Print(mysql_error());

				if(mysql_affected_rows() != 1)
				{
					$error = "<font color=\"#FF0000\">The user and/or password you entered are incorrect. Please try again.</font>";
				}
				else
				{
					$_SESSION["user"] = $user;
					$_SESSION["password"] = $password;

					header("Location: ../cms/index.php");
				}
			}

		}
	?>
	<div align="center">

	<table>
		<tr><td colspan="4"><b><font size="5">Please Login</font></b></td></tr>
		<tr><td colspan="4"><?php echo $error; ?></td></tr>

		<form method="POST">
			<tr><p><td>User:</td><td><input type="text" name="user" value=""></td></p></tr>
			<tr><p><td>Password:</td><td><input type="password" name="password" value=""></td></p></tr>
			<tr><p><td><input type="submit" name="submit" value="Login"></td></p></tr>
		</form>
	</div>


</body>
<HTML>

frost110

When you make a header call there cannot be any thing printed to the page.

<?php include("connect.inc.php"); session_start(); ?>
<HTML>
    <head><title>Login</title></head>

<body>

Will throw an error if you make any type of header call after that. Such as the Location redirect header. Instead put that code in this spot

<?php include("connect.inc.php"); session_start();


        if($_POST["submit"])
        {
            $user = $_POST["user"];
            $password = $_POST["password"];

            echo $user,$password;

            if(!$user OR !$password)
            {
                $error = "<b>Please enter a User AND Password</b>";
            }
            else
            {
                $query = "SELECT * FROM AuthorizedUsers WHERE username = '" . trim($user) . "' AND password = '" . trim($password) . "'";

                $queryresutl = mysql_query($query) or Print(mysql_error());

                if(mysql_affected_rows() != 1)
                {
                    $error = "<font color=\"#FF0000\">The user and/or password you entered are incorrect. Please try again.</font>";
                }
                else
                {
                    $_SESSION["user"] = $user;
                    $_SESSION["password"] = $password;

                    header("Location: ../cms/index.php");
                }
            }

        }
    ?>
<HTML>
    <head><title>Login</title></head>

<body>

    <div align="center">

    <table>
        <tr><td colspan="4"><b><font size="5">Please Login</font></b></td></tr>
        <tr><td colspan="4"><?php echo $error; ?></td></tr>

        <form method="POST">
            <tr><p><td>User:</td><td><input type="text" name="user" value=""></td></p></tr>
            <tr><p><td>Password:</td><td><input type="password" name="password" value=""></td></p></tr>
            <tr><p><td><input type="submit" name="submit" value="Login"></td></p></tr>
        </form>
    </div>


</body>
<HTML>

--FrosT

phpDumbo

i did what you said and its still give me the error, but now it gives me this error

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/testweb/milad/Seagrant/include/login.inc.php:9) in /var/www/html/testweb/milad/Seagrant/include/login.inc.php on line 30

frost110

If this code:

                    $queryresutl = mysql_query($query) or Print(mysql_error());

prints out the sql error that will throw an error. Remember, no output can be printed until after the header is called. This will cause errors.

So if anywhere in the code above, IE connect.inc.php something is printed to the browser that will cause an error in the header redirect.

Best practice to do is if there is an error, eiither log it to the DB, kill the script or re-direct to an error page with that error message.

     echo $user,$password;

That is the bad statement and is causing the error. Look at the line numbers. IE Line 9 (which was that echo statement). Usually those help to find the errors.

output started at /var/www/html/testweb/milad/Seagrant/include/login.inc.php:9) in /var/www/html/testweb/milad/Seagrant/include/login.inc.php on line 30

Line 30 is where the error was thrown, line 9 is where the output was started. That gives the exact location of the error.

--FrosT

phpDumbo

ok it seems to work but now im running into another weird problem

it does not seem to understand this statment in the header "../cms/index.php"

im trying to go up one directory then to the cms folder where the index file is.

but it does not seem to understand it. what is the correct syntax for that?

 header("Location: ../cms/index.php");

does not work

frost110

No the location uses the full path, IE: http://www.yoursite.com/cms/index.php

--FrosT