The day register_globals broke my site

steve34

A site that I have developed using simple PHP has now stopped working since the hosting company disabled register_globals.

This is the website: http://www.markfennell.co.uk/gallery.php

If you click on the different thumbnails you can see that the querystring chages, which should change the image on the left hand side, but it has stopped working.

This is my code at the top of the page:

<?php
$link = $_GET['gallery&art'];
if ( $art == "" & $gallery == "" ) {
$art = '1';
$gallery = '1';
}
?>

This is the code foe the left hand side (big) image:

And this is the code for the thumbnails:

<?
$link = $GET['gallery'];
if ( $gallery == "1" ) {
$art = array (1,2,3,4,5,6,7,8,9,10,11,12);
foreach ( $art as $val )
print "<a href='gallery.php?gallery=1&art={$val}'><img src='art/{$val}sm.jpg' alt='Click to see full image' border='0'></a>";
} else if ( $gallery == "2" ) {
$art = array (24,13,14,15,16,17,20,22,23,25);
foreach ( $art as $val )
print "<a href='gallery.php?gallery=2&art={$val}'><img src='art/{$val}_sm.jpg' alt='Click to see full image' border='0'></a>";
}
?>

Any ideas on how to fix it?

Thanks
Steve

StevenJ

Did this code ever work?

<?php
$link = $_GET['gallery&art'];
if ( $art == "" & $gallery == "" ) {
$art = '1';
$gallery = '1';
}
?>

While I am no php expert, I'd sepperate the variables anyway to

<?php
$gallery = $_GET['gallery']  ;
$art = $_GET['art'] ;
if ( $art == "" || $gallery == "" ) {
$art = '1';
$gallery = '1';
}
?>

note I have change the if ( $art == "" & $gallery == "" ) to if ( $art == "" || $gallery == "" ). What would happen if a user typed in their own URL where the gallery = 1 but there was no value for art?

There is also another problem with yout gallery.php. for example - what would happen if the user types the URL

http://www.markfennell.co.uk/gallery.php?gallery=3&art=12

I know this doesn't exist - but the user might not, and what would this display?

further down gallery.php

$link = $_GET['gallery'];
if ( $gallery == "1" ) {

here you assign the value of 'gallery' to $link

but then you check the value of $gallery.

try

$gallery = $_GET['gallery'];
if ( $gallery == "1" ) {

hope this helps.

steve34

Thanks for the reply Steven.

That has seemed to fix it: http://www.markfennell.co.uk/gallery.php

Althought when I changed the bottom amend you mentioned:

$link = $_GET['gallery']; 
if ( $gallery == "1" ) {

$gallery = $_GET['gallery']; 
if ( $gallery == "1" ) {

This stopped the thumbnails loading so I have chnaged it back and it's all working now.

Thanks again
Steve