PHP edit DB records - not working

sliquid

Im trying to make a page that i can edit individual records from my database on. The following is part of the code for the page that passes along the variable.

When someone hits the edit button for one of teh records, the correct page opens(cust_edit.php) and the url reflects the customer ID of that record (i.e. sliquid.com/protected/cust_edit.php?customerID=xxx)

$search_results .= "  

<tr align=center bgcolor=".$color.">  

<td><font face=\"Tahoma\" size=\"1\">$row[firstname]</font></td>  

<td><font face=\"Tahoma\" size=\"1\">$row[lastname]</font></td>  

<td><font face=\"Tahoma\" size=\"1\">$row[city]</font></td>  

<td><font face=\"Tahoma\" size=\"1\">$row[state]</font></td>  

<td><font face=\"Tahoma\" size=\"1\"><a href=\"mailto:$row[email]\">$row[email]</a></font></td>  

<td><font face=tahoma size=1><form action='cust_edit.php'><input type='hidden' name='customerID' value='$row[customerID]'><input type='submit' value='Edit'></form></font></td> 
</tr>";

OK, so that is working correctly from what I can tell. So now heres the page that grabs the ID, and lets me edit the record.
Im trying to keep it simple until it works, so theres only some of the echo code there.

<?php 
 ini_set('error_reporting', E_ALL);  

 ini_set('display_errors', 'On'); 

include("dbconnection.php"); 
$id=$_GET['customerID'];  

$result = odbc_query("SELECT * FROM customers WHERE customerID='$id' ",$cnx);  

     while($myrow = odbc_fetch_assoc($result))  

             {  

echo"  

$firstname= $row[firstname];   

$lastname= $row[lastname];   

$address1= $row[address1];   

$address2= $row[address2];   

$city= $row[city];   

$state= $row[state];   

$zip= $row[zip];   

$email= $row[email];   

$referral= $row[referral];   

$lubricant= $row[lubricant];    


<!-- Your Form Stuff here -->  

<input type=\"hidden\" name=\"customerID\" value=\"<? echo $id; ?>\">  

    First Name:<br>   

    <input type=\"text\" name=\"firstname\" value=\"<? echo $firstname; ?>\">  

    <br>  

    Last Name:<br>    

<input type=\"text\" name=\"lastname\" value=\"<? echo $lastname; ?>\"> 


"  

}  

?>

all i get when I hit submit on the previous page is this page, blank, with no error reported. Viewing source shows me nothing either, just
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=windows-1252"></HEAD>
<BODY></BODY></HTML>

any ideas?

mrmigu

what is the script that you are sending this data to?

sliquid

the second one posted above it the script the info is passed along to.

the first one is just partial of the script that passes it along, it shows the form action to be cust_edit.php

the second posted IS cust_edit.php

mrmigu

you have the db results going to $myrow but are trying to get the values from $row

sliquid

I thought that would have done it, but nothing has changed.

<?php
 ini_set('error_reporting', E_ALL); 
 ini_set('display_errors', 'On');

include("dbconnection.php");
$id=$_GET['customerID']; 
echo "$id";
$result = odbc_query("SELECT * FROM customers WHERE customerID='$id' ",$cnx); 
	 while($row = odbc_fetch_assoc($result)) 
             { 
echo" 
$firstname= $row[firstname];  

$lastname= $row[lastname];  

$address1= $row[address1];  

$address2= $row[address2];  

$city= $row[city];  

$state= $row[state];  

$zip= $row[zip];  

$email= $row[email];  

$referral= $row[referral];  

$lubricant= $row[lubricant];   


<!-- Your Form Stuff here --> 
<input type=\"hidden\" name=\"customerID\" value=\"<? echo $id; ?>\"> 
    First Name:<br>  

    <input type=\"text\" name=\"firstname\" value=\"<? echo $firstname; ?>\"> 
    <br> 
    Last Name:<br>   

<input type=\"text\" name=\"lastname\" value=\"<? echo $lastname; ?>\">


";
}
?>

Also, Ive been clued in that since there is only one record to match the ID, there is no need for a loop. My attempts at removing the loop from this keep giving me a blank page.

ale1981

Have you tried inserting the '' inside the array outputs?


$firstname= $row['firstname'];  

$lastname= $row['lastname'];  

$address1= $row['address1'];  

$address2= $row['address2'];  

$city= $row['city'];  

$state= $row['state'];  

$zip= $row['zip'];  

$email= $row['email'];  

$referral= $row['referral'];  

$lubricant= $row['lubricant'];

sliquid

that just takes me back to a blank page with no error.

Heres the latest - odbc_query is wrong, should be odbc_do
odbc_fetch_assoc should be odbc_fetch_array

so I changed both of them, and heres the error im getting now.

727
Warning: odbc_do(): supplied argument is not a valid ODBC-Link resource in d:\inetpub\sliquid\wwwRoot\protected\cust_edit.php on line 8

Warning: odbc_fetch_array(): supplied argument is not a valid ODBC result resource in d:\inetpub\sliquid\wwwRoot\protected\cust_edit.php on line 9

heres the code:

<?php
 ini_set('error_reporting', E_ALL); 
 ini_set('display_errors', 'On');

include("dbconnection.php");
$id=$_GET['customerID']; 
echo "$id";
$result = odbc_do("SELECT * FROM customers WHERE customerID='$id' ",$cnx); 
	 while($row = odbc_fetch_array($result)) 
             { 
echo" 
$firstname= $row[firstname];  

$lastname= $row[lastname];  

$address1= $row[address1];  

$address2= $row[address2];  

$city= $row[city];  

$state= $row[state];  

$zip= $row[zip];  

$email= $row[email];  

$referral= $row[referral];  

$lubricant= $row[lubricant];   


<!-- Your Form Stuff here --> 
<input type=\"hidden\" name=\"customerID\" value=\"<? echo $id; ?>\"> 
    First Name:<br>  

    <input type=\"text\" name=\"firstname\" value=\"<? echo $firstname; ?>\"> 
    <br> 
    Last Name:<br>   

<input type=\"text\" name=\"lastname\" value=\"<? echo $lastname; ?>\">


";
}
?>

any ideas on how I can take out the loop? my attempts are failing miserably.

mrmigu

i dont think its a problem with the loop. the loop would either go through 1 or 0 times, depending on whether or not there is a customer with that ID.

It sounds like the problem is with the connection to the databse, $cnx
are you connecting with odbc_connect()?

what does dbconnection.php look like? (without db location/login info obviously😉)

sliquid

here it is. but it works fine, sicne the search page uses the same include.

<?php
$cnx = odbc_connect( 'records_db' , 'Admin', '******' );
    if (!$cnx) {
        Error_handler( "Error in odbc_connect" , $cnx );
    }

?>

mrmigu

resource odbc_do ( resource conn_id, string query )

your parameters are reversed

sliquid

i got rid of the odbc_do:
heres what it looks like now.

<?php
 ini_set('error_reporting', E_ALL); 
 ini_set('display_errors', 'On');


include("dbconnection.php");
$id=$_GET['customerID']; 
echo "$id";
$query = "SELECT * FROM customers WHERE customerID= '$id' ";
$result = odbc_exec($cnx, $query); 
     while($row = odbc_fetch_array($result)) 
             { 
$row['firstname'] = $firstname;
$row['lastname'] = $lastname;
$row['address1'] = $address1;
$row['address2'] = $address2;
$row['city'] = $city;
$row['state'] = $state;
$row['zip'] = $zip;
$row['email'] = $email;
$row['referral'] = $referral;
$row['lubricant'] = $lubricant;

echo"  

$firstname= $row[firstname];   

$lastname= $row[lastname];   

$address1= $row[address1];   

$address2= $row[address2];   

$city= $row[city];   

$state= $row[state];   

$zip= $row[zip];   

$email= $row[email];   

$referral= $row[referral];   

$lubricant= $row[lubricant];    


<!-- Your Form Stuff here -->  

<input type=\"hidden\" name=\"customerID\" value=\"<? echo $id; ?>\">  

    First Name:<br>   

    <input type=\"text\" name=\"firstname\" value=\"<? echo $firstname; ?>\">  

    <br>  

    Last Name:<br>    

<input type=\"text\" name=\"lastname\" value=\"<? echo $lastname; ?>\"> 


"; 
} 
?>

and the error is

727
Warning: odbc_exec(): SQL error: [Microsoft][ODBC Microsoft Access Driver] Data type mismatch in criteria expression., SQL state 22005 in SQLExecDirect in d:\inetpub\sliquid\wwwRoot\protected\cust_edit.php on line 10

Warning: odbc_fetch_array(): supplied argument is not a valid ODBC result resource in d:\inetpub\sliquid\wwwRoot\protected\cust_edit.php on line 11

sliquid

i got rid of the odbc_do:
heres what it looks like now.

<?php
 ini_set('error_reporting', E_ALL); 
 ini_set('display_errors', 'On');


include("dbconnection.php");
$id=$_GET['customerID']; 
echo "$id";
$query = "SELECT * FROM customers WHERE customerID= '$id' ";
$result = odbc_exec($cnx, $query); 
     while($row = odbc_fetch_array($result)) 
             { 
$row['firstname'] = $firstname;
$row['lastname'] = $lastname;
$row['address1'] = $address1;
$row['address2'] = $address2;
$row['city'] = $city;
$row['state'] = $state;
$row['zip'] = $zip;
$row['email'] = $email;
$row['referral'] = $referral;
$row['lubricant'] = $lubricant;

echo"  

$firstname= $row[firstname];   

$lastname= $row[lastname];   

$address1= $row[address1];   

$address2= $row[address2];   

$city= $row[city];   

$state= $row[state];   

$zip= $row[zip];   

$email= $row[email];   

$referral= $row[referral];   

$lubricant= $row[lubricant];    


<!-- Your Form Stuff here -->  

<input type=\"hidden\" name=\"customerID\" value=\"<? echo $id; ?>\">  

    First Name:<br>   

    <input type=\"text\" name=\"firstname\" value=\"<? echo $firstname; ?>\">  

    <br>  

    Last Name:<br>    

<input type=\"text\" name=\"lastname\" value=\"<? echo $lastname; ?>\"> 


"; 
} 
?>

and the error is

Warning: odbc_fetch_array(): supplied argument is not a valid ODBC result resource in d:\inetpub\sliquid\wwwRoot\protected\cust_edit.php on line 11