[RESOLVED] problems deleting from DB

ale1981

Hi, I have this script which 'should' delete all teams, players from a league associated with it, it deletes the league and any teams in it, but doesnt delete any of the players inside the teams;

		$db->sql_query("DELETE FROM leagues WHERE id='$id'",false,__FILE__,__LINE__);
		$db->sql_query("DELETE FROM teams WHERE league='$id'",false,__FILE__,__LINE__);
		$result = $db->sql_query("SELECT id FROM teams WHERE league='$id'",false,__FILE__,__LINE__);
		$team = $db->sql_fetchrow($result);
		$team = $team['id'];
		$db->sql_query("DELETE FROM players WHERE team='$team'",false,__FILE__,__LINE__);
		url_redirect(adminlink('&amp;mode=Leagues'));

Thanks in advance

mrmigu

youve got ,false,FILE,LINE); in your other queries, should you have it in that one too?

ale1981

sorry, that was in there originally, i was testing without, doesnt work, with or without.

mrmigu

you are deleting the teams from the database before you get their ids, so there is no id to get
also, you should probably have a while loop to delete all the players, like:

 while($teams = $db->sql_fetchrow($result)){
        $team = $teams['id'];
        $db->sql_query("DELETE FROM players WHERE team='$team'",false,__FILE__,__LINE__);
}

ale1981

It still doesnt work 🙁

My code is now;

$db->sql_query("DELETE FROM leagues WHERE id='$id'",false,__FILE__,__LINE__);
$result = $db->sql_query("SELECT id FROM teams WHERE league='$id'",false,__FILE__,__LINE__);
	while($teams = $db->sql_fetchrow($result)){
		$team = $teams['id'];
		$db->sql_query("DELETE FROM teams WHERE league='$id'",false,__FILE__,__LINE__);
	}
$db->sql_freeresult($result);
$result = $db->sql_query("SELECT id FROM teams WHERE league='$id'",false,__FILE__,__LINE__);
	while($players = $db->sql_fetchrow($result)){
		$players = $players['id'];
		$db->sql_query("DELETE FROM players WHERE team='$players'",false,__FILE__,__LINE__);
	}
$db->sql_freeresult($result);
url_redirect(adminlink('&amp;mode=Leagues'));

ale1981

Sorry! I re read your post mrmigu and realised what you said! I was deleting the teams before the script had a chance to get the ids of the players! All working now after placing the queries in a different order!

Thanks.