Image Creation

[ezkial318]

I have created this simple script but i am afraid that there may be a better way and that there may be leftover temp files. If someone knows what each function is doing exactlly that would be a big help.

$pic ='Blue hills.jpg'; // start image
$loc='thumbs/'; // location to write new file
$new_name='newthumb.jpg'; // new name for image
$new_w=200; // maximum width of the new image

create_image($pic,$loc,$new_name,$new_w); // call function

function create_image($pic,$loc,$new_name,$new_w)
{

$im = imagecreatefromjpeg($pic);
$orwidth=imagesx($im); // get original width
$orheight=imagesy($im); //get original height
$ratio = $orwidth/$orheight; // calc image ratio
$new_h = round($new_w/$ratio,0); // calc new height keeping ratio of original
$new_image=ImageCreateTrueColor($new_w,$new_h);
imagecopyresized($new_image,$im,0,0,0,0,$new_w,$new_h,$orwidth,$orheight);
imagejpeg($new_image,$loc.$new_name,20);
imagedestroy($new_image);
}

[bpat1434]

$im = imagecreatefromjpeg($pic);
$orwidth=imagesx($im); // get original width
$orheight=imagesy($im); //get original height
$ratio = $orwidth/$orheight; // calc image ratio
$new_h = round($new_w/$ratio,0); // calc new height keeping ratio of original
$new_image=ImageCreateTrueColor($new_w,$new_h);
imagecopyresized($new_image,$im,0,0,0,0,$new_w,$new_h,$orwidth,$orheight);
imagejpeg($new_image,$loc.$new_name,20);
imagedestroy($new_image);

Well, these do the following:

1. Create an image handler (used for subsequent references) based off of base picture $pic.
   [indent][man]imagecreatefromjpeg[/man][/indent]

2. Get's the original widht & height of image
   [indent][man]imagesx[/man]
   [man]imagesy[/man][/indent]

3. Get the image ratio (width / height)

4. Generate a new height value (rounded) using ratio previously calculated

5. Create a new image of new height & width
   [indent][man]imagecreatetruecolor[/man][/indent]

6. copy the previous image to the new image, and resize it to the new width & height
   [indent][man]imagecopyresized[/man][/indent]

7. Export the new image to the file name
   [indent][man]imagejpeg[/man][/indent]

8. Destroy the image handler (no longer needed since we've written the new image)
   [indent][man]imagedestroy[/man][/indent]

I would say you do have a stray image handler ($im) that you should destroy at the end of the function. But other than that, there's no "stray" images and what not.

[ezkial318]

Thank you so much. I had the feeling something was wrong i just couldnt see it.