error on registering

Trev333

hi i decided to try a tutorial at xentrik.net for my login scritp

this is diffrent one to what i was asking questions about from other day

i get a error

Could not insert data because Incorrect integer value: 'NULL' for column 'id' at row 1


<html><head>
<title>User Registration</title>
</head><body>

<form action="register.php" method="post">
Pick a Username: <input type="text" name="username" size="20"><br>
Pick a Password: <input type="password" name="password" size="20"><br>
<input type="submit" value="Sign Up">
</form>

</body></html>

<?php

include("config.php");

// connect to the mysql server
$link = mysql_connect($server, $db_user, $db_pass)
or die ("Could not connect to mysql because ".mysql_error());

// select the database
mysql_select_db($database)
or die ("Could not select database because ".mysql_error());

// check if the username is taken
$check = "select id from $table where username = '".$_POST['username']."';";
$qry = mysql_query($check) or die ("Could not match data because ".mysql_error());
$num_rows = mysql_num_rows($qry);
if ($num_rows != 0) {
echo "Sorry, there the username $username is already taken.<br>";
echo "<a href=register.html>Try again</a>";
exit;
} else {

// insert the data
$insert = mysql_query("insert into $table values ('NULL', '".$_POST['username']."', '".$_POST['password']."')")
or die("Could not insert data because ".mysql_error());

// print a success message
echo "Your user account has been created!<br>";
echo "Now you can <a href=login.html>log in</a>";
}

?>

btw i have updated my server to php 5 iis 6 and mysql 5 if that helps cus i thought that might b the prob

hopw some one can help thanks in advance Trev

pyro3k

try removing the quotes around 'NULL' so it looks like NULL

Trev333

thanks for that that got rid of the error however it created a new error

it now fills the user name stright in even if blank and creates a user i need to get it to waite while the user fill in the info any ideas?

pyro3k

ok if i get you correctly you mean that even if the user leaves the forms blank it still creates a new user when entered?

if that is the case then you can validate the fields before the insert

if (isset($_POST['username']) and isset($_POST['password'])) 
{
	$check = "select id from $table where username = '".$_POST['username']."';";
	$qry = mysql_query($check) or die ("Could not match data because ".mysql_error());
	$num_rows = mysql_num_rows($qry);
	if ($num_rows != 0) {
	echo "Sorry, there the username $username is already taken.<br>";
	echo "<a href=register.html>Try again</a>";
	exit;
	} else {

// insert the data
$insert = mysql_query("insert into $table values ('NULL', '".$_POST['username']."', '".$_POST['password']."')")
or die("Could not insert data because ".mysql_error());

// print a success message
echo "Your user account has been created!<br>";
echo "Now you can <a href=login.html>log in</a>";
}
}

Trev333

thanks pyro3k thats was perfect runs like a dream now

just make me wonder who wrote the tutorial in 1st place lol

thanks again Trev

pyro3k

your welcome, glad it works

Trev333

hope this not too much but was just wondering how to encrpt the password

i have been trying useing the mysql password function or the md5 thing just carnt quite get the syntax right alway puts the same hash in the database

    

// insert the data
$insert = mysql_query("insert into $table values (NULL, '".$_POST['username']."', '".$_POST['MD%('password')']."')")
or die("Could not insert data because ".mysql_error());

    

    // insert the data
    $insert = mysql_query("insert into $table values (NULL, '".$_POST['username']."', '".$_POST['password('password')']."')")
    or die("Could not insert data because ".mysql_error());

but dont work am i doing some thing simple wrong?

hopw not been a pain Trev

pyro3k

try

$insert = mysql_query("insert into $table values (NULL, '".$_POST['username']."', '".MD5($_POST['password'])."')")
    or die("Could not insert data because ".mysql_error());

$username = $_POST['username'];

$password = md5($_POST['password']);

$insert = mysql_query("insert into $table values (NULL, '".$username."', '".$password."')")
    or die("Could not insert data because ".mysql_error());

Trev333

thanks again i dint think of that way round lol ur the man

thanks again hope not been too much of a pain trev