[RESOLVED] dropdown not selecting from db

[ale1981]

Can somebody please guide me in the right direction, this code works fine, but when I then goto edit a record, the selection from the dropdown is not selected from value in the db, it always shows Please Select...

	global $db;
    	echo '<tr>
      	<td>Nation</td>';
	$nationlist = $db->sql_query("SELECT id,name FROM teams WHERE league =1 ORDER BY name");
	echo "<td><select name=\"nation\"><option value=\"0\">Please Select...</option>\n";
	while (list($nation_id, $nation_name) = $db->sql_fetchrow($nationlist)) {
		$sel = ($nation_id==$nation_name) ? 'selected' : '';
		echo "<option $sel value=\"$nation_id\">$nation_name</option>\n";
	}
	echo '</select></td>
    	</tr>';

Thanks in advance.

[bpat1434]

ummm... when you post, how do you define what ID is posted? You'd need something like:

while (list($nation_id, $nation_name) = $db->sql_fetchrow($nationlist)) {
    if(isset($_POST) && !empty($_POST['nation']))
    {
        $sel = ($_POST['nation'] == $nation_id)?'selected':'';
    }
    else
    {
        $sel = ($nation_id==$nation_name) ? 'selected' : '';
    }
        echo "<option $sel value=\"$nation_id\">$nation_name</option>\n";
}

[ale1981]

I define the ID earlier in the script, sorry should of posted more of it, using;

$_GET['id']

[bpat1434]

You didn't read my post... Did you look at my code? I honestly think no. If you had you'd see that this code:

    while (list($nation_id, $nation_name) = $db->sql_fetchrow($nationlist)) {
        $sel = ($nation_id==$nation_name) ? 'selected' : '';
        echo "<option $sel value=\"$nation_id\">$nation_name</option>\n";
    } 

is wrong for what you want, because $nation_id is always going to be what the current db selection is. Same thing with $nation_name. Where do you reference the $GET['id'] value in that code? You don't. That's the problem. So my code:

while (list($nation_id, $nation_name) = $db->sql_fetchrow($nationlist)) {
    if(isset($_POST) && !empty($_POST['nation']))
    {
        $sel = ($_POST['nation'] == $nation_id)?'selected':'';
    }
    else
    {
        $sel = ($nation_id==$nation_name) ? 'selected' : '';
    }
        echo "<option $sel value=\"$nation_id\">$nation_name</option>\n";
} 

solves that issue. If you use $GET instead of $POST, then just change $POST to $GET.

[ale1981]

I did read your message, I am still new to php.

I changed my code, and the list is still not picking the correct name from the list, it remains at Please Select...

Here is all the code I use;

function forecaster_Edit_Player() {

global $db;
showheader();
$id = $_GET['id'];
$row = $db->sql_fetchrow($db->sql_query("SELECT * FROM players WHERE id='$id'",false,__FILE__,__LINE__));
echo open_form(adminlink(),'post', 0,' style="border:none"');
echo '<table width="75%"  border="0" cellspacing="0" cellpadding="0">
	<tr>
  	<td>Player Name</td>
  	<td><input name="player_name" type="text" id="player_name" value="'.$row['name'].'"></td>
	</tr>';
teamlist();
nationlist();
echo '</table>
<br /><br />
<input type="submit" value="Update Player">
<input type="hidden" name="edit_id" value="'.$row['id'].'">
<input type="hidden" name="mode" value="Save_Player" />
</form>';
showfooter();
}

and the nationlist is;

function nationlist () {

global $db;
	echo '<tr>
  	<td>Nation</td>';
$nationlist = $db->sql_query("SELECT id,name FROM teams WHERE league =1 ORDER BY name");
echo "<td><select name=\"nation\"><option value=\"0\">Please Select...</option>\n";
while (list($nation_id, $nation_name) = $db->sql_fetchrow($nationlist)) {
		if(isset($_GET) && !empty($_GET['nation']))
		{
    			$sel = ($_GET['nation'] == $nation_id)?'selected':'';
	} else {
    			$sel = ($nation_id==$nation_name) ? 'selected' : '';
		}
echo "<option $sel value=\"$nation_id\">$nation_name</option>\n";
}
echo '</select></td>
	</tr>';
}

Thanks again for your time.

[bpat1434]

You POST information, but you reference it via GET? Do you actually get the ID in the URL field? If you do, okay. Then the code should be:

while (list($nation_id, $nation_name) = $db->sql_fetchrow($nationlist)) {
            if(isset($_GET) && !empty($_GET['id']))
            {
                    $sel = ($_GET['id'] == $nation_id)?'selected':'';
        } else {
                    $sel = ($nation_id==$nation_name) ? 'selected' : '';
            }
    echo "<option $sel value=\"$nation_id\">$nation_name</option>\n";
    } 

[ale1981]

I think I know where I am going wrong!

The id that I am passing is not the nation db id, its the player id, the player id is then used to get the nation id from the db. Should i be passing the nation id via the URL to?

[bpat1434]

you can do it however you want... You can either create the query to use the player ID or you can pass the nation ID via the url too...

[ale1981]

Thanks for your help bpat, will let give it a go now!

[ale1981]

In fact, I already get the nation ID using the array $row. So would I simply replace the areas you have used $_GET['id'] with $row['nation'] ?

[ale1981]

This is still not working 😕

... I have a headache!!

function nationlist () {

global $db;
	echo '<tr>
  	<td>Nation</td>';
$nationlist = $db->sql_query("SELECT id,name FROM teams WHERE league =1 ORDER BY name");
echo "<td><select name=\"nation\"><option value=\"0\">Please Select...</option>\n";
while (list($nation_id, $nation_name) = $db->sql_fetchrow($nationlist)) {
		if(isset($row['nation']) && !empty($row['nation']))
		{
    			$sel = ($row['nation'] == $nation_id)?'selected':'';
	} else {
    			$sel = ($row['nation'] == $nation_name) ? 'selected' : '';
		}
echo "<option $sel value=\"$nation_id\">$nation_name</option>\n";
}
echo '</select></td>
	</tr>';
}

[bpat1434]

where is $row['nation'] defined? You're inside a function, but you don't globalize the array $row, so the function doesn't have that variable.... that's where the problem lies....

[StevenJ]

post removed by StevenJ as it contained misleading information, sorry for any confusion.

S

[bpat1434]

no, his logic is proper... you can do it either way:
w3c form tester

Remove the selected="selected" and just use selected... it still works.

[ale1981]

So I need to globalize $row to? Ok here goes, thanks again!

[ale1981]

🙁

I added $row to this line;

global $db, $row;

STILL doesnt work! Would it be simpler to have it in the URL and use $_GET in the function?

[ale1981]

Its definately a problem with calling $row as I just tested the code all in one function, I just dont have a clue how to get round this! :confused

[ale1981]

Worked it out 😃

At last!

Thanks again for all your help bpat.