[RESOLVED] while doesn't worl

devil_online

Hi,
I have a code that uses the While and it insert data to the datatable
I want that while there is any name equal to that it wont insert any more data.

However I can't make it work

here is my code:

  

$resource = mysql_num_rows($sql);
while ($resource <= 1){

insertname();
}

How can I make it work

Roger_Ramjet

Looks to me like you are not using these functions correctly

sends a query string ($sql) to the connected db and returns a resultset for select queries.
$result = mysql_query($sql);

tells you how many rows are in the resultset
$count_rows = mysql_num_rows($result);

You use while to loop through things untill a condition changes. Your while does not change any condition so if it runs, it runs for ever.

devil_online

yes. My while doesn't check everytime it loops....
what should i do?

thorpe

Post more code. Include your actual query. What you have posted makes little to no sense.

devil_online

here the rest of the code:

 function insertname(){ 
global $link;
$firstnames = array("Jonh", "Paul", "Bill"); 
$lastnames = array("Simon", "Luck","Guy"); 
$name = $firstnames[array_rand($firstnames)]." ".$lastnames[array_rand($lastnames)]; 
$sql = mysql_query("SELECT names from home 
WHERE names = '$name' 
LIMIT 1") or die(mysql_error()); 
$resource = mysql_num_rows($sql); 
print $name; 
$query = "INSERT INTO home(names) 
    values('$name')"; 
mysql_query ( $query, $link) ;

}

Thanks in advance 😃

thorpe

That doesn't help at all. Im at a loss.

All I can suggest is to read up....

[man]while/man
[man]mysql_query/man
[man]mysql_num_rows/man

Houdini

I want that while there is any name equal to that it wont insert any more data.

Why are you randomizing arrays of first and last names your code will return two mixed up names but as written just one first and just one last name, so I guess from your code as is it is hard to tell what you are attempting to do. In your home table does the name column contain a first and last name because as written your coude would insert a random first and last name like Jonh Guy or Jonh Luck, it doesn't make sense to insert random names into a table.

$query = "INSERT INTO home(names) 
    values('$name')";

Your logic seems flawed by looking at all the code you have posted I suppose that is what you would want to test but with the code so far I am not really sure?
This will print out an error if the name exists:

if (mysql_num_rows(mysql_query("SELECT name FROM home WHERE first = '$name'"))) { 
    trigger_error ("<li>Your username already exists please try a different one.</li>n");

devil_online

yes, that if is very good
but if the name already exist, it won't insert the name.
What I want it to if it already exist it find another random name (that don't exist) to insert

thanks

devil_online

I think the problem is with the function
here is the complet code

 function insertname(){ 
global $link;
$firstnames = array("Jonh", "Paul", "Bill"); 
$lastnames = array("Simon", "Luck","Guy"); 
$name = $firstnames[array_rand($firstnames)]." ".$lastnames[array_rand($lastnames)]; 
$sql = mysql_query("SELECT names from home 
WHERE names = '$name' 
LIMIT 1") or die(mysql_error()); 
$resource = mysql_num_rows($sql); 
print $name; 
$query = "INSERT INTO home(names) 
    values('$name')"; 
mysql_query ( $query, $link) ;

}


while ($resource <= 1){

insertname();
}

I don't want to increase the resourse. I want that the condition says while the resourse is not 0 it trys to create a new name

thanks

madwormer2

$resource = 1;
while ($resource != 0){
insertname();
}

And at the top of the function, put "global $link, $resource;"

devil_online

sorry but that doesn't work

but anyone knows a code to instert data in the database but it won't insert repetly data, however it must be a loop because with the IF comand it stops everytime the condition is false.
Thanks

Roger_Ramjet

The way to prevent duplicate data entering a database is to make the table self-protecting with a unique index on the column that must not be duplicated. Then you do not have to remember about it when writing code.

Any other approach is amateur rubbish.

If your names must be unique then add a unique index to the name column or columns. The return from your insert query will tell you what has happened and you can then tell the user.

Yes, I know how to write the script you are after, but no I'm not going to tell you cos it is the stupid solution and I don't encourage that.

devil_online

sure it's easy for one guy that already knows php well, that's why i've post this in newbies.

I sure could put that restrintion on the table, but I must tell the code that it wont stop create new data until it finds one that it don't exist.

Thanks

Roger_Ramjet

OK, I've got no idea what you are trying to do or why, neither have the other people who have answered you in this thread. I realise that english is not your main language and makes it difficult for you, but even so, if you will not explain what you want to do AND WHY YOU NEED TO DO IT, then do not expect us to be able to help you.

If names must not be duplicated in the database then use a unique index to enforce that.
Whne you try to insert duplicate data into the db it will return an error which you can detect in your script and respond to accordingly. Insert query will either return the number of rows affected, or false on failure, and you can do what you want with that information.

devil_online

thanks..I will do that..