function usages in query statement

[crawfd]

I'm trying to get the result of the functions below to appear in my query statement. My listall() function seems to be working but why not the other two? When I debug I get the listall() function value to appear but the other values stay blank. Thanks

//rotate some variables for the paging class from get methods
function listall() {
if ($_GET['cat'] == "0") {
echo "";
} else {
$output = "WHERE category='$_GET[cat]'"; 
return $output; 
}}

function flash() {
if ($_GET['format'] == "flash") {
$a = " AND format='flash'"; 
} else {
echo "";
return $a; 
}}

function html() {
if ($_GET['format2'] == "adobe") {
$b = " AND format='Adobe' OR 'Fireworks'"; 
} else {
echo "";
return $b; 
}}  


$queryp = "SELECT * from products ".listall()."".flash()."".html()." LIMIT $offset,$results_per_page";

$res=mysql_query($queryp) or die("SQL: $query<br />\nError: ".mysql_error()); 
$num_rows = mysql_num_rows($res); 

[Weedpacket]

Have a look at what you're asking the functions to do (first, by tidying up the indenting):

function flash()
{
	if ($_GET['format'] == "flash")
	{
		$a = " AND format='flash'";
	}
	else
	{
		echo "";
		return $a;
	}
} 

So when $_GET['format']=='flash', you set $a = "...", and return nothing, while when $_GET['format'] doesn't equal flash you output an empty string to the browser, and return $a ... which contains nothing. Either way, you return nothing.

(PS: the SQL syntax you've got in that third function is buggy.)

[niroshan]

You have put the return in wrong position. 🙂

function flash()
 {
    if ($_GET['format'] == "flash") 
   {
      $a = " AND format='flash'";
   } 
   else {
      echo "";
   }
   return $a;
}


function html() 
{
   if ($_GET['format2'] == "adobe") {
     $b = " AND format='Adobe' OR 'Fireworks'";
   } else {
     echo "";
   }
   return $b;
}   

🙂

[madwormer2]

Another thing that needs to be pointed out is that if listall() returns nothing, then the whole SQL statement will be invalid.