[RESOLVED] PHP-HTML mixed code issue

[dmacman1962]

Hi all,

I am trying, used loosely, to mix a php/HTML/Javascript hyperlink with poor success. Here is the code...

<br> // <--- for posting readibility
echo '(<a href="javascript:LongDescription('Description.php?ProdID='$ProdID','LongDescription','450','300','center', 'front');">Click here to read more.</a>)';
<br>// <--- for posting readibility

The Java for this already works and I am not having an issue with that, so I did not post it.

The HTML version of this I am modifying is...

(<a href="javascript:NewWindow2('http://www.intheclassroom.org/help/faq.php','FAQ','800','600','center', 'front');"><strong>FAQ</strong></a>)

Of course, I am getting "unexpected T_STRING" at that line.

I have read many posts on mixing HTML and PHP and the use of single vs. double quotes, but this is one of the more complicated versions I have tackled.

I appreciate the guidance.

Thanks,

Don

[Megahertza]

Try this, you get this error when there is a string is on its on with out quotes. The html inside the echo is useing single quotes, so is the echo. its best to use single quotes with html and double with php or vice versa, just don't mix them. If you have to mix them you can put a \ infront of them and php will ignore them

<?php
echo '(<a href="javascript:LongDescription(\'Description.php?ProdID=\'$ProdID\',\'LongDescription\',\'450\',\'300\',\'center\', \'front\');">Click here to read more.</a>)';
?>

[laserlight]

Since you want to use variable interpolation, you should use double quotes for the string in PHP. If you use double quotes as the string delimiter, then you need to escape every double quote already present in the original string:

echo "(<a href=\"javascript:NewWindow2('http://www.intheclassroom.org/help/faq.php?name=$value','FAQ','800','600','center', 'front');\"><strong>FAQ</strong></a>)";

Conversely, you can use single quotes and concatenate instead. This time, it is the single quotes that you should escape:

echo '(<a href="javascript:NewWindow2(\'http://www.intheclassroom.org/help/faq.php?name=' . $value . ',\'FAQ\',\'800\',\'600\',\'center\', \'front\');"><strong>FAQ</strong></a>)';

[dmacman1962]

Wow,

I was playing with my code and ended up doing almost exactly what laserlight suggested (before I re-read my post and saw his post) and used this...

//
 echo "(<a href=\"javascript:LongDescription('Description.php?ProdID=" . $row['ProdID'] . "','LongDescription','450','300','center', 'front');\">Click here to read more.</a>)";
//

which is very close to his fix.

BTW, here is the Javascript code I used to define the popup window, so anyone who reads this will have all the components to make this work.

<SCRIPT LANGUAGE='JAVASCRIPT' TYPE='TEXT/JAVASCRIPT'>
var win=null;
function LongDescription(mypage,myname,w,h,pos,infocus){
if(pos=="random"){myleft=(screen.width)?Math.floor(Math.random()*(screen.width-w)):100;mytop=(screen.height)?Math.floor(Math.random()*((screen.height-h)-75)):100;}
if(pos=="center"){myleft=(screen.width)?(screen.width-w)/2:100;mytop=(screen.height)?(screen.height-h)/2:100;}
else if((pos!='center' && pos!="random") || pos==null){myleft=0;mytop=20}
settings="width=" + w + ",height=" + h + ",top=" + mytop + ",left=" + myleft + ",scrollbars=no,location=no,directories=no,status=no,menubar=no,toolbar=no,resizable=no";win=window.open(mypage,myname,settings);
win.focus();}
</script>

Consider this resolved, thanks all!!!!

Don