It doesn't work because the code blocks are set up incorrectly, also none of it should work as it relies on register_globals being set to on, which is bad, that taken with the fact that there's no cleaning up of data is an invitation to an attack, as well as run of the mill errors resulting from quotes in the input data.
Try this it cleans the data before input to the db
<?php
$db = mysql_connect("database","username","password");
mysql_select_db("username", $db);
if (isset($_POST['Submit'])) {
extract($_POST); // extract the POST data
//clean up and make safe db input
$external_id = mysql_real_escape_string(trim($external_id));
$ExtName = mysql_real_escape_string(trim($ExtName));
$ContactDetails = mysql_real_escape_string(trim($ContactDetails));
$Email = mysql_real_escape_string(trim($Email));
$Tele = mysql_real_escape_string(trim($Tele));
$presOrgan = mysql_real_escape_string(trim($presOrgan));
$start = mysql_real_escape_string(trim($start));
$finish = mysql_real_escape_string(trim($finish));
$date = mysql_real_escape_string(trim($date));
$radiobutton = mysql_real_escape_string(trim($radiobutton));
if (!$external_id || !$ExtName || !$ContactDetails || !$Email || !$Tele || !$presOrgan || !$start || !$finish || !$date) {
$error = "Sorry, You havent entered data in all the fields!<br><BR>";
} else {
$result = mysql_query("UPDATE external_examiners, prog_externals, external_visits SET external_examiners.name='$ExtName', external_examiners.contact_details='$ContactDetails',
external_examiners.email_address='$Email', external_examiners.tele_num='$Tele', external_examiners.pres_organisation='$presOrgan', prog_externals.start_date='$start',
prog_externals.finish_date='$finish', external_visits.date='$date', external_visits.ext_report='$radiobutton'
WHERE external_examiners.external_id = '" . $external_id ."'",$db)or die ('MySQL Error: ' . mysql_error());
echo("<b><br><br>Record Updated</br></br></b>");
}
} else {
if (isset($error)) {
echo $error;
}
$result = mysql_query("SELECT * FROM external_examiners, prog_externals, external_visits WHERE external_examiners.external_id = prog_externals.external_id
AND external_examiners.external_id = external_visits.external_id
ORDER BY external_examiners.external_id", $db) or die ('MYSQL Error: ' . mysql_error());
While($rec = mysql_fetch_array($result)) {
echo("External ID: " . $rec["external_id"] . "<br>\n");
echo("External Name: " . $rec["name"] . "<br>\n");
echo("Contact Details: " . $rec["contact_details"] . "<br>\n");
echo("Email Address: " . $rec["email_address"] . "<br>\n");
echo("Telephone Number: " . $rec["tele_num"] . "<br>\n");
echo("Present Organisation: " . $rec["pres_organisation"] . "<br>\n");
echo("Start Date: " . $rec["start_date"] . "<br>\n");
echo("Finish Date: " . $rec["finish_date"] . "<br>\n");
echo("Visit Date: " . $rec["date"] . "<br>\n");
echo("External Report: " . $rec["ext_report"] . "<br><br>\n");
}
?>
<form action = "<?php echo $_SERVER['PHP_SELF']; ?>" method="POST">
<table width="456" border="1">
<tr>
<td colspan="2">External ID:</td>
<td width="195"><input type="text" name="external_id"></td>
</tr>
<tr>
<td colspan="2">External Name:</td>
<td width="195"><input type="text" name="ExtName"></td>
</tr>
<tr>
<td colspan="2">Contact Details: </td>
<td><input type="text" name="ContactDetails"></td>
</tr>
<tr>
<td colspan="2">Email Address: </td>
<td><input type="text" name="Email"></td>
</tr>
<tr>
<td colspan="2">Telephone Number: </td>
<td><input type="text" name="Tele"></td>
</tr>
<tr>
<td colspan="2">Present Organisation: </td>
<td><input type="text" name="presOrgan"></td>
</tr>
<tr>
<td colspan="2">Externals Start Date: </td>
<td><input type="text" name="start"></td>
</tr>
<tr>
<td colspan="2">Externals Finish Date: </td>
<td><input type="text" name="finish"></td>
</tr>
<tr>
<td colspan="2">Externals Visit Date: </td>
<td><input type="text" name="date"></td>
</tr>
<tr>
<td width="157">External Report: </td>
<td width="82">Yes:
<input name="radiobutton" type="radio" value="Yes"> </td>
<td>No:
<input name="radiobutton" type="radio" value="No"> </td>
</tr>
<tr>
<td colspan="2"> </td>
<td> </td>
</tr>
<tr>
<td colspan="2"><div align="right">
<input type="submit" name="Submit" value="Submit">
</div></td>
<td><input type="reset" name="Reset" value="Reset"></td>
</tr>
</table>
</form><br>
<?php
}
?>
it should work, however obviously hasn't been tested as I don't have your db.
