Making odbc connection

PhilippeDJ

I have a function that makes a odbc connection and returns the recordset, only problem ( not sure if it is a problem ) is that I can not close the connection, if I do it in the function I lose my recordset, is there another way to do this ?
With a class ?

Could this lead to a problem if I don't close the connections ?

This is the code :

function executeReadSQL($sql){

  $conn = odbc_connect('SERVER','USER','PASWORD');

  if (!$conn)
  {
    exit("Connection failed ! " . $conn);
  }

  $rs = odbc_exec($conn,$sql);
  if (!$rs)
  {
    exit("Error in sql " . $sql);
  }

  return($rs);

}

scrupul0us

well yea... in a function, it always returns the last line, and thats it... therefore you'll have to close the connection outside the function

thorpe

in a function, it always returns the last line, and thats it...

What? No it doesn't.

As for your question PhilippeDJ, some may say its bad practice but, there isn't really a need to close connections in php as the garbage collection will clean up things like that.

I dont understand why you cant close it though. Does this not work?

function executeReadSQL($sql){

  $conn = odbc_connect('SERVER','USER','PASWORD');

  if (!$conn)
  {
    exit("Connection failed ! " . $conn);
  }

  $rs = odbc_exec($conn,$sql);
  if (!$rs)
  {
    exit("Error in sql " . $sql);
  }

  odbc_close($conn);
  return($rs);

}

scrupul0us

by last line i mean where the script ends... whether it be within a decision structure or code block... it returns the last variable and stops (at least this is what ive always experienced) if he was to try and close the connection after returning the variable it wold not work b/c after you return something, the function proceedure is over

PhilippeDJ

thorpe wrote:

I dont understand why you cant close it though. Does this not work?

function executeReadSQL($sql){

  $conn = odbc_connect('SERVER','USER','PASWORD');

  if (!$conn)
  {
    exit("Connection failed ! " . $conn);
  }

  $rs = odbc_exec($conn,$sql);
  if (!$rs)
  {
    exit("Error in sql " . $sql);
  }

  odbc_close($conn);
  return($rs);

}

When I try that I get the following error :

Warning: odbc_fetch_row(): 3 is not a valid ODBC result resource in

When I try odbc_fetch_row($rs)

Like this :

$sql = "select * from dbd001lib.trlyhp";
$rs = executeReadSQL($sql);
if (odbc_fetch_row($rs)){
  echo odbc_result($rs,"tyfinr");
}