[RESOLVED] Cookie problem

[Xeon]

I've made a script for a single-user password authentication system, but I'm experiencing some difficulties.

$password==$_POST["password"];
 if($password!=NULL){
  setcookie("AdminPassword",$password,time()+60*60*24);
 }

 if(isset($_COOKIE["AdminPassword"]) && $_COOKIE["AdminPassword"]=="thepassword"){
  echo"good password!";
 /*line 22*/}elesif(isset($_COOKIE["AdminPassword"]) && $_COOKIE["AdminPassword"]!="thepassword"){
  echo "<p>
   Incorrect password.
  </p>
      <form method=\"post\" action=\"/admin/index.php\">
       Password:
       <input type=\"password\" name=\"password\" size=\"20\">
       <br />
       <input type=\"submit\" value=\"login\">
      </form>";
 }else{
  echo "<form method=\"post\" action=\"/admin/index.php\">
       Password:
       <input type=\"password\" name=\"password\" size=\"20\">
       <br />
       <input type=\"submit\" value=\"login\">
      </form>";
 }

The result:

Parse error: syntax error, unexpected '{' in C:\Websites\chandlerhilldesign\admin\index.php on line 22

What did I do wrong?

[herve]

/*line 22*/}elesif(isset($_COOKIE["AdminPassword"]) &&

it should be :

/*line 22*/}[color=red]elseif[/color](isset($_COOKIE["AdminPassword"]) &&

[MrPotatoes]

herve wrote:

/*line 22*/}elesif(isset($_COOKIE["AdminPassword"]) &&

it should be :

/*line 22*/}[color=red]elseif[/color](isset($_COOKIE["AdminPassword"]) &&

this right here is why you space our your code.

dude, if you space our your code and have a syntax highlighter then your debugging will be alot easier

[Xeon]

Haha. Thanks for finding that.

I'm still having problems though. The parse errors are gone, but now the script itself doesn't work. No matter what password I type in, the login form appears (not 'good password' etc.)

[Roger_Ramjet]

Your error is right here

 $password==$_POST["password"];
if($password!=NULL){
  setcookie("AdminPassword",$password,time()+60*60*24);
} 

== is the equality test, not the assignment operator

 $password=$_POST["password"];
if($password!=NULL){
  setcookie("AdminPassword",$password,time()+60*60*24);
} 

Funny, I useually get it wrong the other way and asign the value when I mean to compare them.

[herve]

MrPotatoes wrote:

this right here is why you space our your code.

dude, if you space our your code and have a syntax highlighter then your debugging will be alot easier

Exactly.

Something like this :

<?PHP

function CheckPassword ($password)
{
    if ( $password == "thepassword" )
    {
       // Good password !

   return 1;
}
else
{
   // Bad password !

   return 0;
}
}

function Welcome()
{
    print "Welcome in private area !";
}

function GoAway()
{
    print "Bad password, <a href=\"/admin/index.php\">try again</a>.";
}

// ****************************************************************
// Main program

if ( isset($_COOKIE["AdminPassword"]) )
{
     // Ok, there's a cookie, is it the good one ?

    $good = CheckPassword($_COOKIE["AdminPassword"]);

    if ($good)
    {  Welcome();
    }
    else
    {  GoAway();
    }

}
elseif ( $_POST["password"] != "" )
{
    // The "password" input field has some content, let's check it

    $good = CheckPassword($_POST["password"]);

    if ($good)
    {
       setcookie("AdminPassword",$_POST["password"],time()+60*60*24);

       Welcome();
    }
    else
    {  GoAway();
    }
}
else
{
    // No cookie or password field right now, so let's send the HTML form

    print "<form method=\"post\" action=\"/admin/index.php\">
          Password:
          <input type=\"password\" name=\"password\" size=\"20\">
          <br />
          <input type=\"submit\" value=\"login\">
          </form>";
}
?>

[Xeon]

Thanks very much for the help!

I'm still having problems though. :mad: When I enter the correct password, I get the following error:

Warning: Cannot modify header information - headers already sent by (output started at C:\Websites\chandlerhilldesign\inc\head.php:5) in C:\Websites\chandlerhilldesign\admin\index.php on line 47

Line 47 of /admin/index.php is the line in which the cookie set.

[herve]

It's hard to help you without the code 🙂

May be you're trying to set a cookie after sending some HTML code to the browser ?
Some print() or echo() in "head.php" executed before the setcookie() in "index.php" ?

You can't do that.

[Xeon]

All right. But now I'm getting this:

Warning: Cannot modify header information - headers already sent by (output started at C:\Websites\chandlerhilldesign\admin\index.php:22) in C:\Websites\chandlerhilldesign\admin\index.php on line 38

/admin/index.php:

<?php
	function CheckPassword ($password){
		if ( $password == "thepassword" ){
		// Good password
			return 1;
		}else{
		// Bad password !
		return 0;
		}
	}

function Welcome(){
	include $_SERVER['DOCUMENT_ROOT']."/admin/admin.php";
}

function GoAway(){
	include $_SERVER['DOCUMENT_ROOT']."/admin/retry.php";
}
?>


<?php
	if ( isset($_COOKIE["AdminPassword"]) ){
		// Ok, there's a cookie, is it the good one ?
		$good = CheckPassword($_COOKIE["AdminPassword"]);

	if ($good){
		Welcome();
	}else{
		GoAway();
	}
}elseif ( $_POST["password"] != "" ){
	// The "password" input field has some content, let's check it

	$good = CheckPassword($_POST["password"]);

	if ($good){
		setcookie("AdminPassword",$_POST["password"],time()+60*60*24);

		Welcome();
	}else{
		GoAway();
	}
}else{
	// No cookie or password field right now, so let's send the HTML form

	include $_SERVER['DOCUMENT_ROOT']."/admin/password.php";
}
?>

				</div>
			</div>
<?php
	include $_SERVER['DOCUMENT_ROOT']."/inc/r.php";
	include $_SERVER['DOCUMENT_ROOT']."/inc/foot.php";
?>

:queasy: :queasy: :queasy:

[herve]

When do you get this error message ? At first display ?
After clicking on the submit button ? After that ?

You don't need three " <?php ... ?> " pairs, you only need one, enclosing everything.

Also, there's

                    </div>
        </div> 

in the middle of the code ? (near the end)

I have test the code I gave you before, and it works, so add carefully
what you need, step by step, until you get the error message, and you will
know where the problem is.

[Xeon]

I found the problem. Everything is working great now. Merci beaucoup pour l'aide !

[herve]

Je vous en prie 😉