Please Help: Edit Record Query - Thanks

The_MA

Hi - I'm obviously a noob to this but that's why I'm here - I've been using PHP for just over a month and I'm really enjoying it. I'm looking to create an Edit query when I click the edit submit button next to each record in a table. I'm trying to do it all in one script - viewuser.php this is what I have so far - I don't know what is wrong or why it doesn't work - I would really appreciate your help - thanks ever so much in advance - I'm already very grateful for people's help on another script.

<html><head><title>View Users</title></head>
<body>

<?php

session_start();

if (!isset($_SESSION['loggedin']) 
   || $_SESSION['loggedin'] !== true) {

   header('Location: login.php');
   exit;
}

$conn=@mysql_connect( "localhost", "alexm", "rugby" )
		 	or die( "Err:Conn" );

$db = @mysql_select_db( "rugby_project", $conn) or die( "Err:Db" );

if($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit")
{
   if (!isset($_POST["submit"]))
   {
      $userID = $_GET["userID"];
      $sql = "SELECT * FROM phone_numbers WHERE userID=$userID";
      $result = mysql_query($sql);        

      $row = mysql_fetch_array($result);

echo' <form action="$self" method="post">
      <input type=hidden name="userID" value="<?php echo $row["userID"] ?>">

  User<INPUT TYPE="TEXT" NAME="userID" VALUE=" $row["userID"] >" SIZE=30><br>
  Number<INPUT TYPE="TEXT" NAME="number" VALUE=" $row["number"] >" SIZE=30><br>
  Password<INPUT TYPE="TEXT" NAME="password" VALUE=" $row["password] ?>" SIZE=30><br>

  <input type="hidden" name="cmd" value="edit">

  <input type="submit" name="submit" value="submit">

  </form> ';  

echo( "<center><p><font size=\"1\" face=\"Verdana\">
<a href=\"viewdevices.php\">Back</a>&nbsp;&nbsp;|&nbsp;
<a href=\"control.php\">Return to Control Panel</a>&nbsp;&nbsp;|&nbsp;
<a href=\"logout.php\">Log out<p></a>
</body></html>" );
  }

}
else
{

$sql = "select userID, number, password from phone_numbers order by userID";

$rs = @mysql_query( $sql,$conn);
$self = $_SERVER['PHP_SELF'];
$rows = mysql_num_rows($rs);

echo( "<table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\">
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"4\"><font size=\"1\" face=\"Verdana\">
<center>User View</center></font></td></tr>" );
   echo( "<tr><td><font size=\"1\" face=\"Verdana\"><strong>User</td>" );
   echo( "<td><font size=\"1\" face=\"Verdana\"><strong>Phone Number</td>" );
   echo( "<td><font size=\"1\" face=\"Verdana\"><strong>Password</td>" );
   echo( "<td><font size=\"1\" face=\"Verdana\"><i><center>Edit</td></tr>" );


if(mysql_num_rows($rs))
{

echo( "<form name=\"editform\" method=\"post\" action=\"$self\">"); 

while( $row = mysql_fetch_array( $rs ) ){
   $userID=$row["userID"]; 
   $number=$row["number"]; 
   $password=$row["password"]; 
   echo '<tr><td><font size="2" face="Verdana">' . $userID . '</td>'; 
   echo '<td><font size="2" face="Verdana">' . $number . '</td>'; 
   echo '<td><font size="2" face="Verdana">' . $password . '</td>'; 
   echo '<td><center><input type="hidden" name="edit[]" value="' . $userID . '" /><input type="submit" name="edit" value="Edit"></td></tr>';   

}

echo( "</table><p><table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\">
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"2\"><font size=\"1\" face=\"Verdana\">
<center>There are $rows records in this table</center></font></td></tr></table>" );

   echo( "<center><p><font size=\"1\" face=\"Verdana\">
<a href=\"control.php\">Return to Control Panel</a>&nbsp;&nbsp;|&nbsp;
<a href=\"logout.php\">Log out<p></a>
</body></html>" );

}
else
{
echo( "<table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\">
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"2\"><font size=\"1\" face=\"Verdana\">
<center>This table has no records yet</center></font></td></tr></table>" );
} 
}

?>

shamly

There seem to be quite a lot of mistakes that i can see ....

$row["password] has a missing (").
```
<input type=hidden name="userID" value="<?php echo $row["userID"] ?>"> 
```
you are trying to open a new PHP tag without closing the previous one which is wrong and in this case unnecessary. The correct method is ...

<input type=hidden name="userID" value="' . $row["userID"] . '">

You cannot insert php data such as $row["userID"] within HTML even if it is echoed. Correct example whould be

User<INPUT TYPE="TEXT" NAME="userID" VALUE="' . $row["number"] . '" SIZE=30><br>

The_MA

Thanks - yea, those where pretty stupid mistakes I didn't see them - thanks - I have replaced the errors but the script still doesn't function entirely - i.e. the edit button next to each record doesn't take me into the input form to edit the record... here is the amended code:

<html><head><title>View Users</title></head>
<body>

<?php

session_start();

if (!isset($_SESSION['loggedin']) 
   || $_SESSION['loggedin'] !== true) {

   header('Location: login.php');
   exit;
}

$conn=@mysql_connect( "localhost", "alexm", "rugby" )
		 	or die( "Err:Conn" );

$db = @mysql_select_db( "rugby_project", $conn) or die( "Err:Db" );

if($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit")
{
   if (!isset($_POST["submit"]))
   {
      $userID = $_GET["userID"];
      $sql = "SELECT * FROM phone_numbers WHERE userID=$userID";
      $result = mysql_query($sql);        

      $row = mysql_fetch_array($result);

echo' <form action="$self" method="post">
      <input type=hidden name="userID" value="' . $row["userID"] . '"> 
      User<INPUT TYPE="TEXT" NAME="userID" VALUE="' . $row["userID"] . '" SIZE=30><br>
      Number<INPUT TYPE="TEXT" NAME="number" VALUE="' . $row["number"] . '" SIZE=30><br>
      Password<INPUT TYPE="TEXT" NAME="password" VALUE="' . $row["password"] . '" SIZE=30><br>

  <input type="hidden" name="cmd" value="edit">

  <input type="submit" name="submit" value="submit">

  </form> ';  

echo( "<center><p><font size=\"1\" face=\"Verdana\">
<a href=\"viewdevices.php\">Back</a>&nbsp;&nbsp;|&nbsp;
<a href=\"control.php\">Return to Control Panel</a>&nbsp;&nbsp;|&nbsp;
<a href=\"logout.php\">Log out<p></a>
</body></html>" );
  }

}
else
{

$sql = "select userID, number, password from phone_numbers order by userID";

$rs = @mysql_query( $sql,$conn);
$self = $_SERVER['PHP_SELF'];
$rows = mysql_num_rows($rs);

echo( "<table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\">
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"4\"><font size=\"1\" face=\"Verdana\">
<center>User View</center></font></td></tr>" );
   echo( "<tr><td><font size=\"1\" face=\"Verdana\"><strong>User</td>" );
   echo( "<td><font size=\"1\" face=\"Verdana\"><strong>Phone Number</td>" );
   echo( "<td><font size=\"1\" face=\"Verdana\"><strong>Password</td>" );
   echo( "<td><font size=\"1\" face=\"Verdana\"><i><center>Edit</td></tr>" );


if(mysql_num_rows($rs))
{

echo( "<form name=\"editform\" method=\"post\" action=\"$self\">"); 

while( $row = mysql_fetch_array( $rs ) ){
   $userID=$row["userID"]; 
   $number=$row["number"]; 
   $password=$row["password"]; 
   echo '<tr><td><font size="2" face="Verdana">' . $userID . '</td>'; 
   echo '<td><font size="2" face="Verdana">' . $number . '</td>'; 
   echo '<td><font size="2" face="Verdana">' . $password . '</td>'; 
   echo '<td><center><input type="hidden" name="edit[]" value="' . $userID . '" /><input type="submit" name="edit" value="Edit"></td></tr>';   

}

echo( "</table><p><table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\">
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"2\"><font size=\"1\" face=\"Verdana\">
<center>There are $rows records in this table</center></font></td></tr></table>" );

   echo( "<center><p><font size=\"1\" face=\"Verdana\">
<a href=\"control.php\">Return to Control Panel</a>&nbsp;&nbsp;|&nbsp;
<a href=\"logout.php\">Log out<p></a>
</body></html>" );

}
else
{
echo( "<table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\">
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"2\"><font size=\"1\" face=\"Verdana\">
<center>This table has no records yet</center></font></td></tr></table>" );
} 
}

?>

shamly

When you click on the button and the page submits

the if($GET["cmd"]=="edit" || $POST["cmd"]=="edit") condition will eb passed.

since the button has been clicked if (!isset($_POST["submit"])) will be set to false. You havent added any else condition in this code. Add one and put an echo in it and check if it gets echoed. If it does then thats where u will have to build your EDIT Query.

The_MA

Anyone