Post Control / Approval MOD

sbourdon

Hello,

First post here...

I've taken over the development of Post Control, an approval MOD for phpBB originally created by Ani' and published on phpbbfrance.org.

I only need to fix one more bug before being able to release a stable, final version...

Posts awaiting validation will not appear within search results; they are hidden. But, the total number of non-validated messages is not susbracted from the total number of posts found.

For example, if a post awaiting validation contains the word Test and you do a search for that word on the board, you will get the following results (assuming Test only appears in that post):

1 post found:
(nothing appears below, since posts awaiting validation do not appear within search results)

In this case, what I would like to achieve is this:
0 post found
(and still, nothing appears below, since posts awaiting validation do not appear within search results)

To achieve this, I was told to do this:

Just before $word_count++ (which is about line 357 of search.php), do a query to check the validation of the post. If the post is not validated, skip the $word_count++ instruction.

Knowing that the flag is set to 1 for unapproved posts inside the phpbb_posts validate table, could anyone tell me what the sql query should look like?

Thanks!

sbourdon

Fixed!

# 
#-----[ OPEN ]-----------------------------
# 
search.php

# 
#-----[ FIND ]----------------------------
# 
						WHERE post_time >= " . $userdata['user_lastvisit'];

# 
#-----[ REPLACE WITH ]---------------------
# 
						WHERE post_time >= " . $userdata['user_lastvisit'] . "
						AND validate=0";

# 
#-----[ FIND ]----------------------------
# 
						WHERE poster_id = " . $userdata['user_id'];

# 
#-----[ REPLACE WITH ]---------------------
# 
						WHERE poster_id = " . $userdata['user_id'] . "
						AND validate=0";

# 
#-----[ FIND ]----------------------------
# 
					WHERE poster_id IN ($matching_userids)";

# 
#-----[ REPLACE WITH ]---------------------
# 
					WHERE poster_id IN ($matching_userids)" . "
					AND validate=0";

# 
#-----[ FIND ]----------------------------
# 
			if ( $auth_sql != '' )
			{
				$sql = "SELECT t.topic_id, f.forum_id
					FROM " . TOPICS_TABLE . "  t, " . FORUMS_TABLE . " f
					WHERE t.topic_replies = 0 
						AND t.forum_id = f.forum_id
						AND t.topic_moved_id = 0
						AND $auth_sql";
			}
			else
			{
				$sql = "SELECT topic_id 
					FROM " . TOPICS_TABLE . "  

					WHERE topic_replies = 0 
						AND topic_moved_id = 0";
			}

# 
#-----[ REPLACE WITH ]---------------------
# 
			if ( $auth_sql != '' )
			{
				$sql = "SELECT t.topic_id, f.forum_id
					FROM " . TOPICS_TABLE . "  t, " . FORUMS_TABLE . " f, " . POSTS_TABLE . " p
					WHERE t.topic_replies = 0 
						AND t.forum_id = f.forum_id
						AND t.topic_moved_id = 0
						AND t.topic_id = p.topic_id
						AND p.validate = 0
						AND $auth_sql";
			}
			else
			{
				$sql = "SELECT t.topic_id 
					FROM " . TOPICS_TABLE . " t, " . POSTS_TABLE . " p  

					WHERE t.topic_id = p.topic_id
						AND t.topic_replies = 0
						AND p.validate = 0 
						AND t.topic_moved_id = 0";
			}

# 
#-----[ FIND ]----------------------------
# 
							$sql = "SELECT m.post_id 
								FROM " . SEARCH_WORD_TABLE . " w, " . SEARCH_MATCH_TABLE . " m 
								WHERE w.word_text LIKE '$match_word' 
									AND m.word_id = w.word_id 
									AND w.word_common <> 1 
									$search_msg_only";

# 
#-----[ REPLACE WITH ]---------------------
# 
							$sql = "SELECT m.post_id 
								FROM " . SEARCH_WORD_TABLE . " w, " . SEARCH_MATCH_TABLE . " m, " . POSTS_TABLE . " p 
								WHERE p.post_id = m.post_id 
									AND p.validate = 0 
									AND w.word_text LIKE '$match_word' 
									AND m.word_id = w.word_id 
									AND w.word_common <> 1 
									$search_msg_only";

😃