can anyone help me with this php code using files

[JackOfBlades]

i have just finished making my file uploads in my school project...then what i want now is to let other members download what was uploaded by others.. i have this code here and it shows the files in the upload folder but i cant download it..

<?php
echo ("<h1>File Directory:</h1>");
function getFiles($path) {
$files = array();
$fileNames = array();
$i = 0;

if (is_dir($path)) {
if ($dh = opendir($path)) {
while (($file = readdir($dh)) !== false) {
if ($file == "." || $file == "..") continue;
$fullpath = $path . "/" . $file;
$fkey = strtolower($file);
while (array_key_exists($fkey,$fileNames)) $fkey .= " ";
$a = stat($fullpath);
$files[$fkey]['size'] = $a['size'];
if ($a['size'] == 0) $files[$fkey]['sizetext'] = "-";
else if ($a['size'] > 1024) $files[$fkey]['sizetext'] = (ceil($a['size']/1024100)/100) . " K";
else if ($a['size'] > 10241024) $files[$fkey]['sizetext'] = (ceil($a['size']/(10241024)100)/100) . " Mb";
else $files[$fkey]['sizetext'] = $a['size'] . " bytes";
$files[$fkey]['name'] = $file;
$files[$fkey]['type'] = filetype($fullpath);
$fileNames[$i++] = $fkey;
}
closedir($dh);
} else die ("Cannot open directory: $path");
} else die ("Path is not a directory: $path");
sort($fileNames,SORT_STRING);
$sortedFiles = array();
$i = 0;
foreach($fileNames as $f) $sortedFiles[$i++] = $files[$f];

return $sortedFiles;
}

$files = getFiles("uploads");
foreach ($files as $file) print "<li><a href=\"$file[name]\">$file[name]</a></li>";
?>

im thinking that the error is in the last line where i did an <a href> coz wat it does is redirect it instead ryt? but what is the right tag that i should put there so that the files can be downloaded? thanks

[bogu]

	function dl_file($file){

   //First, see if the file exists
   if (!is_file($file)) { die("<b>404 File not found!</b>"); }

   //Gather relevent info about file
   $len = filesize($file);
   $filename = basename($file);
   $file_extension = strtolower(substr(strrchr($filename,"."),1));

   //This will set the Content-Type to the appropriate setting for the file
   switch( $file_extension ) {
     case "pdf": $ctype="application/pdf"; break;
     case "exe": $ctype="application/octet-stream"; break;
     case "zip": $ctype="application/zip"; break;
     case "doc": $ctype="application/msword"; break;
     case "xls": $ctype="application/vnd.ms-excel"; break;
     case "ppt": $ctype="application/vnd.ms-powerpoint"; break;
     case "gif": $ctype="image/gif"; break;
     case "png": $ctype="image/png"; break;
     case "jpeg":
     case "jpg": $ctype="image/jpg"; break;
     case "mp3": $ctype="audio/mpeg"; break;
     case "wav": $ctype="audio/x-wav"; break;
     case "mpeg":
     case "mpg":
     case "mpe": $ctype="video/mpeg"; break;
     case "mov": $ctype="video/quicktime"; break;
     case "avi": $ctype="video/x-msvideo"; break;

     //The following are for extensions that shouldn't be downloaded (sensitive stuff, like php files)
     case "php":
     case "htm":
     case "html":
     case "txt": die("<b>Cannot be used for ". $file_extension ." files!</b>"); break;

     default: $ctype="application/force-download";
   }

   //Begin writing headers
   header("Pragma: public");
   header("Expires: 0");
   header("Cache-Control: must-revalidate, post-check=0, pre-check=0");
   header("Cache-Control: public"); 
   header("Content-Description: File Transfer");

   //Use the switch-generated Content-Type
   header("Content-Type: $ctype");

   //Force the download
   $header="Content-Disposition: attachment; filename=".$filename.";";
   header($header );
   header("Content-Transfer-Encoding: binary");
   header("Content-Length: ".$len);
   readfile($file);
   exit(1);
} 

This is a function that starts your download...

Have fun coding. 😃

[JackOfBlades]

ei bogu thanks a lot..but err.. it only says 404 file not found? how come?

i did this at the end of your function
$files = dl_file("uploads");

but it only says 404 file not found... sorry im still new to using files in php im still confuse i hope u can help me out here

[bogu]

404 file not found <-- this error says everything ...

The path to your file that u want to download is not good ...

[JackOfBlades]

yeah but the name of the folder where i uploaded my files is uploads... so if i want to retrieve it shoudnt i name it to file = dl_file("uploads");??? coz thats the path?!? what suggestions can u give? am i not doing it ryt?

[bogu]

dl_file("uploads/name_of_the_file.ext");

I dont know your directories structure of your project ....

Or do u try to download a hole directory?

[JackOfBlades]

ei now i got it thanks but what if i uploaded many files and i want the user to choose among the files uploaded which file he wants to download? how do i do that? thanks for the help by d way

[bogu]

U make a page where u show him all the file for download ...