Help Please!!!! Noob - Edit Query.

The_MA

Hi - Could someone please check this code and tell me what I am doing wrong? I would like to be able to edit a record by clicking the edit submit button next to a record in the view records table - this should take me to a form where I can change the current values - the form would already have the current record details as default and then you can edit those. At the moment the records display but clicking the edit submit button has no effect at all. Thanks in advance for your help! I'm completely new to PHP so please don't expect me to understand simple PHP points you make lol if you don't explain it to me - thanks very much guys - I really appreciate this if you can help me.

<html><head><title>View Users</title></head>
<body>

<?php

session_start();

if (!isset($_SESSION['loggedin']) 
   || $_SESSION['loggedin'] !== true) {

   header('Location: login.php');
   exit;
}

$conn= mysql_connect( "localhost", "alexm", "rugby" )
		 	or die( "Err:Conn" );

$db = mysql_select_db( "rugby_project", $conn) or die( "Err:Db" );

if (isset($_POST['submit']) && ($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit"))  {
      $userID = $_GET["userID"];
      $sql = "SELECT * FROM phone_numbers WHERE userID=$userID";
      $result = mysql_query($sql);        

      $row = mysql_fetch_array($result);

if ($result)
  {

echo' <form action="$self" method="post">
      <input type=hidden name="userID" value="' . $row["userID"] . '"> 
      User<INPUT TYPE="TEXT" NAME="userID" VALUE="' . $row["userID"] . '" SIZE=30><br>
      Number<INPUT TYPE="TEXT" NAME="number" VALUE="' . $row["number"] . '" SIZE=30><br>
      Password<INPUT TYPE="TEXT" NAME="password" VALUE="' . $row["password"] . '" SIZE=30><br>

  <input type="hidden" name="cmd" value="edit">

  <input type="submit" name="submit" value="submit">

  </form> ';  

echo( "<center><p><font size=\"1\" face=\"Verdana\">
<a href=\"viewdevices.php\">Back</a>&nbsp;&nbsp;|&nbsp;
<a href=\"control.php\">Return to Control Panel</a>&nbsp;&nbsp;|&nbsp;
<a href=\"logout.php\">Log out<p></a>
</body></html>" );
  }
}
else
{

$sql = "select userID, number, password from phone_numbers order by userID";

$rs = mysql_query( $sql,$conn);
$self = $_SERVER['PHP_SELF'];
$rows = mysql_num_rows($rs);

echo( "<table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\">
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"4\"><font size=\"1\" face=\"Verdana\">
<center>User View</center></font></td></tr>" );
   echo( "<tr><td><font size=\"1\" face=\"Verdana\"><strong>User</td>" );
   echo( "<td><font size=\"1\" face=\"Verdana\"><strong>Phone Number</td>" );
   echo( "<td><font size=\"1\" face=\"Verdana\"><strong>Password</td>" );
   echo( "<td><font size=\"1\" face=\"Verdana\"><i><center>Edit</td></tr>" );


if(mysql_num_rows($rs))
{

echo( "<form name=\"editform\" method=\"post\" action=\"$self\">"); 

while( $row = mysql_fetch_array( $rs ) ){
   $userID=$row["userID"]; 
   $number=$row["number"]; 
   $password=$row["password"]; 
   echo '<tr><td><font size="2" face="Verdana">' . $userID . '</td>'; 
   echo '<td><font size="2" face="Verdana">' . $number . '</td>'; 
   echo '<td><font size="2" face="Verdana">' . $password . '</td>'; 
   echo '<td><center><input type="hidden" name="edit[]" value="' . $userID . '" /><input type="submit" name="edit" value="Edit"></td></tr>';   

}

echo( "</table><p><table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\">
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"2\"><font size=\"1\" face=\"Verdana\">
<center>There are $rows records in this table</center></font></td></tr></table>" );

   echo( "<center><p><font size=\"1\" face=\"Verdana\">
<a href=\"control.php\">Return to Control Panel</a>&nbsp;&nbsp;|&nbsp;
<a href=\"logout.php\">Log out<p></a>
</body></html>" );

}
else
{
echo( "<table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\">
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"2\"><font size=\"1\" face=\"Verdana\">
<center>This table has no records yet</center></font></td></tr></table>" );
} 
}

?>

Roger_Ramjet

<html><head><title>View Users</title></head>
<body>

<?php

session_start();

if (!isset($_SESSION['loggedin']) 
   || $_SESSION['loggedin'] !== true) {

   header('Location: login.php');
   exit;
}

$conn= mysql_connect( "localhost", "alexm", "rugby" )
		 	or die( "Err:Conn" );

$db = mysql_select_db( "rugby_project", $conn) or die( "Err:Db" );

if (isset($_POST['submit']) && ($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit"))  {
      $userID = $_GET["userID"];
      $sql = "SELECT * FROM phone_numbers WHERE userID=$userID";
      $result = mysql_query($sql);        

      $row = mysql_fetch_array($result);

if ($result)
  {

echo' <form action="$self" method="post">
      <input type=hidden name="userID" value="' . $row["userID"] . '"> 
      User<INPUT TYPE="TEXT" NAME="userID" VALUE="' . $row["userID"] . '" SIZE=30><br>
      Number<INPUT TYPE="TEXT" NAME="number" VALUE="' . $row["number"] . '" SIZE=30><br>
      Password<INPUT TYPE="TEXT" NAME="password" VALUE="' . $row["password"] . '" SIZE=30><br>

  <input type="hidden" name="cmd" value="edit">

  <input type="submit" name="submit" value="submit">

  </form> ';  

echo( "<center><p><font size=\"1\" face=\"Verdana\">
<a href=\"viewdevices.php\">Back</a>&nbsp;&nbsp;|&nbsp;
<a href=\"control.php\">Return to Control Panel</a>&nbsp;&nbsp;|&nbsp;
<a href=\"logout.php\">Log out<p></a>
</body></html>" );
  }
}
else
{

$sql = "select userID, number, password from phone_numbers order by userID";

$rs = mysql_query( $sql,$conn);
$self = $_SERVER['PHP_SELF'];
$rows = mysql_num_rows($rs);

echo( "<table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\">
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"4\"><font size=\"1\" face=\"Verdana\">
<center>User View</center></font></td></tr>" );
   echo( "<tr><td><font size=\"1\" face=\"Verdana\"><strong>User</td>" );
   echo( "<td><font size=\"1\" face=\"Verdana\"><strong>Phone Number</td>" );
   echo( "<td><font size=\"1\" face=\"Verdana\"><strong>Password</td>" );
   echo( "<td><font size=\"1\" face=\"Verdana\"><i><center>Edit</td></tr>" );


if(mysql_num_rows($rs))
{

echo( "<form name=\"editform\" method=\"post\" action=\"$self\">"); 

while( $row = mysql_fetch_array( $rs ) ){
   $userID=$row["userID"]; 
   $number=$row["number"]; 
   $password=$row["password"]; 
   echo '<tr><td><font size="2" face="Verdana">' . $userID . '</td>'; 
   echo '<td><font size="2" face="Verdana">' . $number . '</td>'; 
   echo '<td><font size="2" face="Verdana">' . $password . '</td>'; 
   echo '<td><center><input type="hidden" name="edit[]" value="' . $userID . '" /><input type="submit" name="edit" value="Edit"></td></tr>';   

}

echo( "</table><p><table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\">
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"2\"><font size=\"1\" face=\"Verdana\">
<center>There are $rows records in this table</center></font></td></tr></table>" );

   echo( "<center><p><font size=\"1\" face=\"Verdana\">
<a href=\"control.php\">Return to Control Panel</a>&nbsp;&nbsp;|&nbsp;
<a href=\"logout.php\">Log out<p></a>
</body></html>" );

}
else
{
echo( "<table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\">
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"2\"><font size=\"1\" face=\"Verdana\">
<center>This table has no records yet</center></font></td></tr></table>" );
} 
}

?>

Roger_Ramjet

Well apart from the fact that you are mixing POST and GET, you should just put each record in it's own <form> so that each submit button just submits the data for that record.

The_MA

Thanks - I swapped the Get and Posts around if that is right? And i put the submit buttons in

<form> </form>

but it still doesn't work :\ 🙁 I feel really stupid because I've made a silly mistake 😐

<html><head><title>View Users</title></head> 
<body> 

<?php 

session_start(); 

if (!isset($_SESSION['loggedin']) 
   || $_SESSION['loggedin'] !== true) { 

   header('Location: login.php'); 
   exit; 
} 

$conn= mysql_connect( "localhost", "alexm", "rugby" ) 
             or die( "Err:Conn" ); 

$db = mysql_select_db( "rugby_project", $conn) or die( "Err:Db" ); 

if (isset($_GET['submit']) && ($_GET["cmd"]=="edit" || $_GET["cmd"]=="edit"))  { 
      $userID = $_POST["userID"]; 
      $sql = "SELECT * FROM phone_numbers WHERE userID=$userID"; 
      $result = mysql_query($sql);         

      $row = mysql_fetch_array($result); 

if ($result) 
  { 

echo' <form action="$self" method="post"> 
      <input type=hidden name="userID" value="' . $row["userID"] . '"> 
      User<INPUT TYPE="TEXT" NAME="userID" VALUE="' . $row["userID"] . '" SIZE=30><br> 
      Number<INPUT TYPE="TEXT" NAME="number" VALUE="' . $row["number"] . '" SIZE=30><br> 
      Password<INPUT TYPE="TEXT" NAME="password" VALUE="' . $row["password"] . '" SIZE=30><br> 

  <input type="hidden" name="cmd" value="edit"> 

  <input type="submit" name="submit" value="submit"> 

  </form> ';   

echo( "<center><p><font size=\"1\" face=\"Verdana\"> 
<a href=\"viewdevices.php\">Back</a>&nbsp;&nbsp;|&nbsp; 
<a href=\"control.php\">Return to Control Panel</a>&nbsp;&nbsp;|&nbsp; 
<a href=\"logout.php\">Log out<p></a> 
</body></html>" ); 
  } 
} 
else 
{ 

$sql = "select userID, number, password from phone_numbers order by userID"; 

$rs = mysql_query( $sql,$conn); 
$self = $_SERVER['PHP_SELF']; 
$rows = mysql_num_rows($rs); 

echo( "<table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\"> 
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"4\"><font size=\"1\" face=\"Verdana\"> 
<center>User View</center></font></td></tr>" ); 
   echo( "<tr><td><font size=\"1\" face=\"Verdana\"><strong>User</td>" ); 
   echo( "<td><font size=\"1\" face=\"Verdana\"><strong>Phone Number</td>" ); 
   echo( "<td><font size=\"1\" face=\"Verdana\"><strong>Password</td>" ); 
   echo( "<td><font size=\"1\" face=\"Verdana\"><i><center>Edit</td></tr>" ); 


if(mysql_num_rows($rs)) 
{ 

echo( "<form name=\"editform\" method=\"post\" action=\"$self\">"); 

while( $row = mysql_fetch_array( $rs ) ){ 
   $userID=$row["userID"]; 
   $number=$row["number"]; 
   $password=$row["password"]; 
   echo '<tr><td><font size="2" face="Verdana">' . $userID . '</td>'; 
   echo '<td><font size="2" face="Verdana">' . $number . '</td>'; 
   echo '<td><font size="2" face="Verdana">' . $password . '</td>'; 
   echo '<td><center><form><input type="hidden" name="edit[]" value="' . $userID . '" /><input type="submit" name="edit" 

value="Edit"></form></td></tr>';    

} 

echo( "</table><p><table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" 

bordercolor=\"#000000\"> 
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"2\"><font size=\"1\" face=\"Verdana\"> 
<center>There are $rows records in this table</center></font></td></tr></table>" ); 

   echo( "<center><p><font size=\"1\" face=\"Verdana\"> 
<a href=\"control.php\">Return to Control Panel</a>&nbsp;&nbsp;|&nbsp; 
<a href=\"logout.php\">Log out<p></a> 
</body></html>" ); 

} 
else 
{ 
echo( "<table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\"> 
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"2\"><font size=\"1\" face=\"Verdana\"> 
<center>This table has no records yet</center></font></td></tr></table>" ); 
} 
} 

?>

Roger_Ramjet

NO. Your action on the form sez POST so you must use post in the target script.

Also, the <form> tag must come inside the WHILE loop same as the </form> tag.
Then, since you only have one hidden element on each form it's name can be just name="edit", instead of having to be an array name="edit[]".

The_MA

Hmm okay - I've annotated this with questions because it still doesn't work and I don't understand why and I'm thinking there may be integral structural problems with it....

<html><head><title>View Users</title></head> 
<body> 

<?php 

#Logged In Session

session_start(); 

if (!isset($_SESSION['loggedin']) 
   || $_SESSION['loggedin'] !== true) { 

   header('Location: login.php'); 
   exit; 
} 

#Connect

$conn= mysql_connect( "localhost", "alexm", "rugby" ) 
             or die( "Err:Conn" ); 

$db = mysql_select_db( "rugby_project", $conn) or die( "Err:Db" ); 

#Does this chunk below if(isset POST etc.) relate to the first form or the second?
#Chronologically... The records are all displayed... next to each record is an EDIT 
#button. When clicked the information from each record should be posted to the 
#next form which is a set off input boxes with the values of the selected record. A 
#submit button runs the the edit record query - submitting the edited values and r
#replacing the existing ones with them. Have even got one of these queries? I 
#wrote this a month ago and forgot what it contains... Anyway the chunk below 
#doesn't look like it does any of that...

if (isset($_POST['submit']) && ($_POST["cmd"]=="edit" || $_GET["cmd"]=="edit"))  { 
      $userID = $_GET["userID"]; 
      $sql = "SELECT * FROM phone_numbers WHERE userID=$userID"; 
      $result = mysql_query($sql);         

      $row = mysql_fetch_array($result); 

#The supposed Edit form - attained by clicking the edit submit button on the first 
#form which displays the records..

if ($result) 
  { 

echo' <form action="$self" method="post"> 
      <input type=hidden name="userID" value="' . $row["userID"] . '"> 
      User<INPUT TYPE="TEXT" NAME="userID" VALUE="' . $row["userID"] . '" SIZE=30><br> 
      Number<INPUT TYPE="TEXT" NAME="number" VALUE="' . $row["number"] . '" SIZE=30><br> 
      Password<INPUT TYPE="TEXT" NAME="password" VALUE="' . $row["password"] . '" SIZE=30><br> 

  <input type="hidden" name="cmd" value="edit"> 

  <input type="submit" name="submit" value="submit"> 

  </form> ';   

echo( "<center><p><font size=\"1\" face=\"Verdana\"> 
<a href=\"viewdevices.php\">Back</a>&nbsp;&nbsp;|&nbsp; 
<a href=\"control.php\">Return to Control Panel</a>&nbsp;&nbsp;|&nbsp; 
<a href=\"logout.php\">Log out<p></a> 
</body></html>" ); 
  } 
} 
else 
{ 

#This displays all the records...

$sql = "select userID, number, password from phone_numbers order by userID"; 

$rs = mysql_query( $sql,$conn); 
$self = $_SERVER['PHP_SELF']; 
$rows = mysql_num_rows($rs); 

echo( "<table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\"> 
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"4\"><font size=\"1\" face=\"Verdana\"> 
<center>User View</center></font></td></tr>" ); 
   echo( "<tr><td><font size=\"1\" face=\"Verdana\"><strong>User</td>" ); 
   echo( "<td><font size=\"1\" face=\"Verdana\"><strong>Phone Number</td>" ); 
   echo( "<td><font size=\"1\" face=\"Verdana\"><strong>Password</td>" ); 
   echo( "<td><font size=\"1\" face=\"Verdana\"><i><center>Edit</td></tr>" ); 

#Here is the edit button positioning next to each record which when clicked 
#should go to the edit form taking the details of the record with it...

if(mysql_num_rows($rs)) 
{ 

while( $row = mysql_fetch_array( $rs ) ){ 
echo( "<form name=\"edit\" method=\"post\" action=\"$self\">"); 
   $userID=$row["userID"]; 
   $number=$row["number"]; 
   $password=$row["password"]; 
   echo '<tr><td><font size="2" face="Verdana">' . $userID . '</td>'; 
   echo '<td><font size="2" face="Verdana">' . $number . '</td>'; 
   echo '<td><font size="2" face="Verdana">' . $password . '</td>'; 
   echo '<td><center><input type="hidden" name="edit" value="' . $userID . '" /><input type="submit" name="edit" value="Edit"></form></td></tr>';    

} 

#Some extra stuff at the bottom

echo( "</table><p><table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\"> 
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"2\"><font size=\"1\" face=\"Verdana\"> 
<center>There are $rows records in this table</center></font></td></tr></table>" ); 

   echo( "<center><p><font size=\"1\" face=\"Verdana\"> 
<a href=\"control.php\">Return to Control Panel</a>&nbsp;&nbsp;|&nbsp; 
<a href=\"logout.php\">Log out<p></a> 
</body></html>" ); 

} 
else 
{ 
echo( "<table width=\"30%\" border=\"1\" align=\"center\" cellpadding=\"4\" cellspacing=\"1\" bordercolor=\"#000000\"> 
<tr bgcolor=\"#CCCCCC\"> 
<td colspan=\"2\"><font size=\"1\" face=\"Verdana\"> 
<center>This table has no records yet</center></font></td></tr></table>" ); 
} 
} 

?>

Roger_Ramjet

You are still mixing get and post. IT IS POST so take every single mention of GET out of the script. DON'T YOU UNDERSTAND THE DIFFERENCE BETWEEN THEM THEN?

The_MA

Not really - as I understand it POST sends information and GET is the command used to receive the posted information? This is probably wrong then - thanks - so what is the difference and when does one use GET?

Mark.

Roger_Ramjet

Yes, you do not understand this at all.

Simple answer is for you to go and read about php superglobals .

Basically if you POST data from a form (by specifying method="post") then it arrives in the $POST array. If you pass data via the URL then it is available in the $GET array.

Now go and read about them in the manual, and about the other 'superglobals' that exist. Then fix your script.