update but not updated ??

perrohunter

Hi hi , im having a big problem, i have a text editor made with javascript, over a form , just like the one we use on forums (with small bugs 😛 ) , so far, i when i try to update the info , the result of my query returns true i think, but no info was updated :bemused: , ofcourse sometimes this message comes with html, but sometimes i dont , please help


include('connection.php');
$indexid = $_POST['id'];
$message = $_POST['message'];

$result = mysql_query("UPDATE my_table SET message='$message' WHERE id='$indexid' LIMIT 1;") or die(mysql_error());

if($result)
{
	echo "this info was recived and updated : $message";

}

AND IT SHOWS THE MESSAGE, it just wont update the database T_T , why ?
i use the same process for other things 🙁

rincewind456

Does it spit out an error from mysql?

Have you tried echoing out the variables $indexid and $ message to see if they are being set to what you think they are?

How are you protecting yourself against sql injection attacks? I see no escapeing of potential sql control characters in that snippet.

Plasma

$result holds the success or fail of the statement, not how many rows were updated.

mysql_affected_rows() is used for that.

As rincewind said, echo out the values of your query and see what they are.

perrohunter

thanks for your answers !

indeed , i didnt put any protection from injection becuase i though the filters where stopping the thing to get inside !

now, i do echo de message, and it appears ! its just that the row just didnt get affected but the $result returns true :/

and if i do the mysql_affected_rows() IT RETURNS 0 T_T ! !

what could i possibly be doing wrong ? :/

I didnt mention that im trying to update a TEXT like field , does that matters ? :S

thanks for your answers ,
any other ideas ? T_T T_T

Roger_Ramjet

What the others have said is ECHO OUT THE QUERY STRING before you run it. 10 to 1 you will have bad data in there and will see it when you see the query. It could be an invalid id or there copuld be invalid characters in the message - like apostrophies or slashes which need to be escaped.