Not using odbc_close will lead to problems ?

[PhilippeDJ]

I have this function to connect to our I5

////////////////////////
// executeReadSQL
////////////////////////
function executeReadSQL($sql){

  $conn = odbc_connect('I5','USER','PASSWORD');

  if (!$conn)
  {
    exit("Connection failed ! " . $conn);
  }

  $rs = odbc_exec($conn,$sql);
  if (!$rs)
  {
    exit("Error in sql " . $sql);
  }

  return($rs);

}

Problem here is I think I'm not closing the odbc connection with the odbc_close connection, will this lead to problems ?

How can I close the connection and still use this function ?

Do I need to use a class instead ?

[laserlight]

You dont need to explicitly close the database connection, PHP will do that for you when the script ends.

[Weedpacket]

I don't know what would happen if you try opening the same connection twice without closing the first one. All the manual says is "You can have multiple connections open at once as long as they either use different db or different credentials."

The problem here is that you're getting the job "connect to the database" tangled up with the job "query the database". Separate the two tasks, so that you can do one without having to do the other as well. Then connect once at the start, and make queries using that connection as often as you like.

[PhilippeDJ]

It seems to work like this, but Weedpacket you have a good point, I need to split up making the connection and executing the queries !