[RESOLVED] Unlink problem

[gszauer]

$location = "localhost"; 
$username = "cape"; 
$password = "e******"; 
$database = "cape_program"; 
$id = $_POST["list"];
$sell = "true";
mysql_connect($hostname,$username, $password) OR DIE (" ");
mysql_select_db($database); 
$conn = @mysql_connect($location,$username,$password); 

$path = '/wizard/data';
set_include_path(get_include_path() . PATH_SEPARATOR . $path);

mysql_select_db($database,$conn) or die ("Could not open database"); 
$result = mysql_query("SELECT tn,p1,p2,p3,p4,p5,p6,p7,p8,p9,p10 FROM db_x WHERE sold='$sell'");
list ($tn,$p1,$p2,$p3,$p4,$p5,$p6,$p7,$p8,$p9,$p10) = mysql_fetch_array($result);

unlink("http://yourcapecoral.com/wizard/data/$tn");
unlink("http://yourcapecoral.com/wizard/data/$p1");
unlink("http://yourcapecoral.com/wizard/data/$p2");
unlink("http://yourcapecoral.com/wizard/data/$p3");
unlink("http://yourcapecoral.com/wizard/data/$p4");
unlink("http://yourcapecoral.com/wizard/data/$p5");
unlink("http://yourcapecoral.com/wizard/data/$p6");
unlink("http://yourcapecoral.com/wizard/data/$p7");
unlink("http://yourcapecoral.com/wizard/data/$p8");
unlink("http://yourcapecoral.com/wizard/data/$p9");
unlink("http://yourcapecoral.com/wizard/data/$p10");

$delete = "DELETE FROM db_x WHERE sold='true'";
mysql_query($delete) or die ("An error has occured, and the data can not be added to the list, please contact Gabor. <Br />Error: " . mysql_error());
?>

The Script is soposed to delete the files, yet when i run it i get this messege:

Warning: unlink(http://yourcapecoral.com/wizard/data/Sunset.jpg): No such file or directory in /home/cape/public_html/wizard/recycle2.php on line 36

the php file is located at
yourcapecoral.com/wizard
and the image files are located at
yourcapecoral.com/wizard/data

Can anyone help determine whats wrong?
~Gabor

[shonuff]

Take off the leading slash? 😃

Change to:

$path = 'wizard/data'; 

[bradgrafelman]

Wait... you're trying to unlink an URL? How can the server delete a file across the web?? That's not possible...

If you're trying to delete files on your own website, you have to use system paths (or relative system paths), not website URLs.

To use relative paths, from the directory /wizard/, you would do something like this:

unlink("data/$tn");
unlink("data/$p1");

and so on.

[gszauer]

Thank you Bradgrafelman,
I get this error

Warning: unlink(data/): Is a directory in /home/cape/public_html/wizard/recycle2.php on line 39

But the files do get deleted, so it doesnt matter too mutch 🙂

[bradgrafelman]

Which line is #39? I have a feeling one of your variables isn't set correctly.

[Sayian]

Your getting that error because your trying to delete a directory, not a file.

unlink is not used to delete directorys, infact their is no direct php function to delete a directory.

You could look at google, for "Recursive Directory Deletion" if your trying to delete the file and the the directory itself.

Other wise, you shouldnt try to perform unlink commands on directorys, b/c the function is not designed to handle such tasks.

[Weedpacket]

I notice you don't check to see if all those $p1...$p10 contain anything. What if one is empty? Then there'll be nothing to put after the "data/" in the unlink statement. and 'unlink("data/$p6");' or whatever will turn into 'unlink("data/");'.

I'd strongly recommend rethinking your database schema and normalising it. It would shorten this code a lot, make it more flexible (like being able to handle eleven pictures), and also avoid having to explicitly check every single picture variable to see if it's empty or not before trying to use it to delete a file.

[gszauer]

Thanks, that all made sence.
Weedpacket,
Id do that, but im a flash designer... Lets just call my php skills "questionable"
~Gabor

[bradgrafelman]

for($i = 1; isset(${'p'.$i}); $i++) {
     if(!empty(${'p'.$i}))
          unlink('data/' . ${'p'.$i});
}

Easy way to start at $p1 and start incrementing the number until you run out of variables.

[gszauer]

I didnt know you could use the ! sign to say "not" in php, i thought it was in other languages....
Wow, i learn something every day, thank you