[RESOLVED] Links Stopped Working

breezy421

I have a few PHP websites. A few weeks ago the links on those websites just decided to stop working. I didn't change anything. Not the code, not the server, nothing. The links just stopped working all by themselves.

Both websites are set up with template.php/index.php as the structure and plain html pages for the content.

the index php:

<?php
$MainPage = "template.php"; // Main Template File
$Content = "./page"; // Location of Content
$PageExtension = ".php"; // What comes at the end of the x...
$default = "/lucia/home.htm";

require ("template.php");
?>

the template php:

<?php
if(!$x) {
include("../$default");
} else {
include("../$x"); }
?>

example of broken link:

http://infraredwebdesign.com/lucia/index.php?x=lucia/lucia.htm

the default content (home.html) is still showing up, even when you click links to other pages on the site.

please help!!! i've been trying to fix this for days.

bradgrafelman

register_globals got turned off. You should be thankful, as it's not a good security practice to have it enabled. You can search the board (or even Google I'm sure) for more info.

In short, you need to start using superglobals as defined on this man page: [man]variables.predefined[/man]. Here's an example of how to retrieve the 'x' variable from data sent via the GET method (in the query string):

<?PHP
if(!@$_GET['x']) {
     include("../$default");
} else {
     include('../' . $_GET['x']);
}

Two things you'll want to notice in my sample code:

I added the @ error surpressor. Search php.net for 'error surpressor' and I'm sure you'll find it. Basically, if the variable isn't set and you just try the if(!$x) syntax, PHP will throw out an E_WARNING error.
Not only is it bad coding technique (in my and most likely others' opinions) but it will not work correctly if you try to reference indeces of arrays inside of string. What does this mean? Well...

Good:

include('../' . $_GET['x']);

BAD:

include("../$_GET['x']");

Escape out of the string and concatenate the string with periods if you reference arrays w/ indeces.

breezy421

thanks!

so the first code you posted... that's what i should replace mine with right?

and one more thing... how did my register_globals just get turned off like that? was it something i did?

thank you very much!

bradgrafelman

Yes, the first block of PHP code I posted is what you need in your script(s). You should format all of your POST and GET variables like that.

Register_globals can get turned off in one of 3 ways:

Change the value in the php.ini/php.conf file
Use the "php_admin_value" to change it in your webserver's http.conf file
Create a .htaccess file in the directory of your website and use "php_value" to change it.

If you don't own the server, it's possible that your host upgraded PHP or simply reconfigured their installation of PHP. Register_globals is turned off by default in newer installations I do believe.

breezy421

thank you so much! you have been very helpful. it worked BTW, but i'm sure you knew it would 😉