Anyone know a smaller version of table row exclusion??

Nomaad

I have a table in MySQL with 46 fields. These 46 fields cover property type listings from commercial to rentals. There are actually 6 different property types. I would like one page to display all 6 property types but some use fields others don't. I am writing my page to exclude an HTML table row if the field is empty in the record. But I was wondering if the code you'll see below is going to be slow with 46 of them on the page and if there might be some expression to do this in a smaller footprint . . .

My code is like this for each of the 46 fields:

		 if ($row_prop_result['acreage'] == '') {
		echo "";
		}
		else {
		 echo "<tr><td>".$row_prop_result['acreage']."</td></tr>";
         }

bpat1434

Nah, you should be all right. Now, it would cause a problem if you were doing 15000 rows, and 7 checks per row for emptiness.... but that's not the case. One way around that is to just standardize it. And in the database, put the default value if it's not filled in. Something like a default value of "Not Entered" or "Information Unavailable".

Then you're guaranteed not to have any "empty" areas, and each table will be the same and possibly easier to read.

Plasma

Could you post more code, such as how your getting the results and the initial block of the 'if' statements?

This can be simplified 🙂

Nomaad

My issue is this, if you enter the admin area and are adding say a commercial property, you may to use the fields "zone, taxes, fencing, rail, dock" if you then add a property to rental you need a different set of fields to fill in. Well when the display side runs, if they click on rental, I only want the fields with data in that record displayed, BUT I really didn't want to code my queries with those sets and make 6 different display pages. Make any sense?

This is my query, I am getting the ID set by the previous pages list of the property:

$colname_prop_result = "-1";
if (isset($_GET['prop_id'])) {
  $colname_prop_result = (get_magic_quotes_gpc()) ? $_GET['prop_id'] : addslashes($_GET['prop_id']);
}

mysql_select_db($database_car_connect, $car_connect);
$query_prop_result = "SELECT * FROM properties WHERE prop_id = $colname_prop_result";
$prop_result = mysql_query($query_prop_result, $car_connect) or die(mysql_error());
$row_prop_result = mysql_fetch_assoc($prop_result);
$totalRows_prop_result = mysql_num_rows($prop_result);

This is the first IF block:

      if ($row_prop_result['prop_status'] == '') {
		echo "";
		}
		else {
      echo "<tr><td>Property Status:</td><td>".$row_prop_result['prop_status']."</td></tr>";
	  }

Roger_Ramjet

Well now, you can make the display easier by doing this

$sql = "SELECT prop_status AS 'Property Status:', acreage AS 'Acreage:',"
   // etc for all cols
   "WHERE prop_id = $colname_prop_result";


// then you just need to do this to display whatever comes back

$row_prop_result = mysql_fetch_array(mysql_query($sql));
foreach ($row_prop_result as $key=>$val) {
   if ($val != '') echo '<tr><td>' . $key . '</td><td>' . $val . '</td></tr>';
}

Part of the trick I use here is to alias the column name to the display name, a thing I commonly do as it makes processing the output for display that much easier. It makes the query longer to write but saves a lot more php coding of all those if/else statements.