[RESOLVED] HTML inside php

[gszauer]

<?php
$id = $_REQUEST['id'];
if($letter == "") {
    $letter = "id";
} 
			$location = "localhost";
			$username = "program"; 
			$password = "e******"; 
			$database = "program_program"; 

		mysql_connect($hostname,$username, $password) OR DIE (" ");
		mysql_select_db($database); 
		$conn = @mysql_connect($location,$username,$password); 
		mysql_select_db($database,$conn) or die ("Could not open database"); 

		$result = mysql_query("SELECT address,description,tn,p1,p2,p3,p4,p5,p6,p7,p8,p9,p10 FROM db_x WHERE id=$id");
		list ($address,$description,$tn,$p1,$p2,$p3,$p4,$p5,$p6,$p7,$p8,$p9,$p10) = mysql_fetch_array($result);
   <table cellpadding="0" cellspacing="0" width="752" class="Middle">
	<tr>
		<td width="2%"><img src="_blank.gif" width="12" height="1"></td>
		<td valign="top"><table width="717" cellpadding="0" cellspacing="0" class="Font1">
			    <tr>
						<td width="41" background="images/h2.gif"><img src="images/h1.gif" width="41" height="22"></td>
					<td width="674" background="images/h2.gif" class="style3">My Listings &gt; Homes &gt; '".$address."' </td>
		  </tr>
		    </table>	

	  <table width="685" border="0" cellpadding="0" cellspacing="0">
        <tr>
          <td width="52" height="55">&nbsp;</td>
          <td colspan="3"><textarea name="details" cols="95" rows="8">'".$description."'</textarea></td>
          <td width="63">&nbsp;</td>
        </tr>
        <tr>
          <td>&nbsp;</td>
          <td width="200"><img src="http://yourcapecoral.com/wizard/data/$p1" width="200" height="162"></td>
          <td width="200"><img src="http://yourcapecoral.com/wizard/data/$p2" width="200" height="162" border="0"></td>
          <td width="201"><img src="http://yourcapecoral.com/wizard/data/$p3" width="200" height="162"></td>
          <td>&nbsp;</td>
        </tr>
        <tr>
          <td>&nbsp;</td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p4" width="200" height="162"></td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p5" width="200" height="162"></td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p6" width="200" height="162"></td>
          <td>&nbsp;</td>
        </tr>
        <tr>
          <td>&nbsp;</td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p7" width="200" height="162"></td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p8" width="200" height="162"></td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p9" width="200" height="162"></td>
          <td>&nbsp;</td>
        </tr>
        <tr>
          <td>&nbsp;</td>
          <td>&nbsp;</td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p10" width="200" height="162"></td>
          <td>&nbsp;</td>
          <td>&nbsp;</td>
        </tr>
      </table>	  
	  ?>

I think that should work, but i get this error
Parse error: parse error, unexpected '<' in /home/cape/public_html/homes.php on line 183
The error is on every line statting with a <
Can anyone please assist me?
Thank you for your time,
~Gabor Szauer

[FatalError]

You have to close your PHP code with ?>, otherwise it thinks the HTML is PHP code. Here is what you should change your code to:

<?php
$id = $_REQUEST['id'];
if($letter == "") {
    $letter = "id";
}
            $location = "localhost";
            $username = "program";
            $password = "e******";
            $database = "program_program";

        mysql_connect($hostname,$username, $password) OR DIE (" ");
        mysql_select_db($database);
        $conn = @mysql_connect($location,$username,$password);
        mysql_select_db($database,$conn) or die ("Could not open database");

        $result = mysql_query("SELECT address,description,tn,p1,p2,p3,p4,p5,p6,p7,p8,p9,p10 FROM db_x WHERE id=$id");
        list ($address,$description,$tn,$p1,$p2,$p3,$p4,$p5,$p6,$p7,$p8,$p9,$p10) = mysql_fetch_array($result);
?>
   <table cellpadding="0" cellspacing="0" width="752" class="Middle">
    <tr>
        <td width="2%"><img src="_blank.gif" width="12" height="1"></td>
        <td valign="top"><table width="717" cellpadding="0" cellspacing="0" class="Font1">
                <tr>
                        <td width="41" background="images/h2.gif"><img src="images/h1.gif" width="41" height="22"></td>
                    <td width="674" background="images/h2.gif" class="style3">My Listings &gt; Homes &gt; '".$address."' </td>
          </tr>
            </table>    

      <table width="685" border="0" cellpadding="0" cellspacing="0">
        <tr>
          <td width="52" height="55">&nbsp;</td>
          <td colspan="3"><textarea name="details" cols="95" rows="8">'".$description."'</textarea></td>
          <td width="63">&nbsp;</td>
        </tr>
        <tr>
          <td>&nbsp;</td>
          <td width="200"><img src="http://yourcapecoral.com/wizard/data/$p1" width="200" height="162"></td>
          <td width="200"><img src="http://yourcapecoral.com/wizard/data/$p2" width="200" height="162" border="0"></td>
          <td width="201"><img src="http://yourcapecoral.com/wizard/data/$p3" width="200" height="162"></td>
          <td>&nbsp;</td>
        </tr>
        <tr>
          <td>&nbsp;</td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p4" width="200" height="162"></td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p5" width="200" height="162"></td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p6" width="200" height="162"></td>
          <td>&nbsp;</td>
        </tr>
        <tr>
          <td>&nbsp;</td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p7" width="200" height="162"></td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p8" width="200" height="162"></td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p9" width="200" height="162"></td>
          <td>&nbsp;</td>
        </tr>
        <tr>
          <td>&nbsp;</td>
          <td>&nbsp;</td>
          <td><img src="http://yourcapecoral.com/wizard/data/$p10" width="200" height="162"></td>
          <td>&nbsp;</td>
          <td>&nbsp;</td>
        </tr>
      </table>      

Notice how I closed the PHP code before the HTML started. 🙂

[gszauer]

<td width="200"><img src="http://yourcapecoral.com/wizard/data/$p1" width="200" height="162"></td>

Would those images still load?
The image's name is defined from the $p1 variable, witch i have to be in php for 🙁

[FatalError]

Oh...I missed that...

Consider using echo, then you can just echo that whole piece of HTML, and use "." where needed to add the variables. However, the downside to that is you would need to escape all ' characters (single quotes) in the HTML. In other words, have something like this:

echo '<td width="200"><img src="http://yourcapecoral.com/wizard/data/' . $p1 . '" width="200" height="162"></td>';

[bradgrafelman]

If you want to enclose a lot of HTML inside PHP, you might consider using heredoc syntax (here's a link to the man page).

For example:

            $result = mysql_query("SELECT address,description,tn,p1,p2,p3,p4,p5,p6,p7,p8,p9,p10 FROM db_x WHERE id=$id"); 
            list ($address,$description,$tn,$p1,$p2,$p3,$p4,$p5,$p6,$p7,$p8,$p9,$p10) = mysql_fetch_array($result); 

        echo <<<endOfHTML
   <table cellpadding="0" cellspacing="0" width="752" class="Middle"> 
    <tr> 
        <td width="2%"><img src="_blank.gif" width="12" height="1"></td> 
        <td valign="top"><table width="717" cellpadding="0" cellspacing="0" class="Font1"> 
                <tr> 
                        <td width="41" background="images/h2.gif"><img src="images/h1.gif" width="41" height="22"></td> 
                    <td width="674" background="images/h2.gif" class="style3">My Listings &gt; Homes &gt; {$address}</td> 
          </tr> 
            </table>     

      <table width="685" border="0" cellpadding="0" cellspacing="0"> 
        <tr> 
          <td width="52" height="55">&nbsp;</td> 
          <td colspan="3"><textarea name="details" cols="95" rows="8">{$description}</textarea></td> 
          <td width="63">&nbsp;</td> 
        </tr> 
        <tr> 
          <td>&nbsp;</td> 
          <td width="200"><img src="http://yourcapecoral.com/wizard/data/{$p1}" width="200" height="162"></td> 
          <td width="200"><img src="http://yourcapecoral.com/wizard/data/{$p2}" width="200" height="162" border="0"></td> 
          <td width="201"><img src="http://yourcapecoral.com/wizard/data/{$p3}" width="200" height="162"></td> 
          <td>&nbsp;</td>
(etc. throughout rest of HTML code...)
endOfHTML;

// continue on with PHP code

[Sayian]

Personally, i use smarty to seperate logic from presentation.

Look into it sometime .. http://smarty.php.net

[bradgrafelman]

I've rigged up a mini template system in another large PHP project, but the concept is the same as using Smarty - separate HTML from PHP, PHP code from HTML code, however you want to put it.

[gszauer]

wow, those are interesting,
I'll look into the samarty thing,
and thank you all for the help.

[visualAd]

I don't like echoing huge chunks of HTML in PHP. Firstly, if inside a heredoc or a double quoted string, it puts extra and often un-neccessary strain on the PHP interpreter while it searches for embedded varaibles. Secondly, it screws up most syntax highlighters and makes the code unreadable and ugly.

The thread title contradicts the very definition of PHP, "a server side interpreted HTML embedded scripting language". 🙂

So, that said, in my opinion, it would be best to do this:

<?php
$id = $_REQUEST['id'];
if($letter == "") {
    $letter = "id";
}
            $location = "localhost";
            $username = "program";
            $password = "e******";
            $database = "program_program";

        mysql_connect($hostname,$username, $password) OR DIE (" ");
        mysql_select_db($database);
        $conn = @mysql_connect($location,$username,$password);
        mysql_select_db($database,$conn) or die ("Could not open database");

        $result = mysql_query("SELECT address,description,tn,p1,p2,p3,p4,p5,p6,p7,p8,p9,p10 FROM db_x WHERE id=$id");
        list ($address,$description,$tn,$p1,$p2,$p3,$p4,$p5,$p6,$p7,$p8,$p9,$p10) = mysql_fetch_array($result);
?>
<html>
  <body>
   <table cellpadding="0" cellspacing="0" width="752" class="Middle">
    <tr>
        <td width="2%"><img src="_blank.gif" width="12" height="1"></td>
        <td valign="top"><table width="717" cellpadding="0" cellspacing="0" class="Font1">
                <tr>
                        <td width="41" background="images/h2.gif"><img src="images/h1.gif" width="41" height="22"></td>
                    <td width="674" background="images/h2.gif" class="style3">My Listings &gt; Homes &gt; '".$address."' </td>
          </tr>
            </table>    

      <table width="685" border="0" cellpadding="0" cellspacing="0">
        <tr>
          <td width="52" height="55">&nbsp;</td>
          <td colspan="3"><textarea name="details" cols="95" rows="8">'".$description."'</textarea></td>
          <td width="63">&nbsp;</td>
        </tr>
        <?php for($x = 1; $x <= 9): // a loop makes it easier ?>
            <?php if($x % 3 == 1): // first one in the row, so make a new table row?>
            <tr>
              <td>&nbsp;</td>
            <?php endif; ?>

                <td width="200">
                    <img 
    src="http://yourcapecoral.com/wizard/data/<?php echo(${'p' . $x}) ?>" width="200" height="162"></td>

	         <?php if($x % 3 == 0): 
                            // this means 3 have been output, so end the table row ?>
              <td>&nbsp;</td>
            </tr>
            <?php endif; ?>
        <?php endfor; ?>
        <tr>
          <td>&nbsp;</td>
          <td>&nbsp;</td>
          <td><img src="http://yourcapecoral.com/wizard/data/<?php echo($p10) ?>" 
                     width="200" height="162"></td>
          <td>&nbsp;</td>
          <td>&nbsp;</td>
        </tr>
      </table>
</body>
</html>

The alternate syntax for control structures in PHP lends itself to separation of display logic. Especially in situations where smarty is a overkill or cannot be used.

[gszauer]

crap, error, i used bradgrafelman's code, and got this

Parse error: parse error, unexpected $ in /home/cape/public_html/homes.php on line 243

on 243 i have
</div>

if i delete that it will read the same error for 242,
any suggestions?

[visualAd]

There is no </div> in his code. Often the line that cuases the error is the line before the one which generates the error. Wht is the line above?

[gszauer]

Changed the Code to (this is the full script)

<head>
	<link rel="stylesheet" type="text/css" href="Template077Blank.css">
<script type="text/javascript">
var menu1=new Array()
menu1[0]='<a href="homes.html">Homes</a>'
menu1[1]='<a href="condos.html">Condos</a>'
menu1[2]='<a href="land.html">Land</a>'

var menu2=new Array()
menu2[0]='<a href="ma.html">Market Analysis</a>'
menu2[1]='<a href="ps.html">Property Search</a>'

var menuwidth='165px' 
var menubgcolor='#C8C5AE'  

var disappeardelay=250 
var hidemenu_onclick="no"

var ie4=document.all
var ns6=document.getElementById&&!document.all

if (ie4||ns6)
document.write('<div id="dropmenudiv" style="visibility:hidden;width:'+menuwidth+';background-color:'+menubgcolor+'" onMouseover="clearhidemenu()" onMouseout="dynamichide(event)"></div>')

function getposOffset(what, offsettype){
var totaloffset=(offsettype=="left")? what.offsetLeft : what.offsetTop;
var parentEl=what.offsetParent;
while (parentEl!=null){
totaloffset=(offsettype=="left")? totaloffset+parentEl.offsetLeft : totaloffset+parentEl.offsetTop;
parentEl=parentEl.offsetParent;
}
return totaloffset;
}


function showhide(obj, e, visible, hidden, menuwidth){
if (ie4||ns6)
dropmenuobj.style.left=dropmenuobj.style.top=-500
if (menuwidth!=""){
dropmenuobj.widthobj=dropmenuobj.style
dropmenuobj.widthobj.width=menuwidth
}
if (e.type=="click" && obj.visibility==hidden || e.type=="mouseover")
obj.visibility=visible
else if (e.type=="click")
obj.visibility=hidden
}

function iecompattest(){
return (document.compatMode && document.compatMode!="BackCompat")? document.documentElement : document.body
}

function clearbrowseredge(obj, whichedge){
var edgeoffset=0
if (whichedge=="rightedge"){
var windowedge=ie4 && !window.opera? iecompattest().scrollLeft+iecompattest().clientWidth-15 : window.pageXOffset+window.innerWidth-15
dropmenuobj.contentmeasure=dropmenuobj.offsetWidth
if (windowedge-dropmenuobj.x < dropmenuobj.contentmeasure)
edgeoffset=dropmenuobj.contentmeasure-obj.offsetWidth
}
else{
var topedge=ie4 && !window.opera? iecompattest().scrollTop : window.pageYOffset
var windowedge=ie4 && !window.opera? iecompattest().scrollTop+iecompattest().clientHeight-15 : window.pageYOffset+window.innerHeight-18
dropmenuobj.contentmeasure=dropmenuobj.offsetHeight
if (windowedge-dropmenuobj.y < dropmenuobj.contentmeasure){ 
edgeoffset=dropmenuobj.contentmeasure+obj.offsetHeight
if ((dropmenuobj.y-topedge)<dropmenuobj.contentmeasure)
edgeoffset=dropmenuobj.y+obj.offsetHeight-topedge
}
}
return edgeoffset
}

function populatemenu(what){
if (ie4||ns6)
dropmenuobj.innerHTML=what.join("")
}


function dropdownmenu(obj, e, menucontents, menuwidth){
if (window.event) event.cancelBubble=true
else if (e.stopPropagation) e.stopPropagation()
clearhidemenu()
dropmenuobj=document.getElementById? document.getElementById("dropmenudiv") : dropmenudiv
populatemenu(menucontents)

if (ie4||ns6){
showhide(dropmenuobj.style, e, "visible", "hidden", menuwidth)
dropmenuobj.x=getposOffset(obj, "left")
dropmenuobj.y=getposOffset(obj, "top")
dropmenuobj.style.left=dropmenuobj.x-clearbrowseredge(obj, "rightedge")+"px"
dropmenuobj.style.top=dropmenuobj.y-clearbrowseredge(obj, "bottomedge")+obj.offsetHeight+"px"
}

return clickreturnvalue()
}

function clickreturnvalue(){
if (ie4||ns6) return false
else return true
}

function contains_ns6(a, b) {
while (b.parentNode)
if ((b = b.parentNode) == a)
return true;
return false;
}

function dynamichide(e){
if (ie4&&!dropmenuobj.contains(e.toElement))
delayhidemenu()
else if (ns6&&e.currentTarget!= e.relatedTarget&& !contains_ns6(e.currentTarget, e.relatedTarget))
delayhidemenu()
}

function hidemenu(e){
if (typeof dropmenuobj!="undefined"){
if (ie4||ns6)
dropmenuobj.style.visibility="hidden"
}
}

function delayhidemenu(){
if (ie4||ns6)
delayhide=setTimeout("hidemenu()",disappeardelay)
}

function clearhidemenu(){
if (typeof delayhide!="undefined")
clearTimeout(delayhide)
}

if (hidemenu_onclick=="yes")
document.onclick=hidemenu

</script>
</head>
<div align="center">
<body topmargin="0" leftmargin="0">
<table cellpadding="0" cellspacing="0" width="752" class="Top">
	<tr>
		<td><img src="images/toprow.jpg" width="750" height="210"></td>
	</tr>
</table>
<table cellpadding="0" cellspacing="0" width="752" class="Middle">
  <tr>
    <td><a href="index.html" target="_self"><img src="images/home.gif" width="58" height="26" border="0" lowsrc="/images/home.png"></a></td>
    <td><a href="listings.html" onClick="return clickreturnvalue()" onMouseOver="dropdownmenu(this, event, menu1, '150px')" onMouseOut="delayhidemenu()"><img src="images/listings.gif" border="0" width="74" height="26"></a></td>
    <td><a href="mls.html" target="_self"><img src="images/mls.gif"border="0"alt="" width="66" height="26"></a></td>
    <td><a href="buyer.html" target="_self"onClick="return clickreturnvalue()" onMouseover="dropdownmenu(this, event, menu2, '150px')" onMouseout="delayhidemenu()"><img src="images/buyer.gif" width="85" height="26" border="0" lowsrc="/images/buyer.png"></a><a href="rental.html" target="_self"><img src="images/rental.gif"width="58" height="26" border="0"></a></td>
    <td><a href="links.html" target="_self"><img src="images/links.gif" width="58" height="26" border="0" lowsrc="/images/links.png"></a></td>
    <td width="100%"><a href="contact.html" target="_self"><img src="images/contact.gif" width="70" height="26" border="0" lowsrc="/images/contact.png"></a><a href="about.html" target="_self"><img src="images/about.gif" width="75" height="26" border="0" lowsrc="/images/about.png"></a><a href="interactive.html" target="_self"><img src="images/interactive.gif" border="0" width="66" height="26"></a></td>
  </tr>
</table>
<div align="center"></div>
<table cellpadding="0" cellspacing="0" width="752" class="Middle">
	<tr>
		<td class="Shadow1Back">&nbsp;</td>
	</tr>
</table>	
	<?php
$id = $_REQUEST['id'];
if($letter == "") {
    $letter = "id";
} 
			$location = "localhost";
			$username = "program"; 
			$password = "e******"; 
			$database = "program_program"; 

		mysql_connect($hostname,$username, $password) OR DIE (" ");
		mysql_select_db($database); 
		$conn = @mysql_connect($location,$username,$password); 
		mysql_select_db($database,$conn) or die ("Could not open database"); 

		$result = mysql_query("SELECT address,description,tn,p1,p2,p3,p4,p5,p6,p7,p8,p9,p10 FROM db_x WHERE id=$id");
        list ($address,$description,$tn,$p1,$p2,$p3,$p4,$p5,$p6,$p7,$p8,$p9,$p10) = mysql_fetch_array($result);

        echo <<<endOfHTML
   <table cellpadding="0" cellspacing="0" width="752" class="Middle">
    <tr>
        <td width="2%"><img src="_blank.gif" width="12" height="1"></td>
        <td valign="top"><table width="717" cellpadding="0" cellspacing="0" class="Font1">
                <tr>
                        <td width="41" background="images/h2.gif"><img src="images/h1.gif" width="41" height="22"></td>
                    <td width="674" background="images/h2.gif" class="style3">My Listings &gt; Homes &gt; {$address}</td>
          </tr>
            </table>     

      <table width="685" border="0" cellpadding="0" cellspacing="0">
        <tr>
          <td width="52" height="55">&nbsp;</td>
          <td colspan="3"><textarea name="details" cols="70" rows="8">{$description}</textarea></td>
          <td width="63">&nbsp;</td>
        </tr>
        <tr>
          <td>&nbsp;</td>
          <td width="200"><img src="http://yourcapecoral.com/wizard/data/{$p1}" width="200" height="162" border="0"></td>
          <td width="200"><img src="http://yourcapecoral.com/wizard/data/{$p2}" width="200" height="162" border="0"></td>
          <td width="201"><img src="http://yourcapecoral.com/wizard/data/{$p3}" width="200" height="162" border="0"></td>
          <td>&nbsp;</td> 
        </tr>
        <tr>
          <td>&nbsp;</td>
             <td width="200"><img src="http://yourcapecoral.com/wizard/data/{$p4}" width="200" height="162" border="0"></td>
             <td width="200"><img src="http://yourcapecoral.com/wizard/data/{$p5}" width="200" height="162" border="0"></td>
             <td width="201"><img src="http://yourcapecoral.com/wizard/data/{$p6}" width="200" height="162" border="0"></td>
          <td>&nbsp;</td>
        </tr>
        <tr>
          <td>&nbsp;</td>
             <td width="200"><img src="http://yourcapecoral.com/wizard/data/{$p7}" width="200" height="162" border="0"></td>
             <td width="200"><img src="http://yourcapecoral.com/wizard/data/{$p8}" width="200" height="162" border="0"></td>
             <td width="201"><img src="http://yourcapecoral.com/wizard/data/{$p9}" width="200" height="162" border="0"></td>
          <td>&nbsp;</td>
        </tr>
        <tr> 
          <td>&nbsp;</td>
          <td>&nbsp;</td>
         <td width="201"><img src="http://yourcapecoral.com/wizard/data/{$p10}" width="200" height="162" border="0"></td>
          <td>&nbsp;</td>
          <td>&nbsp;</td>
        </tr>
      </table>
	 endOfHTML>>>
 ?>
	  <p class="Indented8L DoubleBreakBefore">&nbsp;</p>		</td>
  <td width="2%"><img src="_blank.gif" width="12" height="1"></td>
</tr>
</table>
<table cellpadding="0" cellspacing="0" width="752" class="Bottom">
	<tr>
		<td><img src="images/bottomrow.jpg" width="750" height="58"></td>
	</tr>
</table>

I get this error

Parse error: parse error, unexpected $ in /home/cape/public_html/homes.php on line 240

[bradgrafelman]

endOfHTML>>>

This isn't the proper way to end a heredoc statement.

The identifier ("endOfHTML" in this case) has to be the first and ONLY thing that appears on a line, with the possibility of a semicolon after it. So, for example...

This is OK:

       echo <<<EndOfHTML
                  blah

                    blah....
              etc.
EndOfHtml;

while this is NOT OK:

      echo <<<endOfHTML
                  blah
                              etc.
      endOfHTML;

Why? Because there's whitespace before the identifier.

EDIT: As others have said above (at least I believe it was said in this thread...), PHP coding looks much better when you separate out all of the HTML junk into template files.

That way, instead of a large block of HTML in the middle of PHP code, you simply see something like:

        $temp = load_template('templates/generic.email.tpl');
        $temp = str_replace('{USER_NAME}', $username, $temp);
        // etc.

[gszauer]

I've had enough coding headaches,
If someone can make this file for me, i will provide all the backround info, and stuff,....
Pm me on yahoo,
mordocai_rp

[gszauer]

Someone did it.